summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | RDB AOF preamble: WIP 4 (Mixed RDB/AOF loading).antirez2016-08-112-6/+33
| | | |
| | * | RDB AOF preamble: WIP 3 (RDB loading refactoring).antirez2016-08-111-29/+38
| | | |
| | * | RDB AOF preamble: WIP 2.antirez2016-08-095-28/+37
| | | |
| | * | RDB AOF preamble: WIP 1.antirez2016-08-094-35/+72
| | | |
| * | | fix the fix for the TCP binding.antirez2016-09-091-10/+15
| | | | | | | | | | | | | | | | This commit attempts to fix a problem with PR #3467.
| * | | fix tcp binding when IPv6 is unsupportedoranagra2016-09-092-10/+14
| | | |
* | | | Example modules: Add C99 standard to cflags.antirez2016-09-091-2/+2
|/ / /
* | | debug.c: no need to define _GNU_SOURCE, is defined in fmacros.h.antirez2016-09-091-1/+0
| | |
* | | crash log - improve code dump with more info and called symbols.antirez2016-09-091-20/+59
| | |
* | | crash log - add hex dump of function codeoranagra2016-09-081-0/+22
| |/ |/|
* | dict.c benchmark minor improvements.antirez2016-09-071-1/+19
| |
* | dict.c benchmark: mixed del/insert benchmark.antirez2016-09-071-0/+11
| |
* | dict.c benchmark: finish rehashing before testing lookups.antirez2016-09-071-0/+5
| |
* | dict.c benchmark improvements.antirez2016-09-071-4/+27
| |
* | dict.c benchmark: take optional count argument.antirez2016-09-071-3/+11
| |
* | dict.c benchmark.antirez2016-09-072-1/+60
| |
* | Fix rdb.c var types when calling rdbLoadLen().antirez2016-09-011-3/+3
| | | | | | | | | | | | | | | | Technically as soon as Redis 64 bit gets proper support for loading collections and/or DBs with more than 2^32 elements, the 32 bit version should be modified in order to check if what we read from rdbLoadLen() overflows. This would only apply to huge RDB files created with a 64 bit instance and later loaded into a 32 bit instance.
* | sds: don't check for impossible string size in 32 bit systems.antirez2016-09-011-0/+3
|/
* Merge pull request #3340 from rojingeorge/unstableSalvatore Sanfilippo2016-08-051-0/+5
|\ | | | | Display the nodes' proper summary once the cluster is created using redis-trib
| * Merge remote-tracking branch 'refs/remotes/antirez/unstable' into unstableRojin George2016-06-302-1/+2
| |\
| * | Display the nodes summary once the cluster is established using redis-trib.rbrojingeorge2016-06-231-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Display the nodes summary once the cluster is established using redis-trib.rb After the cluster meet and join was done, when the summary was shown, it was giving info regarding the nodes. This fix ensures that confusion where the slaves were shown as masters. Fix would be to reset the nodes and reload the cluster information before checking the cluster status after creating it.
* | | Use the standard predefined identifier __func__ (since C99)Guo Xiao2016-08-041-1/+1
| | | | | | | | | | | | | | | Fix warning: ISO C does not support '__FUNCTION__' predefined identifier [-Wpedantic]
* | | Modules: basic call/reply tests in test module.antirez2016-08-031-0/+71
| | |
* | | Modules: handle NULL replies more gracefully.antirez2016-08-031-0/+6
| | | | | | | | | | | | | | | After all crashing at every API misuse makes everybody's life more complex.
* | | Security: Cross Protocol Scripting protection.antirez2016-08-033-2/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an attempt at mitigating problems due to cross protocol scripting, an attack targeting services using line oriented protocols like Redis that can accept HTTP requests as valid protocol, by discarding the invalid parts and accepting the payloads sent, for example, via a POST request. For this to be effective, when we detect POST and Host: and terminate the connection asynchronously, the networking code was modified in order to never process further input. It was later verified that in a pipelined request containing a POST command, the successive commands are not executed.
* | | Fix comment over 80 cols.antirez2016-08-031-1/+1
| | |
* | | Modules: initial draft for a testing module.antirez2016-08-033-93/+235
| | |
* | | Modules: StringAppendBuffer() and ability to retain strings.antirez2016-08-023-5/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RedisModule_StringRetain() allows, when automatic memory management is on, to keep string objects living after the callback returns. Can also be used in order to use Redis reference counting of objects inside modules. The reason why this is useful is that sometimes when implementing new data types we want to reference RedisModuleString objects inside the module private data structures, so those string objects must be valid after the callback returns even if not referenced inside the Redis key space.
* | | Fix a bug to delay bgsave while AOF rewrite in progress for replicationQu Chen2016-08-021-1/+1
| | |
* | | Remove extra "-" from ASCII horizontal bar in comment.antirez2016-08-022-2/+2
| | |
* | | Ability of slave to announce arbitrary ip/port to master.antirez2016-07-275-17/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | This feature is useful, especially in deployments using Sentinel in order to setup Redis HA, where the slave is executed with NAT or port forwarding, so that the auto-detected port/ip addresses, as listed in the "INFO replication" output of the master, or as provided by the "ROLE" command, don't match the real addresses at which the slave is reachable for connections.
* | | Multiple GEORADIUS bugs fixed.antirez2016-07-275-19/+120
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By grepping the continuous integration errors log a number of GEORADIUS tests failures were detected. Fortunately when a GEORADIUS failure happens, the test suite logs enough information in order to reproduce the problem: the PRNG seed, coordinates and radius of the query. By reproducing the issues, three different bugs were discovered and fixed in this commit. This commit also improves the already good reporting of the fuzzer and adds the failure vectors as regression tests. The issues found: 1. We need larger squares around the poles in order to cover the area requested by the user. There were already checks in order to use a smaller step (larger squares) but the limit set (+/- 67 degrees) is not enough in certain edge cases, so 66 is used now. 2. Even near the equator, when the search area center is very near the edge of the square, the north, south, west or ovest square may not be able to fully cover the specified radius. Now a test is performed at the edge of the initial guessed search area, and larger squares are used in case the test fails. 3. Because of rounding errors between Redis and Tcl, sometimes the test signaled false positives. This is now addressed. Whenever possible the original code was improved a bit in other ways. A debugging example stanza was added in order to make the next debugging session simpler when the next bug is found.
* | | Replication: when possible start RDB saving ASAP.antirez2016-07-221-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a previous commit the replication code was changed in order to centralize the BGSAVE for replication trigger in replicationCron(), however after further testings, the 1 second delay imposed by this change is not acceptable. So now the BGSAVE is only delayed if the AOF rewriting process is active. However past comments made sure that replicationCron() is always able to trigger the BGSAVE when needed, making the code generally more robust. The new code is more similar to the initial @oranagra patch where the BGSAVE was delayed only if an AOF rewrite was in progress. Trivia: delaying the BGSAVE uncovered a minor Sentinel issue that is now fixed.
* | | Sentinel: check Slave INFO state more often when disconnected.antirez2016-07-221-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During the initial handshake with the master a slave will report to have a very high disconnection time from its master (since technically it was disconnected since forever, so the current UNIX time in seconds is reported). However when the slave is connected again the Sentinel may re-scan the INFO output again only after 10 seconds, which is a long time. During this time Sentinels will consider this instance unable to failover, so a useless delay is introduced. Actaully this hardly happened in the practice because when a slave's master is down, the INFO period for slaves changes to 1 second. However when a manual failover is attempted immediately after adding slaves (like in the case of the Sentinel unit test), this problem may happen. This commit changes the INFO period to 1 second even in the case the slave's master is not down, but the slave reported to be disconnected from the master (by publishing, last time we checked, a master disconnection time field in INFO). This change is required as a result of an unrelated change in the replication code that adds a small delay in the master-slave first synchronization.
* | | Avoid simultaneous RDB and AOF child process.antirez2016-07-214-8/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch, written in collaboration with Oran Agra (@oranagra) is a companion to 780a8b1. Together the two patches should avoid that the AOF and RDB saving processes can be spawned at the same time. Previously conditions that could lead to two saving processes at the same time were: 1. When AOF is enabled via CONFIG SET and an RDB saving process is already active. 2. When the SYNC command decides to start an RDB saving process ASAP in order to serve a new slave that cannot partially resynchronize (but only if we have a disk target for replication, for diskless replication there is not such a problem). Condition "1" is not very severe but "2" can happen often and is definitely good at degrading Redis performances in an unexpected way. The two commits have the effect of always spawning RDB savings for replication in replicationCron() instead of attempting to start an RDB save synchronously. Moreover when a BGSAVE or AOF rewrite must be performed, they are instead just postponed using flags that will try to perform such operations ASAP. Finally the BGSAVE command was modified in order to accept a SCHEDULE option so that if an AOF rewrite is in progress, when this option is given, the command no longer returns an error, but instead schedules an RDB rewrite operation for when it will be possible to start it.
* | | Replication: start BGSAVE for replication always in replicationCron().antirez2016-07-211-12/+15
| | | | | | | | | | | | | | | | | | This makes the replication code conceptually simpler by removing the synchronous BGSAVE trigger in syncCommand(). This also means that socket and disk BGSAVE targets are handled by the same code.
* | | Fix maxmemory shared integer check bug introduced with LFU.antirez2016-07-211-1/+1
| | |
* | | Volatile-ttl eviction policy implemented in terms of the pool.antirez2016-07-202-48/+25
| | | | | | | | | | | | | | | Precision of the eviction improved sensibly. Also this allows us to have a single code path for most eviction types.
* | | LFU: make counter log factor and decay time configurable.lfuantirez2016-07-204-3/+24
| | |
* | | LFU: Use the LRU pool for the LFU algorithm.antirez2016-07-181-36/+25
| | | | | | | | | | | | | | | Verified to have better real world performances with power-law access patterns because of the data accumulated across calls.
* | | LFU: Fix bugs in frequency decay code.antirez2016-07-181-2/+2
| | |
* | | LFU: Initial naive eviction cycle.antirez2016-07-183-4/+49
| | | | | | | | | | | | | | | | | | | | | It is possible to get better results by using the pool like in the LRU case. Also from tests during the morning I believe the current implementation has issues in the frequency decay function that should decrease the counter at periodic intervals.
* | | redis-cli LRU test mode: randomize value of key when setting.antirez2016-07-181-1/+4
| | | | | | | | | | | | | | | This way it is possible from an observer to tell when the key is replaced with a new one having the same name.
* | | redis-cli LRU test mode: remove newline from key names.antirez2016-07-181-1/+1
| | |
* | | LFU: Redis object level implementation.antirez2016-07-155-15/+142
| | | | | | | | | | | | | | | Implementation of LFU maxmemory policy for anything related to Redis objects. Still no actual eviction implemented.
* | | LRU: Make cross-database choices for eviction.antirez2016-07-133-110/+161
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The LRU eviction code used to make local choices: for each DB visited it selected the best key to evict. This was repeated for each DB. However this means that there could be DBs with very frequently accessed keys that are targeted by the LRU algorithm while there were other DBs with many better candidates to expire. This commit attempts to fix this problem for the LRU policy. However the TTL policy is still not fixed by this commit. The TTL policy will be fixed in a successive commit. This is an initial (partial because of TTL policy) fix for issue #2647.
* | | LRU: cache SDS strings in the eviction pool.antirez2016-07-121-13/+29
| | | | | | | | | | | | | | | | | | | | | To destroy and recreate the pool[].key element is slow, so we allocate in pool[].cached SDS strings that can account up to 255 chars keys and try to reuse them. This provides a solid 20% performance improvement in real world workload alike benchmarks.
* | | Move the struct evictionPoolEntry() into only file using it.antirez2016-07-122-12/+22
| | | | | | | | | | | | Local scope is always better when possible.
* | | Move prototype of evictionPoolAlloc() in server.h.antirez2016-07-122-2/+3
| | |
* | | LRU: use C99 variable len stack array in evictionPoolPopulate().antirez2016-07-121-11/+1
| | |
View Lorry Controller Status