From 6add1b7217458dab90b2458e4bac3fa9a2c15e1b Mon Sep 17 00:00:00 2001
From: Oran Agra <oran@redislabs.com>
Date: Sun, 19 Dec 2021 17:41:51 +0200
Subject: Add external test that runs without debug command (#9964)

- add needs:debug flag for some tests
- disable "save" in external tests (speedup?)
- use debug_digest proc instead of debug command directly so it can be skipped
- use OBJECT ENCODING instead of DEBUG OBJECT to get encoding
- add a proc for OBJECT REFCOUNT so it can be skipped
- move a bunch of tests in latency_monitor tests to happen later so that latency monitor has some values in it
- add missing close_replication_stream calls
- make sure to close the temp client if DEBUG LOG fails
---
 .github/workflows/external.yml | 30 ++++++++++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

(limited to '.github')

diff --git a/.github/workflows/external.yml b/.github/workflows/external.yml
index 35b480106..b378236b2 100644
--- a/.github/workflows/external.yml
+++ b/.github/workflows/external.yml
@@ -15,7 +15,9 @@ jobs:
     - name: Build
       run: make REDIS_CFLAGS=-Werror
     - name: Start redis-server
-      run: ./src/redis-server --daemonize yes --logfile external-redis.log --enable-protected-configs yes --enable-debug-command yes --enable-module-command yes
+      run: |
+        ./src/redis-server --daemonize yes --save "" --logfile external-redis.log \
+          --enable-protected-configs yes --enable-debug-command yes --enable-module-command yes
     - name: Run external test
       run: |
           ./runtest \
@@ -36,7 +38,9 @@ jobs:
     - name: Build
       run: make REDIS_CFLAGS=-Werror
     - name: Start redis-server
-      run: ./src/redis-server --cluster-enabled yes --daemonize yes --logfile external-redis.log --enable-protected-configs yes --enable-debug-command yes --enable-module-command yes
+      run: |
+        ./src/redis-server --cluster-enabled yes --daemonize yes --save "" --logfile external-redis.log \
+          --enable-protected-configs yes --enable-debug-command yes --enable-module-command yes
     - name: Create a single node cluster
       run: ./src/redis-cli cluster addslots $(for slot in {0..16383}; do echo $slot; done); sleep 5
     - name: Run external test
@@ -51,3 +55,25 @@ jobs:
       with:
         name: test-external-cluster-log
         path: external-redis.log
+
+  test-external-nodebug:
+    runs-on: ubuntu-latest
+    timeout-minutes: 14400
+    steps:
+      - uses: actions/checkout@v2
+      - name: Build
+        run: make REDIS_CFLAGS=-Werror
+      - name: Start redis-server
+        run: |
+          ./src/redis-server --daemonize yes --save "" --logfile external-redis.log
+      - name: Run external test
+        run: |
+          ./runtest \
+            --host 127.0.0.1 --port 6379 \
+            --tags "-slow -needs:debug"
+      - name: Archive redis log
+        if: ${{ failure() }}
+        uses: actions/upload-artifact@v2
+        with:
+          name: test-external-redis-log
+          path: external-redis.log
-- 
cgit v1.2.1