From 90a6f7fc98df849a9890ab6e0da4485457bf60cd Mon Sep 17 00:00:00 2001 From: antirez Date: Mon, 19 Dec 2016 08:53:25 +0100 Subject: adjustOpenFilesLimit() comment made hopefully more clear. --- src/server.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index 3d5e29bed..aa5b65862 100644 --- a/src/server.c +++ b/src/server.c @@ -1576,7 +1576,10 @@ void adjustOpenFilesLimit(void) { if (bestlimit < maxfiles) { unsigned int old_maxclients = server.maxclients; - server.maxclients = bestlimit-CONFIG_MIN_RESERVED_FDS; /* NOTICE: server.maxclients is unsigned */ + server.maxclients = bestlimit-CONFIG_MIN_RESERVED_FDS; + /* maxclients is unsigned so may overflow: in order + * to check if maxclients is now logically less than 1 + * we test indirectly via bestlimit. */ if (bestlimit <= CONFIG_MIN_RESERVED_FDS) { serverLog(LL_WARNING,"Your current 'ulimit -n' " "of %llu is not enough for the server to start. " -- cgit v1.2.1