From 68e87eb0883abf542fd8a38fc51f462eca8b5a4f Mon Sep 17 00:00:00 2001 From: filipe oliveira Date: Wed, 30 Nov 2022 20:08:12 +0000 Subject: changing addReplySds and sdscat to addReplyStatusLength() within luaReplyToRedisReply() (#11556) profiling EVALSHA\ we see that luaReplyToRedisReply takes 8.73% out of the 56.90% of luaCallFunction CPU cycles. Using addReplyStatusLength instead of directly composing the protocol to avoid sdscatprintf and addReplySds ( which imply multiple sdslen calls ). The new approach drops luaReplyToRedisReply CPU cycles to 3.77% --- src/server.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/server.h') diff --git a/src/server.h b/src/server.h index 9dfbf81b7..105b2db4e 100644 --- a/src/server.h +++ b/src/server.h @@ -2507,6 +2507,7 @@ void addReplyBulkCString(client *c, const char *s); void addReplyBulkCBuffer(client *c, const void *p, size_t len); void addReplyBulkLongLong(client *c, long long ll); void addReply(client *c, robj *obj); +void addReplyStatusLength(client *c, const char *s, size_t len); void addReplySds(client *c, sds s); void addReplyBulkSds(client *c, sds s); void setDeferredReplyBulkSds(client *c, void *node, sds s); -- cgit v1.2.1