From 74959a0f73a44cfe56d5fb95957021c55b0ae214 Mon Sep 17 00:00:00 2001 From: YaacovHazan <31382944+YaacovHazan@users.noreply.github.com> Date: Thu, 20 Apr 2023 09:49:19 +0300 Subject: Misuse of bool in redis (#12077) We currently do not allow the use of bool type in redis project. We didn't catch it in script.c because we included hdr_histogram.h in server.h Removing it (but still having it in some c files) reducing the chance to miss the usage of bool type in the future and catch it in compiling stage. It also removes the dependency on hdr_histogram for every unit that includes server.h --- src/server.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/server.h') diff --git a/src/server.h b/src/server.h index b286b6803..222044ab9 100644 --- a/src/server.h +++ b/src/server.h @@ -53,7 +53,6 @@ #include #include #include -#include "hdr_histogram.h" #ifdef HAVE_LIBSYSTEMD #include @@ -92,6 +91,8 @@ typedef struct redisObject robj; #include "endianconv.h" #include "crc64.h" +struct hdr_histogram; + /* helpers */ #define numElements(x) (sizeof(x)/sizeof((x)[0])) -- cgit v1.2.1