From c07212372c3e03e9b4f459142d01a5f1895a0f9c Mon Sep 17 00:00:00 2001 From: Brad Dunbar Date: Wed, 24 Aug 2022 07:11:04 -0400 Subject: Cleanup in GETDEL: Strings are never freed lazily (#11175) The GETDEL command only operates on strings, and strings are never freed lazily, so there's no need to use `dbAsyncDelete` or `shared.unlink`. --- src/t_string.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'src/t_string.c') diff --git a/src/t_string.c b/src/t_string.c index 7b67b78ce..9d7bc44fc 100644 --- a/src/t_string.c +++ b/src/t_string.c @@ -411,12 +411,9 @@ void getexCommand(client *c) { void getdelCommand(client *c) { if (getGenericCommand(c) == C_ERR) return; - int deleted = server.lazyfree_lazy_user_del ? dbAsyncDelete(c->db, c->argv[1]) : - dbSyncDelete(c->db, c->argv[1]); - if (deleted) { - /* Propagate as DEL/UNLINK command */ - robj *aux = server.lazyfree_lazy_user_del ? shared.unlink : shared.del; - rewriteClientCommandVector(c,2,aux,c->argv[1]); + if (dbSyncDelete(c->db, c->argv[1])) { + /* Propagate as DEL command */ + rewriteClientCommandVector(c,2,shared.del,c->argv[1]); signalModifiedKey(c, c->db, c->argv[1]); notifyKeyspaceEvent(NOTIFY_GENERIC, "del", c->argv[1], c->db->id); server.dirty++; -- cgit v1.2.1