From 2271cf03f56525f153227c95b9521a5377321776 Mon Sep 17 00:00:00 2001 From: antirez Date: Thu, 5 Dec 2019 10:38:18 +0100 Subject: Modules: clarify when the disconnection callback is called. --- src/module.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/module.c b/src/module.c index 65c0f5b3f..111e1c202 100644 --- a/src/module.c +++ b/src/module.c @@ -4192,7 +4192,10 @@ void moduleBlockedClientPipeReadable(aeEventLoop *el, int fd, void *privdata, in void unblockClientFromModule(client *c) { RedisModuleBlockedClient *bc = c->bpop.module_blocked_handle; - /* Call the disconnection callback if any. */ + /* Call the disconnection callback if any. Note that + * bc->disconnect_callback is set to NULL if the client gets disconnected + * by the module itself, so the callback will NOT get called if this is + * not an actual disconnection event. */ if (bc->disconnect_callback) { RedisModuleCtx ctx = REDISMODULE_CTX_INIT; ctx.blocked_privdata = bc->privdata; -- cgit v1.2.1