From c31055db617a7fedb20c28c245ddad8ed2b11931 Mon Sep 17 00:00:00 2001 From: Oran Agra Date: Fri, 14 Aug 2020 16:05:34 +0300 Subject: Sanitize dump payload: fuzz tester and fixes for segfaults and leaks it exposed The test creates keys with various encodings, DUMP them, corrupt the payload and RESTORES it. It utilizes the recently added use-exit-on-panic config to distinguish between asserts and segfaults. If the restore succeeds, it runs random commands on the key to attempt to trigger a crash. It runs in two modes, one with deep sanitation enabled and one without. In the first one we don't expect any assertions or segfaults, in the second one we expect assertions, but no segfaults. We also check for leaks and invalid reads using valgrind, and if we find them we print the commands that lead to that issue. Changes in the code (other than the test): - Replace a few NPD (null pointer deference) flows and division by zero with an assertion, so that it doesn't fail the test. (since we set the server to use `exit` rather than `abort` on assertion). - Fix quite a lot of flows in rdb.c that could have lead to memory leaks in RESTORE command (since it now responds with an error rather than panic) - Add a DEBUG flag for SET-SKIP-CHECKSUM-VALIDATION so that the test don't need to bother with faking a valid checksum - Remove a pile of code in serverLogObjectDebugInfo which is actually unsafe to run in the crash report (see comments in the code) - fix a missing boundary check in lzf_decompress test suite infra improvements: - be able to run valgrind checks before the process terminates - rotate log files when restarting servers --- tests/instances.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/instances.tcl') diff --git a/tests/instances.tcl b/tests/instances.tcl index d3b1b50cd..156c92706 100644 --- a/tests/instances.tcl +++ b/tests/instances.tcl @@ -155,7 +155,7 @@ proc log_crashes {} { set logs [glob */err.txt] foreach log $logs { - set res [find_valgrind_errors $log] + set res [find_valgrind_errors $log true] if {$res != ""} { puts $res incr ::failed -- cgit v1.2.1