From 9b588f3820edd35d4cd44b69e96476095858fc06 Mon Sep 17 00:00:00 2001 From: judeng Date: Tue, 25 Apr 2023 15:17:21 +0800 Subject: minor optimization for slowlog get (#12103) We can always know the array length of the response, so there is no need to use addReplyDeferredLen which may introduce some additional overheads. --- tests/unit/slowlog.tcl | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'tests') diff --git a/tests/unit/slowlog.tcl b/tests/unit/slowlog.tcl index bc15c6411..3c547b924 100644 --- a/tests/unit/slowlog.tcl +++ b/tests/unit/slowlog.tcl @@ -24,8 +24,11 @@ start_server {tags {"slowlog"} overrides {slowlog-log-slower-than 1000000}} { } {10} test {SLOWLOG - GET optional argument to limit output len works} { - llength [r slowlog get 5] - } {5} + + assert_equal 5 [llength [r slowlog get 5]] + assert_equal 10 [llength [r slowlog get -1]] + assert_equal 10 [llength [r slowlog get 20]] + } test {SLOWLOG - RESET subcommand works} { r config set slowlog-log-slower-than 100000 @@ -39,7 +42,7 @@ start_server {tags {"slowlog"} overrides {slowlog-log-slower-than 1000000}} { set e [lindex [r slowlog get] 0] assert_equal [llength $e] 6 if {!$::external} { - assert_equal [lindex $e 0] 105 + assert_equal [lindex $e 0] 107 } assert_equal [expr {[lindex $e 2] > 100000}] 1 assert_equal [lindex $e 3] {debug sleep 0.2} -- cgit v1.2.1