diff options
| author | Jonathan Wakely <github@kayari.org> | 2016-05-25 12:31:19 +0100 |
|---|---|---|
| committer | Jonathan Wakely <github@kayari.org> | 2016-05-25 12:31:19 +0100 |
| commit | 0964912b94f9f48a0a812fbfbb2f996dbd93eff0 (patch) | |
| tree | 544497395d57807c9ca897248f3bd0f4290050d7 | |
| parent | 258e3065687c9e6b53b6f2b6c7fa6c5694508791 (diff) | |
| download | rpm-0964912b94f9f48a0a812fbfbb2f996dbd93eff0.tar.gz | |
Fix off-by-one error
There's an off-by-one error in base64_decode_value which results in undefined behaviour:
void* out;
size_t len;
rpmBase64Decode("\x7b", &out, &len);
| -rw-r--r-- | rpmio/base64.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rpmio/base64.c b/rpmio/base64.c index 60e67d442..4424aabbd 100644 --- a/rpmio/base64.c +++ b/rpmio/base64.c @@ -104,7 +104,7 @@ static int base64_decode_value(unsigned char value_in) { static const int decoding[] = {62,-1,-1,-1,63,52,53,54,55,56,57,58,59,60,61,-1,-1,-1,-2,-1,-1,-1,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,-1,-1,-1,-1,-1,-1,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51}; value_in -= 43; - if (value_in > sizeof(decoding)/sizeof(int)) + if (value_in >= sizeof(decoding)/sizeof(int)) return -1; return decoding[value_in]; } |