Explicitly specify O_RDONLY when opening files for setmeta

On Linux, this is a no-op as O_RDONLY is 0 but this may not be so on
other platforms. Another 4.18 regression.

(cherry picked from commit 3a7c8bc401a97f0ebf57bef3987a337129e4371f)

1 files changed, 4 insertions, 2 deletions

diff --git a/lib/fsm.c b/lib/fsm.c
index e144a03d8..d78c8eafd 100644
--- a/lib/fsm.c
+++ b/lib/fsm.c
@@ -1018,9 +1018,11 @@ setmeta:
 	    /* Special files require path-based ops */
 	    int mayopen = S_ISREG(fp->sb.st_mode) || S_ISDIR(fp->sb.st_mode);
 	    if (!rc && fd == -1 && mayopen) {
+		int flags = O_RDONLY;
 		/* Only follow safe symlinks, and never on temporary files */
-		fd = fsmOpenat(di.dirfd, fp->fpath,
-				fp->suffix ? AT_SYMLINK_NOFOLLOW : 0, 0);
+		if (fp->suffix)
+		    flags |= AT_SYMLINK_NOFOLLOW;
+		fd = fsmOpenat(di.dirfd, fp->fpath, flags, 0);
 		if (fd < 0)
 		    rc = RPMERR_OPEN_FAILED;
 	    }