From 1527b05c142bef89614df1d5176b94b29e2bae76 Mon Sep 17 00:00:00 2001 From: xujing Date: Thu, 24 Nov 2022 17:16:46 +0800 Subject: Fix file leak when src rpm in URL format is used for installation %{_tmppath}/rpm-tmp.* is created by rpmMkTempFile() when src rpm in URL format is used for installation, which is leaked. (cherry picked from commit 0b34438ccc3fdcbdaa6226d2398df88cc7439603) --- lib/rpminstall.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/rpminstall.c b/lib/rpminstall.c index f1bc1c5d9..3a1b87d35 100644 --- a/lib/rpminstall.c +++ b/lib/rpminstall.c @@ -675,8 +675,12 @@ exit: } } if (eiu->sourceURL != NULL) { - for (i = 0; i < eiu->numSRPMS; i++) + for (i = 0; i < eiu->numSRPMS; i++) { + if (eiu->sourceURL[i] == NULL) continue; + if (eiu->pkgState[i] == 1) + (void) unlink(eiu->sourceURL[i]); eiu->sourceURL[i] = _free(eiu->sourceURL[i]); + } } eiu->pkgState = _free(eiu->pkgState); eiu->pkgURL = _free(eiu->pkgURL); -- cgit v1.2.1