From 66fa46c006bae0f28d93238b8f7f1c923645eee5 Mon Sep 17 00:00:00 2001 From: Panu Matilainen Date: Tue, 3 May 2022 12:26:04 +0300 Subject: Axe our internal and buggy glob() and fnmatch() copies glibc 2.2 (or thereabouts) changed glob() and fnmatch() to not return dangling symlinks as matches, which gravely affects rpmbuild in particular. Because of this, rpm has carried a bundled copies of glibc 2.1 functions for close to 22 years now (commit bed2a465fe49ce05f9678e619d016a2d26649c98). glibc 2.27 in 2018 thankfully finally reverted that particular braindamage, I think we've carried the compatibility babbage long enough to excuse ourselves with a little shorter grace period in this case. Nukes away, add a blurb about the version requirement on glibc based systems. This still leaves our internal glob_pattern_p() intact as unlike glob() itself, that's not portable. No functional changes as such. --- system.h | 4 ---- 1 file changed, 4 deletions(-) (limited to 'system.h') diff --git a/system.h b/system.h index a5d236843..461712a0a 100644 --- a/system.h +++ b/system.h @@ -100,8 +100,4 @@ extern int fdatasync(int fildes); #define N_(Text) Text -/* ============== from misc/miscfn.h */ - -#include "misc/fnmatch.h" - #endif /* H_SYSTEM */ -- cgit v1.2.1