diff options
| author | Steven Danna <steve@opscode.com> | 2014-11-15 18:50:58 +0000 |
|---|---|---|
| committer | Steven Danna <steve@opscode.com> | 2014-11-15 18:56:53 +0000 |
| commit | dd5d7d6b371a4fa23373e9419021d71d10c36130 (patch) | |
| tree | 06f53711ec3a134e29a4cb9a03c76369ba723c52 /lib/chef_zero/solr/solr_parser.rb | |
| parent | cbad7c05f9db1ce74e4b4aff4be0ff2031f5ceaa (diff) | |
| download | chef-zero-ssd/400-on-parse-error.tar.gz | |
Return HTTP 400 Bad Request on Solr parse errorssd/400-on-parse-error
Previously, chef-zero would return an HTTP 500 Internal Server Error
when the Solr parser failed. Now, we return HTTP 400 with an error
message identical to that of the Erchef server. Returning HTTP 400
also improves the end-user experience since knife returns more
sensible error messages.
Before this patch:
> knife search nodes 'recipes:bar::bar'
ERROR: Server returned error 500 for http://127.0.0.1:8889/search...
After:
> knife search nodes 'recipes:bar::bar'
ERROR: knife search failed: invalid search query: 'recipes:bar::bar'
Diffstat (limited to 'lib/chef_zero/solr/solr_parser.rb')
| -rw-r--r-- | lib/chef_zero/solr/solr_parser.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/chef_zero/solr/solr_parser.rb b/lib/chef_zero/solr/solr_parser.rb index 936ead1..99da5fe 100644 --- a/lib/chef_zero/solr/solr_parser.rb +++ b/lib/chef_zero/solr/solr_parser.rb @@ -7,6 +7,8 @@ require 'chef_zero/solr/query/subquery' module ChefZero module Solr + class ParseError < RuntimeError; end + class SolrParser def initialize(query_string) @query_string = query_string @@ -114,7 +116,7 @@ module ChefZero end def parse_error(token, str) - raise "Error on token '#{token}' at #{@index} of '#{@query_string}': #{str}" + raise ChefZero::Solr::ParseError, "Error on token '#{token}' at #{@index} of '#{@query_string}': #{str}" end def read_single_expression |