Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

We have four different versions of this now, and this converts to
just using the one convention in `lib/chef/constants.rb`

Interestingly `Chef::NIL_ARGUMENT` is used nowhere in the codebase, that
probably got refactored out in 12.5.1.

Node objects still use `NIL` but that is a different kind of `Object.new`
which really is semantically private to the implementation of
attributes.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This gives a speed boost since rubygems does not have to scan through
every gem in the gemset in order to find the file.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>

* document why chef_core/text is included at the top level.

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>

Make bootstrap use train via chef_core/TargetHost

This commit implements usage of TargetHost instead of
knife_ssh.  TargetHost is a platform-independent representation
of a Train connection. It abstracts common operations
(such as file upload/download, permissions, temp directories,
command executation, etc) and connection error handling.

Moving to TargetHost and train gives us the ability to
execute commands on the bootstrap target; instead of
running sh -c 'long-command-string-containing-secrets', we'll
now upload the bootstrap script to a temporary directory on the
bootstrap target and execute it there.

Incorporating WinRM support directly (allowing core support
for Windows bootstraps, without the knife-windows plugin)
will follow.

THis also improves unit test coverage of the bootstrap module,
and clarifies functional versus behavior tests in that space

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Generated via git ls-files | xargs perl -pi -e "s/(Author.*?<[^@]+@)(?:opscode\\.com|getchef\\.com)(>)/\\1chef.io\\2/gi"

Created via git ls-files | xargs perl -pi -e "s/(Copyright.*?), Opscode(,)? Inc(\.)?/\\1, Chef Software Inc./gi"