This forces the formatter output off for users that use the
winevt or syslog options to the log_location.

This changes nothing about the logging behavior from Chef-15, those
never supported formatter output.

It creates some more clear consistency with how STDOUT behaves when
those options are used.

- We do not have the ability (fairly fundamentally in the Chef::Log
  class itself) to have different log levels running at the same time
  so either you get :warn or you get :info and we'll likely never
  be able to support mix-and-match.

- Without mix-and-match if you're trying to use the formatter on
  STDOUT the syslog logger you have to either pick :warn -- which
  makes the syslog output totally useless, or else pick :info --
  which intersperses all of the info logger output with the
  formatter on STDOUT and leads to complaints and bug reports.

- So we force the logger on, although users can still get the old
  STDOUT logging behavior back with --force-formatter -l info

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

- The doc formatter is now Chef::Config[:log_location]-aware
  and will log to files as well
- There is now consistency where doc formatter output never
  surprisingly changes to log formatter based on destination
- The "cli" log_location and the "config" log_location are now
  treated separately, so a log_location in the client.rb will
  always force output to a logfile, in addition to output
  to STDOUT if necessary
- The logic around STDOUT is now simplified, if its open we
  log to it, if its closed we don't, if you're daemonized we
  assume you're capturing STDOUT via your process manager
- The log_location variables are now Arrays

Things not done:

- The cli can't specify an array, it would be nice to support
  an accumulator pattern here.  Would also need to support
  disabling STDOUT logging though.

- Using the syslog or winevt logging devices requires the use
  of the logger, which precludes using the formatter.

- Some people may want to have log-formatter style output
  to the log file and doc formatter style output to STDOUT
  which is not very possible right now.  Right now we are
  consistent in that you get either the logger both places
  or the formatter both places.  This use case is complicated
  by the fact that they will want :info level logging for
  the logger, but :warn level logging for the doc formatter
  and that is another global.

- To do that latter thing right would probably require sending
  log messages to the formatter, and supporting a different
  log level in the formatter vs. the logger and then supporting
  the STDOUT/cli loggging being the formatter, while the
  log_location/config logging being the logger.

Those were way out of scope for what I could get done for Chef-16.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Lots more in lib, but that's out of scope for this. I'm just trying to
make it easier to debug a failing spec when needed.

Signed-off-by: Ryan Davis <zenspider@chef.io>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Marc Chamberland <chamberland.marc@gmail.com>

Signed-off-by: Marc Chamberland <chamberland.marc@gmail.com>

This is the implementation of [RFC-087](https://github.com/chef-boneyard/chef-rfc/blob/master/rfc087-distro-sugar-helpers.md)
although some of the specifics have been iterated on and changed.

The documentation will be in the [README.md](https://github.com/chef/chef/tree/master/chef-utils/README.md) once this is merged.

While this PR mostly moves chef-sugar utilities into core-chef via this chef-utils gem, the scope of the chef-utils gem
should be considered larger than just that. As an example this PR moves the Mash class into this gem for reuse in ohai
as well.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

i like this one, gives visual priority to returns or raises that are
buried in the middle of things.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>