delta/ruby-gems/chef.git/lib/chef/chef_fs/data_handler, branch https github.com: opscode/chef.git Avoid assigning variables before returning if we don't have to 2020-07-07T22:19:21+00:00 Tim Smith tsmith84@gmail.com 2020-07-07T22:19:21+00:00 1485a862053fb20ade1f93bb82c6918cd4078975 These seemed pretty straight forward. There's a new Rubocop cop for these. Signed-off-by: Tim Smith <tsmith@chef.io> 
These seemed pretty straight forward. There's a new Rubocop cop for these.

Signed-off-by: Tim Smith <tsmith@chef.io>
Use .match? not =~ when match values aren't necessary 2020-06-11T22:32:53+00:00 Tim Smith tsmith84@gmail.com 2020-06-11T22:02:42+00:00 5825eea4b139b9af089c3075d042d5d3160583ec Autocorrected from RuboCop Performance which is now smart enough to detect when you use the match and when you don't. Using match? does not create any objects so it's slightly faster and uses less memory. Signed-off-by: Tim Smith <tsmith@chef.io> 
Autocorrected from RuboCop Performance which is now smart enough to detect when you use the match and when you don't. Using match? does not create any objects so it's slightly faster and uses less memory.

Signed-off-by: Tim Smith <tsmith@chef.io>
Style/StringLiteralsInInterpolation 2019-07-05T19:58:00+00:00 Lamont Granquist lamont@scriptkiddie.org 2019-07-05T19:58:00+00:00 2a4916b7f01940d1199c35645c1b2172f5bd74b2 since we use double quotes, be consistent everywhere. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
since we use double quotes, be consistent everywhere.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Convert require to require_relative 2019-05-09T00:03:26+00:00 Lamont Granquist lamont@scriptkiddie.org 2019-05-09T00:03:26+00:00 bc7687e56763cedbd010cfd566aa2fc0c53bb194 This gives a speed boost since rubygems does not have to scan through every gem in the gemset in order to find the file. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
This gives a speed boost since rubygems does not have to scan through
every gem in the gemset in order to find the file.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
changes for rubocop engine upgrades. 2019-01-15T21:07:58+00:00 Lamont Granquist lamont@scriptkiddie.org 2019-01-15T21:07:58+00:00 990974ca5cd44df0c77bb6a12fc57a3c32b92e23 this is the result of changes to rules we already previously had enabled. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
this is the result of changes to rules we already previously had
enabled.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
replace some instances of to_hash with to_h 2018-09-27T05:22:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2018-09-27T05:22:29+00:00 8400f4cb7d977896531ae277fdcf3398dc2d4c6c to_hash on a lot of these objects should go away, but even eliminating all our calls to to_hash on these objects internally is difficult. (e.g. converting the knife ui code to call #to_h means we wind up calling nil#to_h which "helpfully" becomes '{}' which is hilarious and i don't know why someone thought that was a good idea). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
to_hash on a lot of these objects should go away, but even eliminating
all our calls to to_hash on these objects internally is difficult.

(e.g. converting the knife ui code to call #to_h means we wind up
calling nil#to_h which "helpfully" becomes '{}' which is hilarious and
i don't know why someone thought that was a good idea).

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
added one more rspec test 2018-05-16T11:50:39+00:00 Jeremy J. Miller jm@chef.io 2018-05-16T11:50:39+00:00 ca3be72bd1f2b393dd2e70ed4620549d449b1559 Signed-off-by: Jeremy J. Miller <jm@chef.io> 
Signed-off-by: Jeremy J. Miller <jm@chef.io>
object validation for DataHandlerBase#normalize_hash 2018-05-15T22:31:57+00:00 Jeremy J. Miller jm@chef.io 2018-05-15T19:15:17+00:00 7acbb49f913e7064e8736b0e56eff8ecf5acf10a Signed-off-by: Jeremy J. Miller <jm@chef.io> 
Signed-off-by: Jeremy J. Miller <jm@chef.io>
Fix some yard warnings 2018-03-11T20:20:45+00:00 Tim Smith tsmith@chef.io 2018-03-11T20:20:45+00:00 264d03d07c184ad5322469d0174b06f5d475f087 More Rubymine warnings Signed-off-by: Tim Smith <tsmith@chef.io> 
More Rubymine warnings

Signed-off-by: Tim Smith <tsmith@chef.io>
Merge pull request #6463 from MarkGibbons/invites_sort_fail 2018-02-12T18:47:34+00:00 Lamont Granquist lamont@scriptkiddie.org 2018-02-12T18:47:34+00:00 240dc85d5acfa6bd21e5dc9fbfe29d8d5e7161bc invites_sort_fail: Clean the invites array before sorting it 
invites_sort_fail: Clean the invites array before sorting it