delta/ruby-gems/chef.git/lib/chef/node/attribute.rb, branch https_shell github.com: opscode/chef.git add attribute_changed hook to event handlers 2016-10-28T21:46:11+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-10-28T21:46:11+00:00 e57e29b96b75ff7fc04abb7f9db73920b2a5894a Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
rename __path to __path__ and __node to __node__ 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-10-07T23:47:43+00:00 9edd0113f2d046e051845cf1916fcf733d392791 consistency with Unchain here: https://github.com/chef/chef/blob/master/lib/chef/decorator/unchain.rb#L23-L24 and with SimpleDelegator: https://ruby-doc.org/stdlib-2.1.0/libdoc/delegate/rdoc/SimpleDelegator.html#method-i-__getobj__ Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
consistency with Unchain here:

https://github.com/chef/chef/blob/master/lib/chef/decorator/unchain.rb#L23-L24

and with SimpleDelegator:

https://ruby-doc.org/stdlib-2.1.0/libdoc/delegate/rdoc/SimpleDelegator.html#method-i-__getobj__

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
standardize initializer args for VividMash+ImmutableMash 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-09-29T21:35:14+00:00 10904d6cf42a2a0ed69757aca3e80f512bb89379 if anyone is using these directly this might be a breaking change, although it makes it considerably easier to use VividMash and IMO ImmutableMash is an implementation detail of the deep merge cache and Chef::Node object. we definitely have never documented these APIs, so I think the onus is on the consumer to update their code. VividMash.new() should now work. VividMash.new({ foo: :bar }) should also now work. IDK what object people would have been passing in as the root object before. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
if anyone is using these directly this might be a breaking change,
although it makes it considerably easier to use VividMash and IMO
ImmutableMash is an implementation detail of the deep merge cache
and Chef::Node object.

we definitely have never documented these APIs, so I think the onus
is on the consumer to update their code.

VividMash.new() should now work.

VividMash.new({ foo: :bar }) should also now work.

IDK what object people would have been passing in as the root object
before.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
green tests 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-09-28T23:01:41+00:00 c38fd335b667ccc8dcb1a0ae276be44f344c9fea Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
savegame for more aggressive refactoring 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-09-28T17:10:27+00:00 19d46ebf8700df0d5668e9262f02aa2717101184 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
add a deep_merge_cache mixin 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-09-27T02:07:26+00:00 6859b99ca4b79077c99ddeadc91333ce86b40454 gets the inheritence chain correct Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
gets the inheritence chain correct

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
s/path_tracking/state_tracking and add __root state 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-09-26T17:04:35+00:00 16a08bcf2a78aa1353ec88f0a8e0282973434914 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
add code to implement node path tracking 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-09-23T23:47:45+00:00 69e92b100f4eccea6bf6f0953ffbc2e7f8b93b19 via node.__path variable using __underscore format because node["path"] could very well be used and we still have to deal with node.path method_missing horribleness. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
via node.__path variable

using __underscore format because node["path"] could very
well be used and we still have to deal with node.path method_missing
horribleness.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Convert attributes defined as literal arrays 2016-09-21T14:58:07+00:00 Giacomo Bagnoli gbagnoli@gmail.com 2016-09-20T14:15:08+00:00 39774946fbbd8b1f7d3267df3fcb7369ad5cac6d VividMash, unlike Mash, does not recursively convert values inside arrays, just the array itself. As such, hashes inside arrays are not converted to *Mash, introducing a behaviour that differs from Chef 11, e.g. having this attr defined node['foo'] = [ { 'attr' => 'value' } ] in Chef 11 `node[:foo][0][:attr]` returns `'value'` while in Chef 12 it returns `nil` This commit fixes VividMash so arrays are recursively converted and the behaviour restored. Plus, immutablize merge_all result, so to be sure that hashes contained in Arrays are properly immutablized as well, so not existing attributes are not automatically vivified (thus returning an empty VividMash instead of nil) This problem was first reported in chef/chef#2871. Signed-off-by: Giacomo Bagnoli <gbagnoli@gmail.com> 
VividMash, unlike Mash, does not recursively convert values inside
arrays, just the array itself.
As such, hashes inside arrays are not converted to *Mash, introducing
a behaviour that differs from Chef 11, e.g.

having this attr defined

node['foo'] = [ { 'attr' => 'value' } ]

in Chef 11 `node[:foo][0][:attr]` returns `'value'` while in Chef 12 it
returns `nil`

This commit fixes VividMash so arrays are recursively converted and the
behaviour restored.

Plus, immutablize merge_all result, so to be sure that hashes contained
in Arrays are properly immutablized as well, so not existing attributes
are not automatically vivified (thus returning an empty VividMash
instead of nil)

This problem was first reported in chef/chef#2871.

Signed-off-by: Giacomo Bagnoli <gbagnoli@gmail.com>
fix Style/BlockDelimiters, Style/MultilineBlockLayout and 0.42.0 engine upgrade 2016-08-17T20:25:02+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-08-17T19:15:26+00:00 a0c32511bc6634538374ca4b433032b8acd05f96 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>