Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

 - Fix to_json Wrong number of argument while calling on object of Node::Attribute.
 - Allowed to_yaml method in Node::Attribute.

Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>

start enforcing using %i{} instead of arrays of symbols

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This gives a speed boost since rubygems does not have to scan through
every gem in the gemset in order to find the file.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Doing something like:

```
node.default["foo"] = []
node.default["foo"] << { "bar" => "baz }
```

Would result in a Hash instead of a VividMash inserted into the
AttrArray, so that:

```
node.default["foo"][0]["bar"] # gives the correct result
node.default["foo"][0][:bar]  # does not work due to the sub-Hash not
                              # converting keys
```

This fixes that behavior, but is likely a breaking change to someone
who expects to ingest hashes with symbol keys and get back out symbol
keys, they will now get converted to strings.  This breaking change
is fully 100% intentional.  This makes the node attribute structure
more consistent and predictable.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This reverts commit 0c29acc106ca774e230c8ef45694c8bffd166b69.

This reverts commit e56f8d58b80334256085907961aac9ca9f56f125.

node.default['foo'] = node['bar'] need to have node['bar'] have its
cache vivified otherwise we potentially get an empty hash or array.

in the case of hashes, the assignment must have been walking though
the values with #each or something which poked the cache on the target
hash which caused it to vivify, so this bug only affected Arrays
where the AttrArray initializer likely did a quick-n-dirty copy of
the internal structure of the ImmutableArray which was empty.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>