delta/ruby-gems/chef.git/lib/chef/policy_builder, branch https

Get lib/ free of spelling violations.

2020-05-19T03:29:40+00:00

Signed-off-by: Pete Higgins

Remove copyright dates

2020-04-13T22:47:17+00:00

Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist

Fix node[:cookbooks] attribute

2019-08-26T21:09:12+00:00

closes #8817

Note that if any calling code winds up seeing this error message:

```
NoMethodError: undefined method `set_cookbook_attribute' for nil:NilClass
```

That means that the cookbook_collection was set before the node was
set on the run_context.  That wouldn't be a bug in core chef, that must
be fixed in the caller to reverse the order of operations.

Since I only made the positional arguments to the run_context constructor
optional in Chef-15.0 though I don't expect this breaks any existing code
written in the past month or two, but if anything crops up in the future,
consider this a definitive statement that the caller must reverse the
order of their operations and this error being thrown is a feature not
a bug to be fixed.

(The fact that we silently aborted rather than threw a NoMethodError on
NilClass meant that we shipped this defect -- sometimes defensive
programming can be overly defensive and swallow real errors).

Signed-off-by: Lamont Granquist

Style/SymbolProc

2019-07-05T20:26:53+00:00

enforce pretzels.

Signed-off-by: Lamont Granquist

Style/StringLiteralsInInterpolation

2019-07-05T19:58:00+00:00

since we use double quotes, be consistent everywhere.

Signed-off-by: Lamont Granquist

Style/ClassCheck

2019-07-05T19:57:40+00:00

convert kind_of? to is_a?

Signed-off-by: Lamont Granquist

fix Layout/AlignArguments

2019-07-02T18:13:54+00:00

this is using:

Layout/AlignArguments:
  Enabled: true
  EnforcedStyle: with_fixed_indentation

the default style can use really excessive whitespace.  on starting
lines which are already long, it fully indents across to where the
arguments start and then begins the line there.

Signed-off-by: Lamont Granquist

more distro constants for "Chef"

2019-05-23T16:31:28+00:00

Signed-off-by: Marc Chamberland

More distro constant applications

2019-05-23T16:30:56+00:00

Signed-off-by: Marc Chamberland

This hits the ones that are most frequently required.

2019-05-21T01:05:36+00:00

Stops the kernel from scanning through all the activated gems every time in order
to resolve names into pathnames.

See rubygems/rubygems#2762

Signed-off-by: Lamont Granquist