Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

For custom resources which correctly implement load_current_value the
new after_resource comes for "free" and load_current_value will be
called twice to load the current_resource (should be renamed the
"before_resource" but that ship sailed) and then the after_resource.

Appropriate wiring is added for a new event and capturing that into
the action_collection and then the data_collector.  The resource_reporter
has not and will not be updated.

For old style resources which are difficult to convert to custom
resources (thinking here particularly of the 1:N model of the service
resource in core chef, or stuff that just may be a lot of work like the
file resource) then they can override the load_after_resource to
manually wire up their own after_resource.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

It is necessary due to the way the crazy lazy DSL module injection works

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This lets us avoid using declare_resource in old style core resources.

As everything gets converted over to custom resources this is going away
anyway.

We haven't seen any issues from using the recipe DSL in custom resources
in core.

Clearly this is potentially breaking since any references to
Chef::DSL::Core need to be changed to Chef::DSL::Recipe (although I'm
not sure who would have done that other than maybe us somewhere, I had
a note in there that nobody should probably touch the Core DSL).

This greatly simplifies the major DSLs down to two:

Recipe DSL - things that only make sense in a context where there is a resource_collection
Universal DSL - things that apply everywhere

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

* Chef-16 resource cleanup + unified_mode

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This gives a speed boost since rubygems does not have to scan through
every gem in the gemset in order to find the file.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Bump when we're going to kill this off so we can search for Chef-15 in the codebase.

Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Noah Kantrowitz <noah@coderanger.net>