delta/ruby-gems/chef.git/spec/integration/solo, branch https_shell

fix chef-solo spec timeouts (#5367)

2016-09-22T00:41:27+00:00

* fix chef-solo spec timeouts

caused by a race condition (not actually fixed) where the pid
can be read by the process which lost the race to lock it before the
pid has been written by the process which got the lock.

the result is a message like:

"WARN: Chef client  is running, will wait for it to finish and then run."

without any numerical pid.

i'm not super concerned with fixing the race, this will unbreak a lot
of red travis failures though.

Signed-off-by: Lamont Granquist 

* revert some debugging

Signed-off-by: Lamont Granquist

use threads to workaround Process.spawn buginess

2016-09-02T20:42:02+00:00

there's a WONTFIX closed bug in ruby-lang.org on this bug:

https://bugs.ruby-lang.org/issues/10583

they seem to be favoring speed over accuracy with the result
that if you're doing I/O synchronization (like our run_lock?)
inside of a Process.spawn chain like this that you have to
wrap the spawn calls inside of threads.

probably a best practice to wrap every spawn call with a
Thread.

this probably also explains why we had the silly-long 20
second timeout?

Signed-off-by: Lamont Granquist

tweak chef-solo run_lock timing test

2016-09-02T16:46:03+00:00

- fix the 'last' statements (my perl brain occassionally crops up
  in ruby code) and replace with a raise.  of course this just swaps
  one exception for another, but this time its really intended to
  work this way.

- swap the order of the expecations so that if we fails to see the
  waiting on the other process statement, but we blow up in both
  threads in the exception that was just added, we know we actually
  have a legit run_lock race condition that this code just found.

does not fix this bug, just gets us a bit more information if it
reoccurs.

Signed-off-by: Lamont Granquist

use the chef log file for IPC

2016-08-18T19:21:11+00:00

when running on my mac this entirely removes all the sleeps

Signed-off-by: Lamont Granquist

speed up solo test

2016-08-18T18:56:38+00:00

removes the requirement that the second wait for the first, just that
one of them waits for the other, so if we ever somehow lose that race
and the second wins the run_lock as long as the first sleeps then its
all good...

drops all the sleeps down a lot, thinking about how to make this more
cleverer so that it doesn't sleep but handshakes properly so that we
don't need 25 seconds of sleep on slowaris tests..

Signed-off-by: Lamont Granquist

Ensure that solo specific code is run at the proper time

2016-05-16T12:38:12+00:00

ie, only when we're in OG mode and not in local mode.

Signed-off-by: Thom May

Too much log output and unnecessary warnings! Suppress that shit.

2016-04-25T16:04:09+00:00

autofixing whitespace cops

2016-02-05T23:00:00+00:00

4174 Style/SpaceInsideHashLiteralBraces
1860 Style/SpaceAroundOperators
1336 Style/SpaceInsideBlockBraces
1292 Style/AlignHash
 997 Style/SpaceAfterComma
 860 Style/SpaceAroundEqualsInParameterDefault
 310 Style/EmptyLines
 294 Style/IndentationConsistency
 267 Style/TrailingWhitespace
 238 Style/ExtraSpacing
 212 Style/SpaceBeforeBlockBraces
 166 Style/MultilineOperationIndentation
 144 Style/TrailingBlankLines
 120 Style/EmptyLineBetweenDefs
 101 Style/IndentationWidth
  82 Style/SpaceAroundBlockParameters
  40 Style/EmptyLinesAroundMethodBody
  29 Style/EmptyLinesAroundAccessModifier
   1 Style/RescueEnsureAlignment

Use double quotes by default

2016-01-14T14:08:03+00:00

This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.

improve error message, add more tests

2015-10-26T23:21:06+00:00