delta/ruby-gems/chef.git/spec/unit/node, branch https_shell github.com: opscode/chef.git add some unit testing of new node APIs 2016-10-31T22:26:04+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-10-31T22:26:04+00:00 edede76c46eb388b74292a20b4701a1b9b88c535 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
rename __path to __path__ and __node to __node__ 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-10-07T23:47:43+00:00 9edd0113f2d046e051845cf1916fcf733d392791 consistency with Unchain here: https://github.com/chef/chef/blob/master/lib/chef/decorator/unchain.rb#L23-L24 and with SimpleDelegator: https://ruby-doc.org/stdlib-2.1.0/libdoc/delegate/rdoc/SimpleDelegator.html#method-i-__getobj__ Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
consistency with Unchain here:

https://github.com/chef/chef/blob/master/lib/chef/decorator/unchain.rb#L23-L24

and with SimpleDelegator:

https://ruby-doc.org/stdlib-2.1.0/libdoc/delegate/rdoc/SimpleDelegator.html#method-i-__getobj__

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
remove breadcrumb state 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-10-07T22:04:47+00:00 6536f15dcb53938fe9c77e7438b20fe6ac3cdffb Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
standardize initializer args for VividMash+ImmutableMash 2016-10-25T16:29:29+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-09-29T21:35:14+00:00 10904d6cf42a2a0ed69757aca3e80f512bb89379 if anyone is using these directly this might be a breaking change, although it makes it considerably easier to use VividMash and IMO ImmutableMash is an implementation detail of the deep merge cache and Chef::Node object. we definitely have never documented these APIs, so I think the onus is on the consumer to update their code. VividMash.new() should now work. VividMash.new({ foo: :bar }) should also now work. IDK what object people would have been passing in as the root object before. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
if anyone is using these directly this might be a breaking change,
although it makes it considerably easier to use VividMash and IMO
ImmutableMash is an implementation detail of the deep merge cache
and Chef::Node object.

we definitely have never documented these APIs, so I think the onus
is on the consumer to update their code.

VividMash.new() should now work.

VividMash.new({ foo: :bar }) should also now work.

IDK what object people would have been passing in as the root object
before.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
modify attributes and nodes tests for deeply converting_values 2016-09-23T18:43:37+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-09-23T18:43:37+00:00 dabb318ccb01ea15b9d577bf4f6eb0a05789aee0 slightly more succinct and strict about types, also trying to keep the attributes tests associated with attributes even though we mix them all up like crazy anyway... Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
slightly more succinct and strict about types, also trying to keep
the attributes tests associated with attributes even though we mix
them all up like crazy anyway...

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
fix for #5094 12.12.13 node.default_unless issue 2016-07-08T17:40:38+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-07-08T17:40:38+00:00 48304f2dc87cc4dc184d73133453e2dbf64c0e2b note that the node_spec test in this commit is not red on master so it ain't testing the right thing yet, but this fixes the issue in chef-shell... 
note that the node_spec test in this commit is not red on master
so it ain't testing the right thing yet, but this fixes the
issue in chef-shell...
Attributes v1.1 changes 2016-06-27T22:42:06+00:00 Lamont Granquist lamont@scriptkiddie.org 2016-06-27T22:38:28+00:00 86fa507226b484a71a45ef6129840bc3928be6b7 - fixes *_unless behavior and set_unless_value_present hack from Chef 12 - simplifies rm_* code - introduces functional read/write/unlink/exist? API - deprecates method_missing access to attributes for Chef 13 - deprecates set/set_unless aliases for Chef 14 - removes MultiMash mess that I wrote for Chef 13 https://github.com/chef/chef/pull/5029 for more details 
- fixes *_unless behavior and set_unless_value_present hack from Chef 12
- simplifies rm_* code
- introduces functional read/write/unlink/exist? API
- deprecates method_missing access to attributes for Chef 13
- deprecates set/set_unless aliases for Chef 14
- removes MultiMash mess that I wrote for Chef 13

https://github.com/chef/chef/pull/5029 for more details
Too much log output and unnecessary warnings! Suppress that shit. 2016-04-25T16:04:09+00:00 Kartik Null Cating-Subramanian ksubramanian@chef.io 2016-04-21T17:26:30+00:00 2034305917a76d4c203e457a9ebf61d28819ccbd 






flip multiline function arguments around
2016-02-19T17:28:33+00:00

Lamont Granquist
lamont@scriptkiddie.org

2016-02-19T17:28:33+00:00

92bec4bb96d857f027068fc56af46c76c484fd50

no enforced trailing comma on arguments...





no enforced trailing comma on arguments...







deal with 0.37.2 renamed cops
2016-02-19T02:39:11+00:00

Lamont Granquist
lamont@scriptkiddie.org

2016-02-19T02:39:11+00:00

6077b99f6ad1bc9a082f575f3818e69f05d8c8dc

252  Style/TrailingCommaInLiteral
84   Style/TrailingCommaInArguments
15   Style/SpaceAroundKeyword
--
351  Total

We already dealt with SpaceAroundKeyword under its old name
SpaceBeforeModifierKeyword, it looks like it got stricter about
spaces after keywords.

TrailingComma also got split, and it looks like the
TrailingCommaInArguments behavior is new?





252  Style/TrailingCommaInLiteral
84   Style/TrailingCommaInArguments
15   Style/SpaceAroundKeyword
--
351  Total

We already dealt with SpaceAroundKeyword under its old name
SpaceBeforeModifierKeyword, it looks like it got stricter about
spaces after keywords.

TrailingComma also got split, and it looks like the
TrailingCommaInArguments behavior is new?