delta/ruby-gems/chef.git/spec/unit/server_api_spec.rb, branch https github.com: opscode/chef.git Fix protocol negotiation for unversioned objects 2020-07-28T21:07:57+00:00 Lamont Granquist lamont@scriptkiddie.org 2020-07-28T21:04:49+00:00 d9b9ea1a737772cf0d3c3a3064057b60c47a9549 We generally always do protocol negotiation on the get of the node object and the Chef::Node is an unversioned API, so we need to test that we backoff the API version to the highest version the server offers and then retry again. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org> 
We generally always do protocol negotiation on the get of the node
object and the Chef::Node is an unversioned API, so we need to
test that we backoff the API version to the highest version the server
offers and then retry again.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Merge pull request #10216 from chef/fix-406-no-method-error 2020-07-28T00:02:23+00:00 Tim Smith tsmith@chef.io 2020-07-28T00:02:23+00:00 1f392d82aacbd604a3eb2cd151d52583ea1d8a27 Fix NoMethodError when server returns a 406. 
Fix NoMethodError when server returns a 406.
 Fix NoMethodError when server returns a 406. 2020-07-27T23:52:54+00:00 Pete Higgins pete@peterhiggins.org 2020-07-27T23:46:46+00:00 09cdc96cb25956b3ef053fbe093d06453a7af92b Signed-off-by: Pete Higgins <pete@peterhiggins.org> 
Signed-off-by: Pete Higgins <pete@peterhiggins.org>
Define local test variables to avoid test load order bug. 2020-07-27T20:06:04+00:00 Pete Higgins pete@peterhiggins.org 2020-07-27T20:06:04+00:00 3149ff136e832bfa27cd73200365d986870a9d59 Signed-off-by: Pete Higgins <pete@peterhiggins.org> 
Signed-off-by: Pete Higgins <pete@peterhiggins.org>
Revert "Knife should give a useful error when the chef_server_url isn't a chef server API" 2018-03-14T15:20:47+00:00 Thom May thom@may.lt 2018-03-14T15:20:47+00:00 e20de6e6a79d0e16d4acc4f6eb7b6edebfaf4779 






fix chefstyle
2017-09-26T22:33:05+00:00

Jose Asuncion
jose.asuncion@gmail.com

2017-09-26T22:31:52+00:00

ed65b42bb5bf587495918cbf509a4aea871720ec

Signed-off-by: Jose Asuncion <jeunito@gmail.com>





Signed-off-by: Jose Asuncion <jeunito@gmail.com>







Merge branch 'master' into feat/5556
2017-09-26T00:02:56+00:00

Jose Asuncion
jose.asuncion@gmail.com

2017-09-26T00:00:51+00:00

d3cf74513829347db86f451cdd3ecc06bab01072

Signed-off-by: Jose Asuncion <jeunito@gmail.com>





Signed-off-by: Jose Asuncion <jeunito@gmail.com>







move chef server heuristic to server_api
2017-09-25T23:57:32+00:00

Jose Asuncion
jose.asuncion@gmail.com

2017-09-25T23:57:28+00:00

bdf090c43e46a1aeec80c6b495c6858f9c2d6300

Signed-off-by: Jose Asuncion <jeunito@gmail.com>





Signed-off-by: Jose Asuncion <jeunito@gmail.com>







Revert "raise error if chef_server_url is not valid"
2017-08-17T01:25:05+00:00

Jose Asuncion
jose.asuncion@gmail.com

2017-08-17T01:25:05+00:00

61916b652b80f3e6982bac0c925b86b32b7571f6

This reverts commit 02a46911341c1d5ef10309d27963031d598dbe2c.





This reverts commit 02a46911341c1d5ef10309d27963031d598dbe2c.







fix retries on JSON POST requests when negotiating protocol version
2017-07-20T17:25:19+00:00

Lamont Granquist
lamont@scriptkiddie.org

2017-07-20T17:25:19+00:00

df6dd3768d5fcc99a348bd52d7e6ffeaa1c391db

on the first pass through the JSON middleware it encodes the
body.  if there's a retry, it re-encodes the body as a string
with all its metacharacters escaped.

this is a particular issue when doing a first request that is
a POST that requires negotiating the API version.  when doing a
GET it isn't a problem because there's no body payload -- but a
POST or a PUT which requires a retry will get garbled and will
cause a 500.

this happens on hosted right now if trying to POST with a v2
API since hosted is only v1, so there's a retry to downgrade.

i also made the same kind of changes to the streaming download
requests, but since they're GETs its unclear to me if there was
any impact there -- but middleware could have been double-mangling
headers on a retry.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>





on the first pass through the JSON middleware it encodes the
body.  if there's a retry, it re-encodes the body as a string
with all its metacharacters escaped.

this is a particular issue when doing a first request that is
a POST that requires negotiating the API version.  when doing a
GET it isn't a problem because there's no body payload -- but a
POST or a PUT which requires a retry will get garbled and will
cause a 500.

this happens on hosted right now if trying to POST with a v2
API since hosted is only v1, so there's a retry to downgrade.

i also made the same kind of changes to the streaming download
requests, but since they're GETs its unclear to me if there was
any impact there -- but middleware could have been double-mangling
headers on a retry.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>