Add additional Test Kitchen tests

Signed-off-by: Tim Smith <tsmith@chef.io>

2 files changed, 84 insertions, 1 deletions

diff --git a/kitchen-tests/cookbooks/end_to_end/recipes/_macos_userdefaults.rb b/kitchen-tests/cookbooks/end_to_end/recipes/_macos_userdefaults.rb
index 107a9fb867..9d61ee5df6 100644
--- a/kitchen-tests/cookbooks/end_to_end/recipes/_macos_userdefaults.rb
+++ b/kitchen-tests/cookbooks/end_to_end/recipes/_macos_userdefaults.rb
@@ -5,12 +5,14 @@
 # Copyright:: Copyright (c) Chef Software Inc.
 #
 
+# test that we can autodetect the type
 mac_os_x_userdefaults "Disable fast user switching" do
   domain "/Library/Preferences/.GlobalPreferences"
   key "MultipleSessionEnabled"
   value 0
 end
 
+# test full path to the domain
 macos_userdefaults "Enable macOS firewall" do
   domain "/Library/Preferences/com.apple.alf"
   key "globalstate"
@@ -18,15 +20,42 @@ macos_userdefaults "Enable macOS firewall" do
   type "int"
 end
 
+# test short domain name
 macos_userdefaults "Set the dock size" do
   domain "com.apple.dock"
-  type "integer"
+  type "int"
   key "tilesize"
   value "20"
 end
 
+# test that we can properly handle spaces
 macos_userdefaults "Value with space" do
   domain "/Library/Preferences/ManagedInstalls"
+  type "string"
   key "LogFile"
   value "/Library/Managed Installs/Logs/ManagedSoftwareUpdate2.log"
 end
+
+# test that we can set an array
+macos_userdefaults "Bogus key with array value" do
+  domain "/Library/Preferences/ManagedInstalls"
+  type "array"
+  key "LogFileArray"
+  value [ '/Library/Managed Installs/fake.log', '/Library/Managed Installs/also_fake.log']
+end
+
+# test that we can set a dict
+macos_userdefaults "Bogus key with dict value" do
+  domain "/Library/Preferences/ManagedInstalls"
+  type "dict"
+  key "LogFileDict"
+  value "User": '/Library/Managed Installs/way_fake.log'
+end
+
+# test that we can set a bool
+macos_userdefaults 'Bogus key with boolean value' do
+  domain "/Library/Preferences/ManagedInstalls"
+  key 'LoggingIsTheThingToDoRight'
+  value "yes"
+  type "bool"
+end
diff --git a/test.rb b/test.rb
new file mode 100644
index 0000000000..19b7fd7d2d
--- /dev/null
+++ b/test.rb
@@ -0,0 +1,54 @@
+# macos_userdefaults 'Delete non-existent domain' do
+#   domain '/Library/Preferences/TimTest'
+#   key 'File'
+#   action :delete
+# end
+
+# macos_userdefaults 'Add key to new domain' do
+#   domain '/Library/Preferences/TimTest'
+#   key 'File'
+#   value '/usr/local/tim'
+# end
+
+# macos_userdefaults 'Add key to new domain' do
+#   domain '/Library/Preferences/TimTest'
+#   key 'File'
+#   value '/usr/local/tim'
+# end
+
+macos_userdefaults 'Add String key' do
+  domain '~/Library/Preferences/unity.BrickLink.Studio.plist'
+  key 'StringKey2'
+  value '/usr/local/tim2'
+end
+
+macos_userdefaults 'Add boolean key' do
+  domain '~/Library/Preferences/unity.BrickLink.Studio.plist'
+  key 'BooleanKey'
+  value true
+end
+
+macos_userdefaults 'Add array key' do
+  domain '~/Library/Preferences/unity.BrickLink.Studio.plist'
+  key 'ArrayKey'
+  value %w(one two three)
+end
+
+
+# macos_userdefaults 'enable macOS firewall' do
+#   domain '/Library/Preferences/com.apple.alf'
+#   key 'globalstate'
+#   value '1'
+#   type 'int'
+# end
+
+# macos_userdefaults 'Bad string test' do
+#   domain '/Library/Preferences/ManagedInstalls'
+#   key 'Log File'
+#   value '/Library/Managed Installs/Logs/ManagedSoftwareUpdate.log'
+# end
+
+
+
+# Bugs:
+# Create/Delete on domain that doesn't exist fails