diff options
| author | Tim Smith <tsmith@chef.io> | 2020-05-18 20:33:41 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-18 20:33:41 -0700 |
| commit | f80e49f2131f3a1599f2eec78aac57e2a0bcaedd (patch) | |
| tree | 8ef45cff134f69025cc45147532e8913c56ac0c5 | |
| parent | a3908d26aa86e0d04bac2a87438e484311f1d763 (diff) | |
| parent | 552ad42b3cbc685dfef6323a964d466eda3986d0 (diff) | |
| download | chef-f80e49f2131f3a1599f2eec78aac57e2a0bcaedd.tar.gz | |
Merge pull request #9826 from chef/add-spellcheck
Add spellcheck config and fix a bunch of violations
113 files changed, 2424 insertions, 194 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 51a2d34c36..2ccfb550ba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -125,7 +125,7 @@ Date: Wed Sep 18 11:44:40 2015 -0700 Our primary shipping vehicle is operating system specific packages that includes all the requirements of Chef. The packages are built with our [Omnibus](https://github.com/chef/omnibus) packing project. -We also release our software as gems to [Rubygems](https://rubygems.org/) but we strongly recommend using Chef packages since they are the only combination of native libraries & gems required by Chef that we test throughly. +We also release our software as gems to [Rubygems](https://rubygems.org/) but we strongly recommend using Chef packages since they are the only combination of native libraries & gems required by Chef that we test thoroughly. Our version numbering roughly follows [Semantic Versioning](http://semver.org/) standard. Our standard version numbers look like X.Y.Z which mean: @@ -133,7 +133,7 @@ Our version numbering roughly follows [Semantic Versioning](http://semver.org/) - Y is a minor release, which adds both new features and bug fixes - Z is a patch release, which adds just bug fixes -After shipping a release of Chef we bump the `Minor` version by one to start development of the next minor release. All merges to master trigger an increment of the `Patch` version, and a build through our internal testing pipeline. We do a `Minor` release approximately every month, which consist of shipping one of the already auto-incremented and tested `Patch` versions. For example after shiping 12.10.24, we incremented Chef to 12.11.0\. From there 18 commits where merged bringing the version to 12.11.18, which we shipped as an omnibus package. +After shipping a release of Chef we bump the `Minor` version by one to start development of the next minor release. All merges to master trigger an increment of the `Patch` version, and a build through our internal testing pipeline. We do a `Minor` release approximately every month, which consist of shipping one of the already auto-incremented and tested `Patch` versions. For example after shipping 12.10.24, we incremented Chef to 12.11.0\. From there 18 commits where merged bringing the version to 12.11.18, which we shipped as an omnibus package. Announcements of releases are made to the [chef mailing list](https://discourse.chef.io/c/chef-release) when they are available and are mirrored to the #announcements channel on the [Chef Community Slack](https://community-slack.chef.io/). diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 714354b9f3..12b7694a2b 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -135,7 +135,7 @@ depends 'windows', '>> 1.0' ### Logging Improvements May Cause Behavior Changes -We've made low level changes to how logging behaves in Chef Infra Client that resolves many complaints we've heard of the years. With these change you'll now see the same logging output when you run `chef-client` on the command line as you will in logs from a daemonzed client run. This also corrects often confusing behavior where running `chef-client` on the command line would log to the console, but not to the log file location defined your `client.rb`. In that scenario you'll now see logs in your console and in your log file. We believe this is the expected behavior and will mean that your on-disk log files can always be the source of truth for changes that were made by Chef Infra Client. This may cause unexpected behavior changes for users that relied on using the command line flags to override the `client.rb` log location. If you have daemons running that log using the command line options you want to make sure that `client.rb` log location either matches or isn't defined. +We've make low level changes to how logging behaves in Chef Infra Client that resolves many complaints we've heard of the years. With these change you'll now see the same logging output when you run `chef-client` on the command line as you will in logs from a daemonized client run. This also corrects often confusing behavior where running `chef-client` on the command line would log to the console, but not to the log file location defined your `client.rb`. In that scenario you'll now see logs in your console and in your log file. We believe this is the expected behavior and will mean that your on-disk log files can always be the source of truth for changes that were made by Chef Infra Client. This may cause unexpected behavior changes for users that relied on using the command line flags to override the `client.rb` log location - in this case logging will be sent to *both* the locations in `client.rb` and on the command line. If you have daemons running that log using the command line options you want to make sure that `client.rb` log location either matches or isn't defined. ### Red Hat / CentOS 6 Systems Require C11 GCC for Some Gem Installations @@ -588,7 +588,7 @@ Several legacy Windows helpers have been deprecated as they will always return t ## Ohai 15.9 -- Improve the resilency of the `Shard` plugin when `dmidecode` cannot be found on a system. Thanks [@jaymzh](https://github.com/jaymzh) +- Improve the resiliency of the `Shard` plugin when `dmidecode` cannot be found on a system. Thanks [@jaymzh](https://github.com/jaymzh) - Fixed detection of Openstack guests via DMI data. Thanks [@ramereth](https://github.com/ramereth) ## Platform Support @@ -861,7 +861,7 @@ The `windows_task` resource is now idempotent when a system is joined to a domai ### x509_certificate -The `x509_certificate` resource now includes a new `renew_before_expiry` property that allows you to auto renew certicates a specified number of days before they expire. Thanks [@julienhuon](https://github.com/julienhuon/) for this improvement. +The `x509_certificate` resource now includes a new `renew_before_expiry` property that allows you to auto renew certificates a specified number of days before they expire. Thanks [@julienhuon](https://github.com/julienhuon/) for this improvement. ## Additional Recipe Helpers @@ -1192,7 +1192,7 @@ openssl has been updated from 1.0.2s to 1.0.2t in order to resolve [CVE-2019-156 ### nokogiri -nokogori has been updated from 1.10.2 to 1.10.4 in order to resolve [CVE-2019-5477](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-5477) +nokogiri has been updated from 1.10.2 to 1.10.4 in order to resolve [CVE-2019-5477](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-5477) # Chef Infra Client 15.2 @@ -1721,7 +1721,7 @@ The deprecated `Ohai::Util::Win32::GroupHelper` helper has been removed from Oha ### Ohai::System.refresh_plugins method removal -The `refresh_plugins` method in the `Ohai::System` class has been removed as it has been unused for multiple major Ohai releases. If you are programatically using Ohai in your own Ruby application, you will need to update your code to use the `load_plugins` method instead. +The `refresh_plugins` method in the `Ohai::System` class has been removed as it has been unused for multiple major Ohai releases. If you are programmatically using Ohai in your own Ruby application, you will need to update your code to use the `load_plugins` method instead. ### Ohai Microsoft VirtualPC / VirtualServer detection removal @@ -1896,7 +1896,7 @@ openssl has been updated from 1.0.2s to 1.0.2t in order to resolve [CVE-2019-156 ### nokogiri -nokogori has been updated from 1.10.2 to 1.10.4 in order to resolve [CVE-2019-5477](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-5477). +nokogiri has been updated from 1.10.2 to 1.10.4 in order to resolve [CVE-2019-5477](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-5477). # Chef Infra Client Release Notes 14.13: @@ -1947,7 +1947,7 @@ In preparation for Chef Infra Client 15.0 we've added a placeholder `--chef-lice ## Important Bug Fixes -- Blacklisting and whiteliting default and override level attributes is once again possible. +- Blacklisting and whitelisting default and override level attributes is once again possible. - You may now encrypt a previously unencrypted data bag. - Resolved a regression introduced in Chef Infra Client 14.12.3 that resulted in errors when managing Windows services @@ -2052,7 +2052,7 @@ Since Chef 13, `knife cookbook site` has actually called the `knife supermarket` ### Audit Mode -Chef's Audit mode was introduced in 2015 as a beta that needed to be enabled via client.rb. Its functionality has been superceded by InSpec and we will be removing this beta feature in Chef Infra Client 15 (April 2019). +Chef's Audit mode was introduced in 2015 as a beta that needed to be enabled via client.rb. Its functionality has been superseded by InSpec and we will be removing this beta feature in Chef Infra Client 15 (April 2019). ### Cookbook Shadowing @@ -2144,7 +2144,7 @@ windows_ad_join now uses the UPN format for usernames, which prevents some failu ### windows_certificate -An issue was resolved in the :acl_add action of the windows_certificate resource, which caused the resource to fail. Thank you [@shoekstra](htts://github.com/shoekstra) for reporting this issue. +An issue was resolved in the :acl_add action of the windows_certificate resource, which caused the resource to fail. Thank you [@shoekstra](https://github.com/shoekstra) for reporting this issue. ### windows_feature @@ -3187,7 +3187,7 @@ Support for Windows 2003 has been removed from both Chef and Ohai, improving the ### Chef Solo `-r` flag -The Chef Solor `-r` flag has been removed as it was deprecated and replaced with the `--recipe-url` flag in Chef 12. +The Chef Solo `-r` flag has been removed as it was deprecated and replaced with the `--recipe-url` flag in Chef 12. ### node.set and node.set_unless attribute levels removal @@ -3705,7 +3705,7 @@ The following properties are new for the `remote_file` resource: - `remote_user`<br> **Ruby types:** String<br> - _Windows only:_ The user name of a user with access to the remote file specified by the `source` property. Default value: `nil`. The user name may optionally be specifed with a domain, i.e. `domain\user` or `user@my.dns.domain.com` via Universal Principal Name (UPN) format. It can also be specified without a domain simply as `user` if the domain is instead specified using the `remote_domain` attribute. Note that this property is ignored if `source` is not a UNC path. If this property is specified, the `remote_password` property **must** be specified. + _Windows only:_ The user name of a user with access to the remote file specified by the `source` property. Default value: `nil`. The user name may optionally be specified with a domain, i.e. `domain\user` or `user@my.dns.domain.com` via Universal Principal Name (UPN) format. It can also be specified without a domain simply as `user` if the domain is instead specified using the `remote_domain` attribute. Note that this property is ignored if `source` is not a UNC path. If this property is specified, the `remote_password` property **must** be specified. - `remote_password`<br> **Ruby types** String<br> @@ -4176,7 +4176,7 @@ Without a declared cwd the relative path was (most likely?) relative to wherever This change is most likely to only affect internals of tooling like chefspec if it affects anything at all. -### PolicyFile failback to create non-policyfile nodes on Chef Server < 12.3 has been removed +### PolicyFile fallback to create non-policyfile nodes on Chef Server < 12.3 has been removed PolicyFile users on Chef-13 should be using Chef Server 12.3 or higher. @@ -4190,7 +4190,7 @@ Retained only for the service resource (where it makes some sense) and for the m ### Removed retrying of non-StandardError exceptions for Chef::Resource -Exceptions not decending from StandardError (e.g. LoadError, SecurityError, SystemExit) will no longer trigger a retry if they are raised during the executiong of a resources with a non-zero retries setting. +Exceptions not descending from StandardError (e.g. LoadError, SecurityError, SystemExit) will no longer trigger a retry if they are raised during the execution of a resources with a non-zero retries setting. ### Removed deprecated `method_missing` access from the Chef::Node object @@ -4270,7 +4270,7 @@ The `recommends`, `suggests`, `conflicts`, `replaces` and `grouping` metadata fi ### All unignored cookbook files will now be uploaded. -We now treat every file under a cookbook directory as belonging to a cookbook, unless that file is ignored with a `chefignore` file. This is a change from the previous behaviour where only files in certain directories, such as `recipes` or `templates`, were treated as special. This change allows chef to support new classes of files, such as Ohai plugins or Inspec tests, without having to make changes to the cookbook format to support them. +We now treat every file under a cookbook directory as belonging to a cookbook, unless that file is ignored with a `chefignore` file. This is a change from the previous behavior where only files in certain directories, such as `recipes` or `templates`, were treated as special. This change allows chef to support new classes of files, such as Ohai plugins or Inspec tests, without having to make changes to the cookbook format to support them. ### DSL-based custom resources and providers no longer get module constants @@ -4463,7 +4463,7 @@ The `execute` resource and similar resources such as `script`, `batch`, and `pow **Note**: When Chef is running as a service, this feature requires that the user that Chef runs as has 'SeAssignPrimaryTokenPrivilege' (aka 'SE_ASSIGNPRIMARYTOKEN_NAME') user right. By default only LocalSystem and NetworkService have this right when running as a service. This is necessary even if the user is an Administrator. -This right bacn be added and checked in a recipe using this example: +This right can be added and checked in a recipe using this example: ```ruby # Add 'SeAssignPrimaryTokenPrivilege' for the user @@ -58,7 +58,7 @@ namespace :pre_install do task all: ["pre_install:install_gems_from_dirs", "pre_install:render_powershell_extension"] end -# hack in all the preinstall tasks to occur before the tradtional install task +# hack in all the preinstall tasks to occur before the traditional install task task install: "pre_install:all" # make sure we build the correct gemspec on windows @@ -108,3 +108,17 @@ begin rescue LoadError puts "yard is not available. bundle install first to make sure all dependencies are installed." end + +namespace :spellcheck do + task :run do + sh 'cspell "**/*" "*.md"' + end + + desc "List the unique unrecognized words in the project." + task :unknown_words do + sh 'cspell "**/*" "*.md" --wordsOnly --no-summary | sort | uniq' + end +end + +desc "Run spellcheck on the project." +task spellcheck: "spellcheck:run" diff --git a/chef-config/lib/chef-config/config.rb b/chef-config/lib/chef-config/config.rb index f34f6d82a3..7fc2e2c91e 100644 --- a/chef-config/lib/chef-config/config.rb +++ b/chef-config/lib/chef-config/config.rb @@ -479,7 +479,7 @@ module ChefConfig # 11 (true) or Chef Server 12 (false). Chef Zero can still serve # policyfile objects in Chef 11 mode, as long as `repo_mode` is set to # "hosted_everything". The primary differences are: - # * Chef 11 mode doesn't support multi-tennant, so there is no + # * Chef 11 mode doesn't support multi-tenant, so there is no # distinction between global and org-specific objects (since there are # no orgs). # * Chef 11 mode doesn't expose RBAC objects @@ -527,7 +527,7 @@ module ChefConfig # switching based on it is almost certainly doing the wrong thing and papering over # bugs that should be fixed in one or the other class, and will be brittle and destined # to break in the future (and not necessarily on a major version bump). Checking this value - # is also not sufficent to determine if we are not running against a server since this can + # is also not sufficient to determine if we are not running against a server since this can # be unset but :local_mode may be set. It would be accurate to check both :solo and :local_mode # to determine if we're not running against a server, but the more semantically accurate test # is going to be combining :solo_legacy_mode and :local_mode. @@ -952,7 +952,7 @@ module ChefConfig # distribution. # # The disadvantages of lazily loading files are that users some time find it - # confusing that their cookbooks are not fully synchronzied to the cache initially, + # confusing that their cookbooks are not fully synchronized to the cache initially, # and more importantly the time-sensitive URLs which are in the manifest may time # out on long Chef runs before the resource that uses the file is converged # (leading to many confusing 403 errors on template/cookbook_file resources). @@ -1109,7 +1109,7 @@ module ChefConfig end # Given a scheme, host, and port, return the correct proxy URI based on the - # set environment variables, unless exluded by no_proxy, in which case nil + # set environment variables, unless excluded by no_proxy, in which case nil # is returned def self.proxy_uri(scheme, host, port) proxy_env_var = ENV["#{scheme}_proxy"].to_s.strip diff --git a/chef-config/lib/chef-config/path_helper.rb b/chef-config/lib/chef-config/path_helper.rb index bba639245e..8429a08c1f 100644 --- a/chef-config/lib/chef-config/path_helper.rb +++ b/chef-config/lib/chef-config/path_helper.rb @@ -130,16 +130,16 @@ module ChefConfig end # This is the INVERSE of Pathname#cleanpath, it converts forward - # slashes to backwhacks for Windows. Since the Ruby API and the + # slashes to backslashes for Windows. Since the Ruby API and the # Windows APIs all consume forward slashes, this helper function # should only be used for *DISPLAY* logic to send strings back - # to the user with backwhacks. Internally, filename paths should + # to the user with backslashes. Internally, filename paths should # generally be stored with forward slashes for consistency. It is # not necessary or desired to blindly convert pathnames to have - # backwhacks on Windows. + # backslashes on Windows. # # Generally, if the user isn't going to be seeing it, you should be - # using Pathname#cleanpath intead of this function. + # using Pathname#cleanpath instead of this function. def self.cleanpath(path) path = Pathname.new(path).cleanpath.to_s # ensure all forward slashes are backslashes diff --git a/chef-config/spec/unit/config_spec.rb b/chef-config/spec/unit/config_spec.rb index 5cf814e7b3..ccfe57c57c 100644 --- a/chef-config/spec/unit/config_spec.rb +++ b/chef-config/spec/unit/config_spec.rb @@ -175,11 +175,11 @@ RSpec.describe ChefConfig::Config do end context "when passes multiple cookbook_paths in config options" do - let(:extra_config_options) { ["cookbook_path=[first_cookbook, secound_cookbooks]"] } + let(:extra_config_options) { ["cookbook_path=[first_cookbook, second_cookbooks]"] } it "expanded paths" do apply_config - expect(described_class[:cookbook_path]).to eq(["#{current_directory}/first_cookbook", "#{current_directory}/secound_cookbooks"]) + expect(described_class[:cookbook_path]).to eq(["#{current_directory}/first_cookbook", "#{current_directory}/second_cookbooks"]) end end end @@ -205,8 +205,8 @@ RSpec.describe ChefConfig::Config do # end # else # formatter = "null" - # log_location = configured-value or defualt - # log_level = info or defualt + # log_location = configured-value or default + # log_level = info or default # end # it "has an empty list of formatters by default" do diff --git a/chef-config/spec/unit/workstation_config_loader_spec.rb b/chef-config/spec/unit/workstation_config_loader_spec.rb index f5fc7f90e2..c589b298ae 100644 --- a/chef-config/spec/unit/workstation_config_loader_spec.rb +++ b/chef-config/spec/unit/workstation_config_loader_spec.rb @@ -52,7 +52,7 @@ RSpec.describe ChefConfig::WorkstationConfigLoader do end it "tests a path's existence" do - expect(config_loader.path_exists?("/nope/nope/nope/nope/frab/jab/nab")).to be(false) + expect(config_loader.path_exists?("/nope/nope/nope/nope/slab/jab/nab")).to be(false) expect(config_loader.path_exists?(__FILE__)).to be(true) end @@ -214,7 +214,7 @@ RSpec.describe ChefConfig::WorkstationConfigLoader do describe "loading the config file" do - context "when no explicit config is specifed and no implicit config is found" do + context "when no explicit config is specified and no implicit config is found" do before do allow(config_loader).to receive(:path_exists?).with(an_instance_of(String)).and_return(false) @@ -230,7 +230,7 @@ RSpec.describe ChefConfig::WorkstationConfigLoader do context "when an explicit config is given but it doesn't exist" do - let(:explicit_config_location) { "/nope/nope/nope/frab/jab/nab" } + let(:explicit_config_location) { "/nope/nope/nope/slab/jab/nab" } it "raises a configuration error" do expect { config_loader.load }.to raise_error(ChefConfig::ConfigurationError) @@ -402,12 +402,12 @@ RSpec.describe ChefConfig::WorkstationConfigLoader do end context "has a non rb file" do - let(:sytax_error_content) { "{{{{{:{{" } + let(:syntax_error_content) { "{{{{{:{{" } let(:config_content) { "config_d_file_evaluated(true)" } let!(:not_confd_file) do Tempfile.new(["Chef-WorkstationConfigLoader-rspec-test", ".foorb"], tempdir).tap do |t| - t.print(sytax_error_content) + t.print(syntax_error_content) t.close end end diff --git a/chef-utils/README.md b/chef-utils/README.md index 96a165487d..01feafb3e8 100644 --- a/chef-utils/README.md +++ b/chef-utils/README.md @@ -30,9 +30,9 @@ The Platform Family helpers provide an alternative to comparing values from `nod * `netbsd?` * `openbsd?` * `rhel?` - includes redhat, centos, scientific, oracle, and clearos platforms -* `rhel6?` - includes redhat6, centos6, scientifc6, oracle6, and clearos6 platforms -* `rhel7?` - includes redhat7, centos7, scientifc7, oracle7, and clearos7 platforms -* `rhel8?` - includes redhat8, centos8, scientifc8, oracle8, and clearos8 platforms +* `rhel6?` - includes redhat6, centos6, scientific6, oracle6, and clearos6 platforms +* `rhel7?` - includes redhat7, centos7, scientific7, oracle7, and clearos7 platforms +* `rhel8?` - includes redhat8, centos8, scientific8, oracle8, and clearos8 platforms * `smartos?` * `solaris2?` * `suse?` - includes suse and opensuseleap platforms @@ -41,7 +41,7 @@ The Platform Family helpers provide an alternative to comparing values from `nod Super Families: -* `fedora_based?` - anything of fedora lineage (fedora, fedhat, centos, amazon, pidora, etc) +* `fedora_based?` - anything of fedora lineage (fedora, redhat, centos, amazon, pidora, etc) * `rpm_based?`- all `fedora_based` systems plus `suse` and any future linux distros based on RPM (excluding AIX) * `solaris_based?`- all solaris-derived systems (opensolaris, nexentacore, omnios, smartos, etc) * `bsd_based?`- all bsd-derived systems (freebsd, netbsd, openbsd, dragonflybsd). diff --git a/chef-utils/lib/chef-utils/dsl/platform_family.rb b/chef-utils/lib/chef-utils/dsl/platform_family.rb index 8feadeb9c4..cfe6b617e5 100644 --- a/chef-utils/lib/chef-utils/dsl/platform_family.rb +++ b/chef-utils/lib/chef-utils/dsl/platform_family.rb @@ -301,7 +301,7 @@ module ChefUtils end # RedHat distros -- fedora and rhel platform_families, nothing else. This is most likely not as useful as the - # "fedora_dervied?" helper. + # "fedora_derived?" helper. # # @param [Chef::Node] node the node to check # @since 15.5 diff --git a/chef-utils/lib/chef-utils/dsl/which.rb b/chef-utils/lib/chef-utils/dsl/which.rb index cc554a5e8a..a91e35da38 100644 --- a/chef-utils/lib/chef-utils/dsl/which.rb +++ b/chef-utils/lib/chef-utils/dsl/which.rb @@ -25,7 +25,7 @@ module ChefUtils # Lookup an executable through the systems search PATH. Allows specifying an array # of executables to look for. The first executable that is found, along any path entry, # will be the preferred one and returned first. The extra_path will override any default - # extra_paths which are added (allwing the user to pass an empty array to remove them). + # extra_paths which are added (allowing the user to pass an empty array to remove them). # # When passed a block the block will be called with the full pathname of any executables # which are found, and the block should return truthy or falsey values to further filter @@ -34,7 +34,7 @@ module ChefUtils # This is syntactic sugar for `where(...).first` # # This helper can be used in target mode in chef or with train using the appropriate - # wiring extenerally. + # wiring externally. # # @example Find the most appropriate python executable, searching through the system PATH # plus additionally the "/usr/libexec" directory, which has the dnf libraries @@ -55,14 +55,14 @@ module ChefUtils # Lookup all the instances of an an executable that can be found through the systems search PATH. # Allows specifying an array of executables to look for. All the instances of the first executable # that is found will be returned first. The extra_path will override any default extra_paths - # which are added (allwing the user to pass an empty array to remove them). + # which are added (allowing the user to pass an empty array to remove them). # # When passed a block the block will be called with the full pathname of any executables # which are found, and the block should return truthy or falsey values to further filter # the executable based on arbitrary criteria. # # This helper can be used in target mode in chef or with train using the appropriate - # wiring extenerally. + # wiring externally. # # @example Find all the python executables, searching through the system PATH plus additionally # the "/usr/libexec" directory, which have the dnf libraries installed and available. diff --git a/chef-utils/lib/chef-utils/internal.rb b/chef-utils/lib/chef-utils/internal.rb index 713ac277de..731a0d1712 100644 --- a/chef-utils/lib/chef-utils/internal.rb +++ b/chef-utils/lib/chef-utils/internal.rb @@ -27,7 +27,7 @@ module ChefUtils # # This gem may be used by gems like mixlib-shellout which can be consumed by external non-Chef utilities, # so including brittle code here which depends on the existence of the chef-client will cause broken - # behavior downstream. You must practice defensive coding, and not make assumptions about runnign within chef-client. + # behavior downstream. You must practice defensive coding, and not make assumptions about running within chef-client. # # Other consumers may mix in the helper classes and then override the methods here and provide their own custom # wiring and override what is provided here. They are marked as private because no downstream user should ever touch diff --git a/chef-utils/lib/chef-utils/version_string.rb b/chef-utils/lib/chef-utils/version_string.rb index e0888b346e..744704dc63 100644 --- a/chef-utils/lib/chef-utils/version_string.rb +++ b/chef-utils/lib/chef-utils/version_string.rb @@ -143,7 +143,7 @@ module ChefUtils begin Gem::Requirement.create(other) =~ parsed_version rescue ArgumentError - # one side of the comparison wasn't parseable + # one side of the comparison wasn't parsable super end end diff --git a/chef-utils/spec/unit/dsl/introspection_spec.rb b/chef-utils/spec/unit/dsl/introspection_spec.rb index 2b6c697fd7..44a228061d 100644 --- a/chef-utils/spec/unit/dsl/introspection_spec.rb +++ b/chef-utils/spec/unit/dsl/introspection_spec.rb @@ -31,7 +31,7 @@ RSpec.describe ChefUtils::DSL::Introspection do let(:test_instance) { IntrospectionTestClass.new(node) } context "#docker?" do - # FIXME: use a real VividMash for these tests insted of stubbing + # FIXME: use a real VividMash for these tests instead of stubbing it "is false by default" do expect(node).to receive(:read).with("virtualization", "systems", "docker").and_return(nil) expect(ChefUtils.docker?(node)).to be false diff --git a/chef-utils/spec/unit/dsl/which_spec.rb b/chef-utils/spec/unit/dsl/which_spec.rb index dc0f037a89..cd867c4e72 100644 --- a/chef-utils/spec/unit/dsl/which_spec.rb +++ b/chef-utils/spec/unit/dsl/which_spec.rb @@ -78,7 +78,7 @@ RSpec.describe ChefUtils::DSL::Which do end context "with a block" do - test_which("doesnt find it if its false", "foo1", others: [ "/dir1/foo1" ]) do |f| + test_which("doesn't find it if its false", "foo1", others: [ "/dir1/foo1" ]) do |f| false end diff --git a/cspell.json b/cspell.json new file mode 100644 index 0000000000..6d661c83b8 --- /dev/null +++ b/cspell.json @@ -0,0 +1,2204 @@ +// cSpell Settings +{ + // Version of the setting file. Always 0.1 + "version": "0.1", + // language - current active spelling language + "language": "en", + // words - list of words to be always considered correct + "words": [ + "ABORTIFHUNG", + "ACCOUNTDISABLE", + "ACLs", + "ACPI", + "ADAP", + "ADMINI", + "ADODB", + "ALLUSERSPROFILE", + "APISSL", + "ARCHITEW", + "ARPHELPLINK", + "ARPPRODUCTICON", + "ASSIGNPRIMARYTOKEN", + "AUTHN", + "AUTHROOT", + "AUTHZ", + "AUTODATASEG", + "Abdulin", + "Adhoc", + "Afonov", + "Akzhan", + "Alam", + "Albenzi", + "Algorta", + "Alloc", + "Antergos", + "Appscript", + "Artifactory", + "Arțăriși", + "Ashwini", + "Autoconverted", + "Autorun", + "Autovivification", + "Avishai", + "Awasthi", + "Axuba", + "BACKOFFICE", + "BADKEY", + "BUNDER", + "Backporting", + "Balatero", + "Benesch", + "Berksfile", + "Berkshelf", + "Bianco", + "Botman", + "Brightcove", + "Brimager", + "Bugfixes", + "Buildkite", + "CALLGATE", + "CANTOPEN", + "CANTREAD", + "CANTWRITE", + "CFLAGS", + "CFPREFERENCES", + "CHEFBIN", + "CHEFCONFIG", + "CHEFSERVERURL", + "CHEFUTILS", + "CHINESEBIG", + "CHKCONFIG", + "CLEARTEXT", + "CLIENTAUTHISSUER", + "CLOEXEC", + "CMDS", + "CODESEG", + "COLORINDEX", + "COLORREF", + "COLORSPACE", + "COMBOBOX", + "COMPOSITECHECK", + "COMPUTERNAME", + "COMSPEC", + "CONFIGLOCATION", + "CONFIGLOCATIONDIR", + "CONSTS", + "CPPFLAGS", + "CREAT", + "CRYPTOPROTECT", + "CRYPTPROTECT", + "CTRY", + "CTYPE", + "CVEs", + "Calastone", + "Cavalca", + "Cavallo", + "Certstore", + "Chaput", + "Chefignore", + "Chisamore", + "Chouhan", + "Cloke", + "Cloudera", + "Cmdlet", + "Cmnd", + "Cond", + "Cookstyle", + "Cowie", + "Cragun", + "Createobject", + "Cribbs", + "Crory", + "Crosta", + "Cxxx", + "DATAFILE", + "DATALINK", + "DBATCH", + "DBCS", + "DBUS", + "DDTHH", + "DEFAULTCHAR", + "DESCR", + "DEVICEEVENT", + "DEVIOCTL", + "DFSR", + "DHCP", + "DIDNT", + "DISCARDABLE", + "DISCARDNS", + "DISM", + "DMGs", + "DOSDUPHANDLE", + "DOTMATCH", + "DUPEUX", + "DWORD", + "DWORDLONG", + "DYNALINK", + "DYNLINK", + "Daemonization", + "Daemonizing", + "Danna", + "Datacenter", + "Davin", + "Decompressor", + "Deepali", + "Deorukhkar", + "Depsolving", + "Devaux", + "Dfsn", + "Dhanesh", + "Dheeraj", + "Dialup", + "Dibowitz", + "Diffie", + "Doherty", + "Dokken", + "Doppel", + "Dpkg", + "Dreamcat", + "Dubey", + "Désarmes", + "EACCES", + "EASTEUROPE", + "EBUSY", + "ECDSA", + "ECONNREFUSED", + "ECONNRESET", + "EEXIST", + "EINVAL", + "EISDIR", + "ELOOP", + "EMBEDDEDBIN", + "EMBEDDEDNT", + "EMBEDDEDSERVER", + "ENABLEDELAYEDEXPANSION", + "ENOENT", + "ENVVAR", + "EPERM", + "EPIPE", + "EPOC", + "ERRORLEVEL", + "ESRCH", + "ETHTOOL", + "ETIMEDOUT", + "EVENTNAME", + "EXCED", + "EXTGLOB", + "Eachern", + "Encryptor", + "Erchef", + "Errno", + "Erubis", + "Eruby", + "Etcd", + "Eugen", + "Exts", + "FACs", + "FAILCRITICALERRORS", + "FAPI", + "FASTZIPAPPNAME", + "FASTZIPDIR", + "FFLAGS", + "FILEMARK", + "FILETIME", + "FIPS", + "FORCEMINIMIZE", + "FORCEOFFFEEDBACK", + "FORCEONFEEDBACK", + "FQDN", + "FSCTL", + "FUGLY", + "FULLSCREEN", + "Fichter", + "Fileexists", + "Fileystem", + "Fixnums", + "Foodcritic", + "Forwardable", + "Fuzzyurl", + "GETFD", + "GOTOU", + "Gemfile", + "Gilles", + "Graeme", + "Granquist", + "Graty", + "Groh", + "HACCEL", + "HANGEUL", + "HARDWAREPROFILECHANGE", + "HBITMAP", + "HBRUSH", + "HCOLORSPACE", + "HCONV", + "HCONVLIST", + "HCURSOR", + "HDDEDATA", + "HDESK", + "HDROP", + "HDWP", + "HENHMETAFILE", + "HFILE", + "HFONT", + "HGDIOBJ", + "HGLOBAL", + "HHOOK", + "HIBYTE", + "HICON", + "HINSTANCE", + "HIWORD", + "HKCC", + "HKCR", + "HKCU", + "HKEY", + "HKLM", + "HLOCAL", + "HMDQ", + "HMENU", + "HMETAFILE", + "HMOD", + "HMODULE", + "HMONITOR", + "HOMEDRIVE", + "HOMEPATH", + "HOMESHARE", + "HPALETTE", + "HPEN", + "HRESULT", + "HRGN", + "HRSRC", + "HWINSTA", + "HWND", + "HWNDS", + "HWRP", + "HWRPs", + "Hankins", + "Hansson", + "Happycoil", + "Haselwanter", + "Hedgpeth", + "Heen", + "Heinemeier", + "Hellmann", + "Hinderliter", + "Hongli", + "Hostnames", + "Hsiao", + "Huon", + "ICMP", + "IEND", + "IGNORECASE", + "IHDR", + "INFINIBAND", + "INFLOOP", + "INPORT", + "INSTALLDIR", + "INSTALLLOCATION", + "INTERDOMAIN", + "IOPL", + "IPADDR", + "Ifconfig", + "Immutablize", + "Indentable", + "Inspec", + "Interupts", + "Intility", + "Ionuț", + "Ippolito", + "Ipscopes", + "Ireton", + "Itanium", + "JOHAB", + "Jablonskis", + "Jagdale", + "Jagtap", + "Javorski", + "Jeppe", + "Jesai", + "Juanje", + "KEYNAME", + "KSEC", + "Kampmeier", + "Kantrowitz", + "Kapil", + "Kauppila", + "Kaustubh", + "Keane", + "Keiser", + "Khatri", + "Kirill", + "Korn", + "Kouznetsov", + "Kubb", + "Kundan", + "LANGID", + "LASTDAY", + "LASTEXITCODE", + "LCID", + "LCTYPE", + "LDAP", + "LEADBYTE", + "LGRPID", + "LHND", + "LIBC", + "LIBPATH", + "LISTBOX", + "LMEM", + "LMSHARE", + "LMSTR", + "LOBYTE", + "LOCALGROUP", + "LOCKCOUNT", + "LOGLOCATION", + "LONGLONG", + "LOWORD", + "LPARAM", + "LPBOOL", + "LPBY", + "LPBYTE", + "LPCOLORREF", + "LPCSTR", + "LPCTSTR", + "LPCVOID", + "LPCWSTR", + "LPDWORD", + "LPHANDLE", + "LPINT", + "LPLONG", + "LPOSVERSIONINFO", + "LPOVERLAPPED", + "LPSECURITY", + "LPSTR", + "LPTR", + "LPTSTR", + "LPVOID", + "LPWIN", + "LPWORD", + "LPWSTR", + "LRESULT", + "LUIDS", + "LWRPs", + "Laco", + "Landauer", + "Langenbach", + "Lavey", + "Leff", + "Leinartas", + "Lellan", + "Libxml", + "MACCP", + "MAILSLOT", + "MAKELONG", + "MAKEWORD", + "MAXARGS", + "MAXDWORD", + "MDICHILD", + "MEDIUMBUSINESS", + "MESSAGEDEST", + "MESSAGENAME", + "METAFILE", + "MINALLOCSIZE", + "MITM", + "MKTEMP", + "MODULETYPE", + "MONTHLYDATE", + "MONTHLYDOW", + "MSDNQTR", + "MSGBOX", + "MSIERRORCODE", + "MSIFASTINSTALL", + "MSIHANDLE", + "MSVCRT", + "MSXML", + "MSYSTEM", + "MULTICAST", + "MUXWAITERS", + "Madsen", + "Magnus", + "Maier", + "Mainmodule", + "Makefiles", + "Mangeia", + "Manjaro", + "Manyanza", + "Masayoshi", + "Mathieson", + "Mathieu", + "Mdadm", + "Merb", + "Miah", + "Microarchitecture", + "Midgley", + "Mixins", + "Mollison", + "Monkeypatches", + "Msftedit", + "Mtyj", + "Multicast", + "Multiresource", + "Multiuser", + "Mundrawala", + "Murawski", + "Mutators", + "Mware", + "Mycook", + "Mzyk", + "NCRC", + "NERR", + "NETBINDADD", + "NETBINDCHANGE", + "NETBINDDISABLE", + "NETBINDENABLE", + "NETBINDREMOVE", + "NETCARD", + "NETLOGON", + "NETNAME", + "NETPATH", + "NOACCESS", + "NOACTION", + "NOALIGNMENTFAULTEXCEPT", + "NOCHANGES", + "NOCOMPACT", + "NODISCARD", + "NOFOLLOW", + "NOGPFAULTERRORBOX", + "NOLOGON", + "NONPAGED", + "NONROOT", + "NONZEROLHND", + "NONZEROLPTR", + "NOOPENFILEERRORBOX", + "NORESTART", + "NOTIMEOUTIFNOTHUNG", + "NOTUSED", + "NOWAIT", + "NPAS", + "NTSTATUS", + "Nano", + "Nehate", + "Nejsum", + "Nexenta", + "Nichol", + "Nikhil", + "Nimisha", + "Nodearray", + "Nokogiri", + "Nullsoft", + "O'Meara", + "OEMCP", + "OLDLOGLOCATION", + "ONPARENT", + "OPLOCK", + "OPTARG", + "OPTIND", + "OSVERSIONINFOEX", + "OXID", + "Ohai", + "Ojeda", + "Omnitruck", + "Onddo", + "Openstack", + "Overridable", + "Overriders", + "PARAMCHANGE", + "PASSWORDNAME", + "PATCHLEVEL", + "PATHFINDING", + "PBOOL", + "PBOOLEAN", + "PBYTE", + "PCHAR", + "PCRYPTPROTECT", + "PCSTR", + "PCTSTR", + "PCWSTR", + "PDATA", + "PDWORD", + "PDWORDLONG", + "PFILETIME", + "PFLOAT", + "PGENERICMAPPING", + "PHALF", + "PHANDLE", + "PHKEY", + "PIDFILE", + "PKCS", + "PKINIT", + "PLCID", + "PLONG", + "PLONGLONG", + "PLSA", + "PLUID", + "PNAME", + "POLICYNAME", + "PORTVERSION", + "POSI", + "POSIX", + "POST'ing", + "POWEREVENT", + "PQRJ", + "PRECOMPOSED", + "PREPARSE", + "PRESHUTDOWN", + "PRINC", + "PRINTPROCESSOR", + "PRINTQ", + "PROCNUM", + "PROJECTLOCATION", + "PROJECTLOCATIONBIN", + "PROMPTSTRUCT", + "PROTO", + "PROTSEQ", + "PROTSEQS", + "PSAPI", + "PSECURITY", + "PSHORT", + "PSIZE", + "PSMODULES", + "PSSIZE", + "PSTR", + "PTBYTE", + "PTCHAR", + "PTSTR", + "PUCHAR", + "PUHALF", + "PUINT", + "PULONG", + "PULONGLONG", + "PUSHORT", + "PUTing", + "PVOID", + "PWCHAR", + "PWIN", + "PWORD", + "PWSTR", + "PYTHONUNBUFFERED", + "Pagefile", + "Parallelizer", + "Passwd", + "Pelberg", + "Penniman", + "Philis", + "Piyush", + "Policybuilder", + "Policyfile", + "Policyfiles", + "Prabhu", + "Prajakta", + "Precompiled", + "Prepending", + "Proxifier", + "Pscx", + "Psec", + "Purohit", + "Quer", + "RBAC", + "RBENV", + "RDWR", + "REDIR", + "REDIRECTOR", + "REGSAM", + "REINITIALIZATION", + "RELOC", + "REMOVEME", + "REPARSE", + "REPLACESTR", + "REXML", + "RHEL", + "RMODE", + "RUBYLIB", + "RUBYOPT", + "RUNFULLSCREEN", + "RXACT", + "Raghavan", + "Rakefile", + "Rakvåg", + "Ranjib", + "Rebooter", + "Recurse", + "Recurses", + "Redistributable", + "Reenable", + "Renaud", + "Rockwood", + "Romain", + "Rubygems", + "Rubyzip", + "Rudikza", + "Runtimes", + "SAWANOBORI", + "SCODE", + "SCROLLBAR", + "SCROLLBARS", + "SECURITYPOLICY", + "SEGDPL", + "SEGLIM", + "SEPCHARS", + "SERENUM", + "SERVERR", + "SERVICENAME", + "SESS", + "SESSIONCHANGE", + "SESSIONID", + "SETCOUNT", + "SETFD", + "SETMARK", + "SETTINGCHANGE", + "SETX", + "SHARENAME", + "SHAs", + "SHIFTJIS", + "SHOWDEFAULT", + "SHOWMAXIMIZED", + "SHOWMINIMIZED", + "SHOWMINNOACTIVE", + "SHOWNA", + "SHOWNOACTIVATE", + "SHOWNORMAL", + "SHOWWIN", + "SIGHUP", + "SIGINT", + "SIGKILL", + "SIGQUIT", + "SIGTERM", + "SIGUSR", + "SINGLEUSERTS", + "SITENAME", + "SLES", + "SMALLBUSINESS", + "SMARTCARD", + "SMARTCARDROOT", + "SMTO", + "SOLOEXEC", + "SRCCHARSET", + "SRCCODEPAGE", + "SRCFONTSIG", + "SRCLOCALE", + "SSIZE", + "STACKSEG", + "STARTF", + "STARTSSH", + "STARTUPINFO", + "SUBFOLDERS", + "SUBKEY", + "SUBSTED", + "SUPPRESSMSGBOXES", + "SWAPERROR", + "SYSTEMDRIVE", + "SYSTEMROOT", + "SYSTEMSTART", + "Salim", + "Sauve", + "Saxby", + "Sbzl", + "Scaleway", + "Schuberg", + "Scriptable", + "Serdar", + "Sertelon", + "Shamrell", + "Sharad", + "Shellwords", + "Sheng", + "Shopify", + "Shouldnotexist", + "Sierles", + "Singleuser", + "Sliim", + "Smokish", + "Snapp", + "Socketless", + "Softlayer", + "Solaris", + "Solr", + "Splunk", + "Stanislav", + "Stepable", + "Stratton", + "Struct", + "Sutay", + "Symlink", + "Sysconf", + "Sysexits", + "Sysinternals", + "Systemd", + "Systemtime", + "Sölvi", + "TAKAHASHI", + "TARGETDIR", + "TBYTE", + "TCBS", + "TCHAR", + "TCPIP", + "TERMSRV", + "TFTP", + "THRDS", + "THREADID", + "TIMECHANGE", + "TRIGGEREVENT", + "TRUNC", + "TRUSTEDDEVICES", + "TRUSTEDPEOPLE", + "TRUSTEDPUBLISHER", + "TSTDUP", + "TSTOVFL", + "TTCS", + "Taddeo", + "Tahoma", + "Thom", + "Timberman", + "Tollef", + "Tolstov", + "Tomlrb", + "Toomas", + "UHALF", + "UINT", + "ULONGLONG", + "UNAVAIL", + "UNEXP", + "UNEXPORTED", + "UNSPEC", + "UNWRITABLE", + "USECOUNTCHARS", + "USEFILLATTRIBUTE", + "USEGLYPHCHARS", + "USEPOSITION", + "USERDOMAIN", + "USEREXIT", + "USERPROFILE", + "USESHOWWINDOW", + "USESIZE", + "USESTDHANDLES", + "UUIDs", + "Uncompressing", + "Undock", + "Unformatter", + "Unjoin", + "Unparsable", + "Unprocessable", + "Unregisters", + "Unsets", + "Untrusted", + "VCPU", + "VERYSILENT", + "VIOKBD", + "VLAN", + "VMBUS", + "VPNs", + "Vaidas", + "Validatorless", + "Vargo", + "Vasiliy", + "Vasundhara", + "Veertu", + "Virender", + "Virtualbox", + "Vitruvius", + "Vitvitskiy", + "WBITS", + "WCHAR", + "WEBHOSTING", + "WECs", + "WINAPI", + "WINDOWSTATION", + "WINNT", + "WINVER", + "WIXUI", + "WKSTA", + "WMIGUID", + "WPARAM", + "WSCHILD", + "Walck", + "Wbem", + "Webber", + "Winmgmt", + "Winsor", + "Workgroup", + "Wrock", + "XATTR", + "XEEDS", + "XFORM", + "XMLHTTP", + "Xabier", + "Xcode", + "Xorima", + "Xtdate", + "Yukihiko", + "Yuuzou", + "ZEROEXEC", + "ZEROINIT", + "Zanetti", + "Zapp", + "Zimmek", + "Zpool", + "Zuazo", + "Zygmuntowicz", + "Zypper", + "aarch", + "abcz", + "activationkey", + "activesupport", + "addlock", + "addrs", + "adminonly", + "advapi", + "agrs", + "airgapped", + "aixinit", + "albertomurillo", + "allowselfservice", + "allprofiles", + "alnum", + "alwayslastline", + "amazonec", + "amazonlinux", + "americanhanko", + "anewb", + "angrychef", + "anonymized", + "apparmor", + "appbundled", + "appbundler", + "applewood", + "appx", + "archq", + "argdup", + "arity", + "armhf", + "arry", + "artem", + "asdf", + "astoltz", + "astring", + "attribs", + "attrname", + "auditd", + "autoconf", + "autodetect", + "autodetected", + "autogenerated", + "autohome", + "autoload", + "automake", + "autoneg", + "autorefresh", + "autoreplacing", + "autoscaling", + "autostr", + "autotest", + "autovivifies", + "autovivify", + "autovivifying", + "backcompat", + "backends", + "backoff", + "backport", + "backported", + "backporting", + "backslashing", + "backtrace", + "backtraces", + "backupfile", + "badpasswordattempts", + "balasankarc", + "barbaz", + "basearch", + "basenames", + "basepath", + "basestring", + "baseurls", + "bcast", + "bigip", + "bindir", + "bindirs", + "binfile", + "binlink", + "binmode", + "binread", + "binstub", + "binstubs", + "binutils", + "bitmask", + "bkup", + "blockdev", + "bmhatfield", + "bobberson", + "bobchaos", + "bobo", + "bobotclown", + "boostrap", + "bootp", + "bootproto", + "bootstrapper", + "bootstrappers", + "borat", + "brodock", + "bsearch", + "bsevn", + "bufptr", + "bufsize", + "bugfix", + "bugfixes", + "bugfixing", + "bugok", + "busybox", + "bypassproxy", + "bytesize", + "bzip", + "cabfile", + "cacert", + "cacerts", + "calloc", + "canonicalize", + "carg", + "caron", + "casecmp", + "ccdata", + "ccope", + "cdoherty", + "centos", + "certfile", + "cfprefsd", + "cgroup", + "chadmccune", + "chardev", + "chatops", + "chdev", + "chdir", + "checkpointing", + "checksummed", + "checksumming", + "chefcli", + "chefclientbootstraptask", + "chefclientinstalldone", + "chefdir", + "chefdk", + "cheffish", + "cheffs", + "chefignore", + "chefignored", + "chefignores", + "chefscriptresult", + "chefspec", + "chefstyle", + "cheftest", + "chefzero", + "chgroup", + "chgrp", + "chgrpmem", + "chilcote", + "chkconfig", + "chmod", + "choco", + "chown", + "chpasswd", + "chroot", + "chuser", + "cidr", + "cinc", + "ckbk", + "cksum", + "cleanpath", + "cleanpaths", + "cleanroom", + "clearlinux", + "clearos", + "clientname", + "cloudera", + "cmdlet", + "cmdlets", + "cmds", + "cname", + "codepage", + "coderanger", + "colleciton", + "commandline", + "commmand", + "compat", + "computerlevel", + "computersystem", + "comspec", + "concat", + "confd", + "confdef", + "configfetcher", + "configurables", + "configurationdata", + "confnew", + "confold", + "constantize", + "containername", + "containerpath", + "contruct", + "convertto", + "cookbookname", + "cookiecurse", + "cookstyle", + "coookbook", + "copypasta", + "coreutils", + "cpio", + "cpjones", + "createhomedir", + "creds", + "crlfile", + "crlnum", + "cscript", + "cssh", + "csshx", + "csum", + "ctfs", + "curr", + "dacl", + "daemonize", + "daemonized", + "daemonizing", + "danielfloyd", + "databag", + "databags", + "datas", + "davide", + "dbag", + "dbresson", + "debconf", + "debianrcd", + "decompile", + "decryptor", + "dedup", + "defaultguard", + "defn", + "defns", + "deinstall", + "delegators", + "deletable", + "deletin", + "delim", + "deliminates", + "delims", + "deps", + "depsolved", + "derekgroh", + "deserialization", + "destdir", + "devel", + "devicename", + "devkit", + "devmode", + "devoptimist", + "devtools", + "devtoolset", + "dgrade", + "dgreeninger", + "dhparam", + "diffable", + "digitalocean", + "dirglob", + "disablerepo", + "dism", + "displayname", + "distro", + "distros", + "dmidecode", + "docgen", + "dockerd", + "dockerenv", + "dockerignore", + "dockerinit", + "dokken", + "domainandname", + "domainname", + "domainuser", + "dotdeb", + "dotdirs", + "dotfile", + "dotfiles", + "downcase", + "downcased", + "downcases", + "downto", + "dracut", + "dragonflybsd", + "dragonsmith", + "drcmd", + "drzewiec", + "dscacheutil", + "dscl", + "dscresource", + "dsimport", + "dslocal", + "dup'd", + "duvian", + "dword", + "ecdsa", + "eckey", + "ecparam", + "edir", + "egid", + "elif", + "enablegroups", + "enablement", + "enablerepo", + "encap", + "encryptor", + "endlocal", + "entriesread", + "envdata", + "epel", + "erinn", + "erroraction", + "esac", + "etag", + "etags", + "etcd", + "ethtool", + "euca", + "euid", + "eval", + "eventlog", + "executability", + "executables", + "executionpolicy", + "execvp", + "exherbo", + "exitcode", + "exitstatus", + "extname", + "extrastuff", + "exts", + "failburger", + "failovermethod", + "fakeweb", + "fallocate", + "falsey", + "fastestmirror", + "fastmsi", + "fastrestart", + "faststart", + "faststop", + "fatals", + "fauxhai", + "featurename", + "fflags", + "fieldname", + "filehandle", + "fileno", + "filepath", + "filesets", + "filesize", + "filespecificity", + "filesystems", + "fileutils", + "filterm", + "finalizer", + "findfs", + "findstr", + "fizzbuzz", + "flushcache", + "fmri", + "fname", + "fnmatch", + "fonttbl", + "foobarbam", + "foodcritic", + "foorb", + "forwardable", + "forwardslashes", + "fqdn", + "fqdns", + "freakinhippie", + "freebsd", + "fsck", + "fstab", + "fstype", + "fsync", + "fullpath", + "fullpolicy", + "fuzzifier", + "fuzzify", + "fuzzyurl", + "fzipi", + "gecos", + "gemdir", + "gemdirs", + "gempath", + "gemrc", + "gemset", + "gemspecs", + "gencaches", + "getaddrinfo", + "getbinaryfile", + "getc", + "getchef", + "getgrgid", + "getgrnam", + "gethostbyname", + "gethostname", + "getlogin", + "getmodhandle", + "getnode", + "getobj", + "getopts", + "getppid", + "getprint", + "getprocaddr", + "getpwnam", + "getpwuid", + "getspnam", + "gettext", + "gettimezone", + "gettype", + "gids", + "glibc", + "globbing", + "globsafe", + "gmake", + "gmetric", + "gname", + "gnutar", + "googlechrome", + "gotoyuzo", + "gpasswd", + "gpgautoimportkeys", + "gpgcheck", + "gpgkey", + "groupadd", + "groupdel", + "groupmembership", + "groupmod", + "groupname", + "gsingla", + "gssapi", + "gsub", + "gzipped", + "habicat", + "hacky", + "halp", + "hardstatus", + "hashify", + "hawtness", + "hdidutil", + "hdiutil", + "hexdigest", + "hexencode", + "heyjodom", + "hidemins", + "hintname", + "hipchat", + "hivename", + "hmac", + "homepath", + "hostnamectl", + "hostnames", + "hostport", + "hostspec", + "hostspecific", + "hoststr", + "hotfix", + "htop", + "httpd", + "hwaddr", + "hwaddress", + "hyperv", + "icacls", + "ichannel", + "icmp", + "iconlocation", + "idempotence", + "idempotency", + "idempotently", + "idmv", + "iface", + "ifcfg", + "ifconfig", + "ifdef", + "illumos", + "imag", + "imageinfo", + "includedir", + "includepkgs", + "includer", + "indentable", + "indentt", + "inet", + "inetd", + "infile", + "infocmp", + "ingobecker", + "inheritence", + "iniparse", + "initctl", + "initd", + "initgroups", + "initramfs", + "inno", + "inode", + "inout", + "inpipe", + "inputformat", + "inspec", + "insserv", + "installable", + "installondemand", + "installonlypkgs", + "installp", + "installshield", + "instanceid", + "integerish", + "integerize", + "interfacetype", + "interpolatedexitcode", + "ints", + "invokercd", + "invokereturnasis", + "ipaddr", + "ipaddress", + "ipscopes", + "iptables", + "isalnum", + "isalpha", + "isatty", + "isdigit", + "isuftin", + "iterencode", + "ivar", + "ivars", + "jailmode", + "jakauppila", + "janky", + "jasonwbarnett", + "javatooling", + "jaymzh", + "jazaval", + "jboss", + "jdoe", + "jeremyhage", + "jeroenj", + "jimwise", + "jjustice", + "jkeiser", + "josephmilla", + "joyent", + "jsvana", + "jtimberman", + "jugatsu", + "julienhuon", + "junit", + "jwhois", + "katello", + "kaustubh", + "keepalive", + "keepalives", + "keeppackages", + "kenmacleod", + "kerberos", + "keyfile", + "keygen", + "keyid", + "keyivgen", + "keyscan", + "keyserver", + "keystore", + "keytab", + "keyurl", + "kitforbes", + "klass", + "kool", + "kwarg", + "lastcmdlet", + "launchctl", + "launchctrl", + "launchd", + "lchmod", + "lchown", + "lgrmi", + "lgrpi", + "libarchive", + "libexec", + "libffi", + "libiconv", + "liblzma", + "libmysqlclient", + "libtool", + "libvirt", + "libxml", + "libxslt", + "libyaml", + "lifecycle", + "lifecycles", + "linode", + "linuxmint", + "listprop", + "ljust", + "lltstype", + "localdomain", + "localgroupname", + "localip", + "localmachine", + "localname", + "localport", + "localsystem", + "localtime", + "logfile", + "logfiles", + "loginwindow", + "logopts", + "logrotate", + "logstring", + "loopback", + "lowercased", + "lpar", + "lpdw", + "lplp", + "lpsz", + "lsfs", + "lslpp", + "lsof", + "lspci", + "lssrc", + "lstat", + "lsuser", + "ltrace", + "lucene", + "luid", + "lwrp", + "lytao", + "lzma", + "machinename", + "macos", + "macports", + "macterm", + "magick", + "mailservers", + "mailslot", + "mailto", + "mainloop", + "makecache", + "makedepend", + "malloc", + "mandriva", + "mangeia", + "manpages", + "margs", + "markerid", + "martinisoft", + "mashify", + "maxbadpasswords", + "mbrtowc", + "mbtowc", + "mdadm", + "megamorf", + "memcpy", + "memlock", + "memoizes", + "memoizing", + "merb", + "merlinjim", + "metafile", + "metalink", + "michaellihs", + "midddleware", + "middlewares", + "miimon", + "mingw", + "minitest", + "minmax", + "mirrorexpire", + "mirrorlist", + "mirrorlists", + "mixins", + "mixlib", + "mkdir", + "mkgroup", + "mkmf", + "mkswap", + "mktemp", + "mktmpdir", + "mname", + "mntfs", + "mobileconfig", + "modname", + "modprobe", + "monologger", + "motd", + "mountpoint", + "mounttab", + "mpkg", + "msgarbossa", + "msgmax", + "msiexec", + "mswin", + "msys", + "multiline", + "multipackage", + "multiplatform", + "multiresource", + "multitenant", + "multithreaded", + "multivalue", + "munge", + "myapp", + "mycert", + "mycook", + "mycorp", + "mydirectory", + "myecrequest", + "myfail", + "myfile", + "mygem", + "myname", + "myorg", + "myprop", + "myrecipe", + "myrsarequest", + "myserver", + "myshare", + "mysignedcert", + "mything", + "mytoken", + "myuser", + "myworkgroup", + "nameservers", + "namespacing", + "nano", + "nathwill", + "ncurses", + "netaddr", + "netapi", + "netbsd", + "netdom", + "netmask", + "netmsg", + "netpbm", + "nevra", + "nevras", + "newcron", + "newfile", + "newguard", + "newpkg", + "newval", + "nexentacore", + "nillable", + "nlist", + "nmcspadden", + "noarch", + "noauth", + "noauto", + "nobrowse", + "noconfirm", + "nodename", + "nodoc", + "nodocument", + "noexec", + "nofile", + "noforce", + "nogpgcheck", + "nokeys", + "nokogiri", + "nologo", + "noninteractive", + "nopasswd", + "noprofile", + "noprogressbar", + "norestart", + "nospace", + "nospinner", + "notapplicable", + "notauser", + "notconfigured", + "notdoingit", + "notfound", + "notlike", + "noverify", + "nproc", + "nread", + "nscd", + "nsis", + "ntpd", + "nupkg", + "nyan", + "objfs", + "objs", + "ohai", + "oldguard", + "oldpackage", + "oldval", + "omnios", + "omry", + "onboot", + "oneshot", + "onidle", + "onlogon", + "onparent", + "onstart", + "openbsd", + "openid", + "openindiana", + "opensolaris", + "openssh", + "openssl", + "openstack", + "opensuse", + "opensuseleap", + "openvpn", + "openvz", + "opscode", + "optstr", + "oracledb", + "orgname", + "orgs", + "otherfiles", + "outform", + "outpipe", + "outputpath", + "packageinfo", + "pacman", + "pagefiles", + "pagefileset", + "paludis", + "parms", + "passstr", + "passw", + "passwd", + "passwordage", + "passwordless", + "pathed", + "pathnames", + "paulmooring", + "pbkdf", + "pcch", + "performant", + "phabricator", + "pidfiles", + "pidora", + "pixdrift", + "pkgadd", + "pkgin", + "pkginfo", + "pkginfos", + "pkgng", + "pkgrm", + "pkgs", + "pkgutil", + "pkgutils", + "plist", + "plistbuddy", + "plists", + "plutil", + "policyfile", + "popen", + "portageq", + "powerpc", + "ppid", + "ppmd", + "prco", + "precreated", + "prefixlen", + "prefmaxlen", + "prefname", + "preinstall", + "prepend", + "prepended", + "prepender", + "preprod", + "prereqs", + "preseed", + "preseeding", + "primarygroupid", + "privatekey", + "procs", + "progname", + "projectdir", + "proxified", + "proxifier", + "psapi", + "pschaumburg", + "psobject", + "psrepository", + "pswd", + "pubkey", + "pubkeys", + "pubout", + "putc", + "pwdp", + "pwent", + "qstr", + "queryformat", + "questionmark", + "quickconfig", + "qword", + "rakelib", + "ramereth", + "raspbian", + "rassoc", + "rbag", + "rbconfig", + "rbenv", + "rcscript", + "rcvar", + "rdoc", + "readline", + "readlines", + "readlink", + "realloc", + "realname", + "realpath", + "rebooter", + "rebootnow", + "rebuilddb", + "reconfig", + "recursing", + "redhat", + "redhatrcd", + "redirections", + "redownloading", + "reenable", + "reenabled", + "reenabling", + "refcount", + "regen", + "regexes", + "reimplement", + "reimplementing", + "reindexing", + "remoteaccess", + "remoteip", + "remoteport", + "remotesigned", + "removelock", + "removerepo", + "renewall", + "reparses", + "reparsing", + "repocontrols", + "repodata", + "repoid", + "repolist", + "repomd", + "repos", + "repositoryid", + "requiretty", + "reregister", + "reregistered", + "resolv", + "resourcelist", + "restarter", + "restorecon", + "resumehandle", + "retriable", + "rhash", + "rhel", + "rhosts", + "rhscl", + "rhsm", + "rindex", + "rjust", + "rmatch", + "rmdir", + "rmgroup", + "rmtree", + "rname", + "robuye", + "roundrobin", + "rpartition", + "rpmdb", + "rpmdep", + "rpmds", + "rpms", + "rpmvercmp", + "rquery", + "rsakey", + "rspec", + "rstrip", + "rsync", + "rsyslog", + "rtprio", + "rubocop", + "rubygem", + "rubyinstaller", + "rubyzip", + "runas", + "rundeck", + "runid", + "runlevel", + "runlevels", + "runlist", + "runlock", + "runpid", + "runrun", + "runtimes", + "rxhash", + "rxvlan", + "sacl", + "safematix", + "salzig", + "samus", + "savetime", + "sawanoboly", + "sbin", + "schtask", + "schtasks", + "scopeid", + "screenrc", + "scutil", + "secedit", + "secoption", + "secp", + "securerandom", + "secvalue", + "selinux", + "selinuxenabled", + "serializable", + "servermanagercmd", + "servername", + "setenv", + "setlocal", + "setobj", + "setprop", + "setsid", + "settimezone", + "setuid", + "sftp", + "sharefs", + "shellcmd", + "shellescape", + "shelljoin", + "shellout", + "shellsplit", + "shmem", + "shoekstra", + "shortcode", + "shortname", + "showhold", + "showpkg", + "sideload", + "sidorenko", + "sigar", + "signedheaderauth", + "signoff", + "simplejson", + "singal", + "singleline", + "skipkeys", + "skippyj", + "skus", + "sles", + "smartos", + "smbfs", + "smbshare", + "smtp", + "snapctl", + "snapd", + "snmp", + "socketless", + "softlayer", + "softwareupdate", + "solv", + "somedir", + "somefile", + "someotherfile", + "someuser", + "sourceline", + "sparc", + "spawninstance", + "specdoc", + "sprintf", + "srand", + "srcs", + "sshd", + "sshock", + "sslcacert", + "sslclientcert", + "sslclientkey", + "sslverify", + "sspi", + "sssd", + "stacktraces", + "startname", + "startsrc", + "stdcall", + "stdlib", + "stepable", + "stopsrc", + "strace", + "strftime", + "stringio", + "strptime", + "struct", + "stubabble", + "stubbable", + "subclassable", + "subclassing", + "subcollections", + "subcommand", + "subcommands", + "subcontext", + "subdir", + "subdirs", + "subfeatures", + "subkeys", + "subklass", + "sublicensable", + "submodule", + "submodules", + "subprocesses", + "subrecords", + "subresource", + "subresources", + "subsession", + "subsytem", + "subtrees", + "sudoer", + "sudoers", + "suid", + "svcadm", + "svccfg", + "svcs", + "swapfile", + "swapfiles", + "swapoff", + "swapon", + "swappable", + "swappiness", + "symlink", + "symlinked", + "symlinking", + "symlinks", + "sync", + "syntaxcache", + "sysadminctl", + "sysconf", + "sysconfig", + "sysctl", + "sysctld", + "sysctls", + "syslog", + "sysread", + "systctl", + "systemctl", + "systemd", + "systemdrive", + "systemrestart", + "systemsetup", + "systemshare", + "syswrite", + "taskscheduler", + "tcpdump", + "tdev", + "tecracer", + "tempcron", + "tempdir", + "tempfile", + "tempfiles", + "templating", + "termsig", + "testswapfile", + "testswapfiledir", + "texteditor", + "theinen", + "thumbsup", + "timedatectl", + "timh", + "timtest", + "tmap", + "tmpdir", + "tmpfs", + "tmpname", + "tmux", + "tomdoherty", + "toolchain", + "toplevel", + "totalentries", + "traceback", + "traceroute", + "trainwreck", + "triaging", + "tuid", + "tvfs", + "txqueuelen", + "txvlan", + "typecode", + "tzdata", + "tzutil", + "ucanhaz", + "uchar", + "udiff", + "uids", + "uint", + "ulimit", + "ulong", + "umask", + "umount", + "uname", + "unattend", + "uncask", + "uncategorized", + "uncommented", + "uncompress", + "unencrypted", + "unescaping", + "unforked", + "unformatter", + "unhold", + "unignored", + "uninst", + "unintuitive", + "unixy", + "unmanaged", + "unmerge", + "unmergeables", + "unmount", + "unmounting", + "unredacted", + "unregister", + "unregistering", + "unscoped", + "unscrubbed", + "unsecure", + "unshift", + "untag", + "untaint", + "untampered", + "untap", + "untar", + "untracked", + "untrusted", + "unversioned", + "upcase", + "uploader", + "uploaders", + "upsert", + "upto", + "urllib", + "urlopen", + "usag", + "usags", + "useb", + "usebackq", + "usecount", + "usename", + "useradd", + "userdefaults", + "userdel", + "userinfo", + "usermod", + "ushort", + "usri", + "ustring", + "utime", + "uuid", + "uuidgen", + "uuidtools", + "vagrantup", + "valclient", + "varargs", + "variablevalue", + "vbox", + "vboxsf", + "vcenter", + "vendored", + "versio", + "versioncompare", + "versionlock", + "vfstab", + "vgroot", + "viewkind", + "vincentaubert", + "virt", + "virtualbox", + "visudo", + "vkhatri", + "vlan", + "vmware", + "voidcmd", + "vxfs", + "waitfor", + "waitpid", + "waitsem", + "wakeup", + "waym", + "wchars", + "webhook", + "webrick", + "webserver", + "webui", + "westus", + "whatavailable", + "whateverd", + "whatif", + "whatinstalled", + "whatprovides", + "whereis", + "whoami", + "whyrun", + "winbase", + "windef", + "windir", + "windmc", + "windres", + "winerror", + "winevt", + "winmgmts", + "winnt", + "winprog", + "winrm", + "wmic", + "woot", + "wordpress", + "workdir", + "workgroup", + "wrlinux", + "wstring", + "wtime", + "xabcz", + "xargs", + "xattr", + "xchar", + "xdigit", + "xenial", + "xinetd", + "xproto", + "yajl", + "yardoc", + "yieldparam", + "yocto", + "yolo", + "zanecodes", + "zenoss", + "zeproc", + "zmscwx", + "zolo", + "zoneinfo", + "zypp", + "zypper", + "Ásgeirsson" + ], + // flagWords - list of words to be always considered incorrect + // This is useful for offensive words and common spelling errors. + // For example "hte" should be "the" + "flagWords": [ + "hte" + ], + "ignorePaths": [ + "CHANGELOG.md", + "CLA_ARCHIVE.md", + "**/*.gemspec", + "**/Gemfile.lock", + "**/Gemfile", + ".expeditor/**/*", + "**/*.yml", + "**/*.toml", + "**/Berksfile", + "spec/data/**/*", + "lib/chef/provider/package/yum/simplejson/**/*", + "lib/chef/provider/package/yum/simplejson/*", + "omnibus/resources/chef/**/*", + "kitchen-tests/cookbooks/end_to_end/files/*", + "spec/**" + ], + "ignoreRegExpList": [ + // Ignore "'s" at the end of a word. If "Chef" is an accepted word, so is "Chef's". + "/'s\\b/", + // Ignore "'d" at the end of a word. If "dup" is an accepted word, so is "dup'd". + "/'d\\b/" + ] +} diff --git a/distro/templates/powershell/chef/chef.psm1.erb b/distro/templates/powershell/chef/chef.psm1.erb index 652dec04f6..f8b24dc54b 100644 --- a/distro/templates/powershell/chef/chef.psm1.erb +++ b/distro/templates/powershell/chef/chef.psm1.erb @@ -358,7 +358,7 @@ function Run-RubyCommand($command, $argList) { # When arguments come into this method, the standard PS rules for interpreting cmdlet arguments # apply. When using & (call operator) and providing an array of arguments, powershell (verified # on PS 4.0 on Windows Server 2012R2) will not evaluate them but (contrary to documentation), - # it will still marginally interpret them. The behaviour of PS 5.0 seems to be different but + # it will still marginally interpret them. The behavior of PS 5.0 seems to be different but # ignore that for now. If any of the provided arguments has a space in it, powershell checks # the first and last character to ensure that they are " characters (and that's all it checks). # If they are not, it will blindly surround that argument with " characters. It won't do this @@ -381,10 +381,10 @@ function Run-RubyCommand($command, $argList) { # Command line: # "C:\Program Files (x86)\PowerShell Community Extensions\Pscx3\Pscx\Apps\EchoArgs.exe" "foo '' bar "baz"" "foo '' bar "baz"" # - # $x = "abc'123'nospace`"lulz`"!!!" + # $x = "abc'123'nospace`"lol`"!!!" # & EchoArgs @($x, $x) # Command line: - # "C:\Program Files (x86)\PowerShell Community Extensions\Pscx3\Pscx\Apps\EchoArgs.exe" abc'123'nospace"lulz"!!! abc'123'nospace"lulz"!!! + # "C:\Program Files (x86)\PowerShell Community Extensions\Pscx3\Pscx\Apps\EchoArgs.exe" abc'123'nospace"lol"!!! abc'123'nospace"lol"!!! # # $x = "`"`"Look ma! Tonnes of spaces! 'foo' 'bar'`"`"" # & EchoArgs @($x, $x) diff --git a/docs/dev/design_documents/action_collection.md b/docs/dev/design_documents/action_collection.md index a0735f65fb..df7dd46a84 100644 --- a/docs/dev/design_documents/action_collection.md +++ b/docs/dev/design_documents/action_collection.md @@ -53,7 +53,7 @@ it is created, so registration may be accomplished easily: If one of the prior methods is not used to register for the Action Collection, then the Action Collection will disable itself and will not compile the Action Collection in order to not waste the memory overhead of tracking the actions during the run. The Data Collector takes advantage of this since if the run start message from the Data Collector is refused by the server, then the Data Collector disables itself, and then does not register -with the Action Collection, which would disable the Action Collection. This makes use of the delayed hooking through the `action_collection_regsitration` +with the Action Collection, which would disable the Action Collection. This makes use of the delayed hooking through the `action_collection_registration` so that the Data Collector never registers itself after it is disabled. ## Searching diff --git a/docs/dev/design_documents/bootstrap_with_train.md b/docs/dev/design_documents/bootstrap_with_train.md index be4fdeb3ec..3a83568d21 100644 --- a/docs/dev/design_documents/bootstrap_with_train.md +++ b/docs/dev/design_documents/bootstrap_with_train.md @@ -8,7 +8,7 @@ Update `knife bootstrap` to use `train` as its backend via `chef-core`, and inte I want to be able to bootstrap a system without logging secure data on that system so that chef-client's keys are not exposed to anyone who can read the logs. - As a Chef User who adminsters Windows nodes, + As a Chef User who administers Windows nodes, I want to be able to bootstrap a system using the core Chef package so that I don't have extra things to download first. @@ -51,7 +51,7 @@ remains largely unchanged. We will also remove the following obsolete or unsupported behaviors: -* `--prelease` flag - Chef hasn't been pre-released in quite some time. +* `--prerelease` flag - Chef hasn't been pre-released in quite some time. * `--install-as-service` - For many years we have suggested users not run chef-client as a service due to memory leaks in long running Ruby processes. * `--kerberos-keytab-file` - this is not implemented in the WinRM gem we use, and so was passed through to no effect. @@ -126,7 +126,7 @@ Tests must ensure that options resolve correctly from the CLI, knife configurati #### Validation -Existing windows bootstrap validation checks should be preserved, unless they are superceded by related +Existing windows bootstrap validation checks should be preserved, unless they are superseded by related validations for ssh bootstrap. #### Context diff --git a/docs/dev/design_documents/data_collector.md b/docs/dev/design_documents/data_collector.md index cb2b0cb406..889306e026 100644 --- a/docs/dev/design_documents/data_collector.md +++ b/docs/dev/design_documents/data_collector.md @@ -190,7 +190,7 @@ The Run Start Schema will be used by Chef to notify the data collection server a "description": "Data Collector - Runs run_start schema", "properties": { "chef_server_fqdn": { - "description": "It is the FQDN of the chef_server against whch current reporting instance runs", + "description": "It is the FQDN of the chef_server against which current reporting instance runs", "type": "string" }, "entity_uuid": { @@ -266,7 +266,7 @@ The Run End Schema will be used by Chef Client to notify the data collection ser "description": "Data Collector - Runs run_converge schema", "properties": { "chef_server_fqdn": { - "description": "It is the FQDN of the chef_server against whch current reporting instance runs", + "description": "It is the FQDN of the chef_server against which current reporting instance runs", "type": "string" }, "end_time": { diff --git a/docs/dev/design_documents/resource_file_content_verification.md b/docs/dev/design_documents/resource_file_content_verification.md index 0ddcfeb439..f813e57c72 100644 --- a/docs/dev/design_documents/resource_file_content_verification.md +++ b/docs/dev/design_documents/resource_file_content_verification.md @@ -20,7 +20,7 @@ disk as appropriate. If the command's return code indicates failure, the provider will raise an error. The path to the temporary file with the proposed content will be -available by using Ruby's sprinf formatting: +available by using Ruby's sprintf formatting: "%{path}" diff --git a/docs/dev/design_documents/resource_guard_interpreters.md b/docs/dev/design_documents/resource_guard_interpreters.md index 7f4c2fb9b6..37db4e761a 100755 --- a/docs/dev/design_documents/resource_guard_interpreters.md +++ b/docs/dev/design_documents/resource_guard_interpreters.md @@ -208,7 +208,7 @@ do # architecture attribute for the parent resource which powershell_script # guard interpreter resources will inherit from the enclosing resource powershell_script "set i386 execution policy" do - guard_interpteter :powershell_script + guard_interpreter :powershell_script architecture :i386 code "set-executionpolicy remotesigned" not_if "(get-executionpolicy -scope localmachine) -eq 'remotesigned'" @@ -439,7 +439,7 @@ CP/M heritage even in 2014, and as Windows admins turned to PowerShell or were nudged toward it (often by Microsoft itself), it was asking a lot for Chef users to know how to use legacy `cmd.exe` to accomplish tasks. Most likely, users of `powershell_script` would choose to run powershell.exe in the `not_if` and `only_if` blocks. Since -that was the common case for `powersell_script` users, the guards should have +that was the common case for `powershell_script` users, the guards should have had some way to allow that, or to provide guard execution via PowerShell in a more natural fashion. diff --git a/docs/dev/how_to/branching_and_backporting.md b/docs/dev/how_to/branching_and_backporting.md index b2b90edb50..8929c926e9 100644 --- a/docs/dev/how_to/branching_and_backporting.md +++ b/docs/dev/how_to/branching_and_backporting.md @@ -2,7 +2,7 @@ ## Branch Structure -We develop and ship the current release of Chef off the master branch of this repository. Our goal is that `master` should always be in a shipable state. Previous stable releases of Chef are developed on their own branches named by the major version (ex: chef-14 or chef-13). We do not perform direct development on these stable branches, except to resolve build failures. Instead, we backport fixes from our master branch to these stable branches. Stable branches receive critical bugfixes and security releases, and stable Chef releases are made as necessary for security purposes. +We develop and ship the current release of Chef off the master branch of this repository. Our goal is that `master` should always be in a shippable state. Previous stable releases of Chef are developed on their own branches named by the major version (ex: chef-14 or chef-13). We do not perform direct development on these stable branches, except to resolve build failures. Instead, we backport fixes from our master branch to these stable branches. Stable branches receive critical bugfixes and security releases, and stable Chef releases are made as necessary for security purposes. ## Backporting Fixes to Stable Releases @@ -12,10 +12,10 @@ If there is a critical fix that you believe should be backported from master to 3. Inspect the Git history and find the `SHA`(s) associated with the fix. 4. Backport the fix to a branch via cherry-pick: 1. Check out the stable release branch: `git checkout chef-14` - 2. Create a branch for your backport: `git checkout -b my_great_bug_packport` + 2. Create a branch for your backport: `git checkout -b my_great_bug_backport` 3. Cherry Pick the SHA with the fix: `git cherry-pick SHA` 4. Address any conflicts (if necessary) 5. Push the new branch to your origin: `git push origin` 5. Open a PR for your backport 1. The PR title should be `Backport: ORIGINAL_PR_TEXT` - 2. The description should link to the original PR and include a description of why it needs to be backported
\ No newline at end of file + 2. The description should link to the original PR and include a description of why it needs to be backported diff --git a/docs/dev/how_to/bumping_the_major_version.md b/docs/dev/how_to/bumping_the_major_version.md index f9db9e525e..17332bf765 100644 --- a/docs/dev/how_to/bumping_the_major_version.md +++ b/docs/dev/how_to/bumping_the_major_version.md @@ -31,7 +31,7 @@ On your local machine fork the current master branch to a new stable branch. For Once you’ve forked to a new stable branch such as `chef-15` you’ll want to create a new branch so you can build a PR, which will get this branch ready for release: -- In ./expeditor/config.yml add the version_constraint for the new branch, update the version_constrant for master to match the new major version, and remove all the update_dep.sh subscriptions which don’t work against stable branches. +- In ./expeditor/config.yml add the version_constraint for the new branch, update the version_constraint for master to match the new major version, and remove all the update_dep.sh subscriptions which don’t work against stable branches. - In readme.md update the buildkite badge to point to the new stable branch image and link instead of pointing to master. - In kitchen-tests/Gemfile update the Ohai branch to point to the new Ohai stable - In kitchen-tests/kitchen.yml update chef_version to be your new stable version and not current. Ex: 15 diff --git a/docs/dev/policy/release_and_support_schedule.md b/docs/dev/policy/release_and_support_schedule.md index 9feb9c0f1d..2f2c378448 100644 --- a/docs/dev/policy/release_and_support_schedule.md +++ b/docs/dev/policy/release_and_support_schedule.md @@ -22,7 +22,7 @@ When incrementing a version, the following conditions will apply: ### Auto-bumping PATCH versions -Chef projects are managed by our Expeditor release tooling application. This application is executed each time a GitHubb Pull Request is merged and incrementwss the patch version of the software before running the change through our internal CI/CD pipeline. As not all builds will make it successfully through the CI/CD pipeline, the versions available for public consumption might have gaps (e.g. 1.2.1, 1.2.10, 1.2.11, 1.2.12, 1.2.20), but all verisons have been built and tested. +Chef projects are managed by our Expeditor release tooling application. This application is executed each time a GitHub Pull Request is merged and increments the patch version of the software before running the change through our internal CI/CD pipeline. As not all builds will make it successfully through the CI/CD pipeline, the versions available for public consumption might have gaps (e.g. 1.2.1, 1.2.10, 1.2.11, 1.2.12, 1.2.20), but all versions have been built and tested. ## Support Schedule diff --git a/kitchen-tests/cookbooks/end_to_end/attributes/default.rb b/kitchen-tests/cookbooks/end_to_end/attributes/default.rb index 027d9881d8..332a3fe462 100644 --- a/kitchen-tests/cookbooks/end_to_end/attributes/default.rb +++ b/kitchen-tests/cookbooks/end_to_end/attributes/default.rb @@ -21,7 +21,7 @@ default["openssh"]["client"]["password_authentication"] = "yes" # turn off kerberos client-side default["openssh"]["client"]["gssapi_authentication"] = "no" default["openssh"]["client"]["check_host_ip"] = "no" -# everone turns strict host key checking off anyway +# everyone turns strict host key checking off anyway default["openssh"]["client"]["strict_host_key_checking"] = "no" # force protocol 2 default["openssh"]["client"]["protocol"] = "2" diff --git a/kitchen-tests/cookbooks/end_to_end/recipes/_tests.rb b/kitchen-tests/cookbooks/end_to_end/recipes/_tests.rb index d74a310394..7f51361693 100644 --- a/kitchen-tests/cookbooks/end_to_end/recipes/_tests.rb +++ b/kitchen-tests/cookbooks/end_to_end/recipes/_tests.rb @@ -16,6 +16,7 @@ end # this caught a regression in 12.14.70 before it was released when i # ran it in lamont-ci, so added the test here so everyone else other than # me gets coverage for this as well. +# cspell:disable-next-line file "/tmp/chef-test-\xFDmlaut" do content "testing illegal UTF-8 char in the filename" end diff --git a/lib/chef/chef_fs/file_system/chef_server/acls_dir.rb b/lib/chef/chef_fs/file_system/chef_server/acls_dir.rb index 3719210534..9bc348482b 100644 --- a/lib/chef/chef_fs/file_system/chef_server/acls_dir.rb +++ b/lib/chef/chef_fs/file_system/chef_server/acls_dir.rb @@ -60,7 +60,7 @@ class Chef AclDir.new(entity_type, self) end end - @children << AclEntry.new("organization.json", self, true) # the org acl is retrieved as GET /organizations/ORGNAME/ANYTHINGATALL/_acl + @children << AclEntry.new("organization.json", self, true) # the org acl is retrieved as GET /organizations/ORGNAME/ANYTHING/_acl end @children end diff --git a/lib/chef/chef_fs/file_system/repository/directory.rb b/lib/chef/chef_fs/file_system/repository/directory.rb index c494d54b21..8d227fd9d2 100644 --- a/lib/chef/chef_fs/file_system/repository/directory.rb +++ b/lib/chef/chef_fs/file_system/repository/directory.rb @@ -104,7 +104,7 @@ class Chef children.empty? end - # Public API callied by chef_fs/file_system + # Public API called by chef_fs/file_system def child(name) possible_child = make_child_entry(name) if possible_child.name_valid? diff --git a/lib/chef/chef_fs/parallelizer/parallel_enumerable.rb b/lib/chef/chef_fs/parallelizer/parallel_enumerable.rb index 1780b56239..08fbcd4a41 100644 --- a/lib/chef/chef_fs/parallelizer/parallel_enumerable.rb +++ b/lib/chef/chef_fs/parallelizer/parallel_enumerable.rb @@ -235,7 +235,7 @@ class Chef # The order of these checks is important, as well, to be thread safe. # 1. If @unconsumed_input.empty? is true, then we will never have any more # work legitimately picked up. - # 2. If @in_process == 0, then there is no work in process, and because ofwhen unconsumed_input is empty, it will never go back up, because + # 2. If @in_process == 0, then there is no work in process, and because of when unconsumed_input is empty, it will never go back up, because # this is called after the input enumerator is finished. Note that switching #2 and #1 # could cause a race, because in_process is incremented *before* consuming input. # 3. If @unconsumed_output.empty? is true, then we are done with outputs. diff --git a/lib/chef/chef_fs/path_utils.rb b/lib/chef/chef_fs/path_utils.rb index b8a83ab09f..31f1f6f12a 100644 --- a/lib/chef/chef_fs/path_utils.rb +++ b/lib/chef/chef_fs/path_utils.rb @@ -71,9 +71,9 @@ class Chef # part that actually exists. The paths operated on here are not Chef-FS paths. # These are OS paths that may contain symlinks but may not also fully exist. # - # If /x is a symlink to /blarghle, and has no subdirectories, then: - # PathUtils.realest_path('/x/y/z') == '/blarghle/y/z' - # PathUtils.realest_path('/x/*/z') == '/blarghle/*/z' + # If /x is a symlink to /foo_bar, and has no subdirectories, then: + # PathUtils.realest_path('/x/y/z') == '/foo_bar/y/z' + # PathUtils.realest_path('/x/*/z') == '/foo_bar/*/z' # PathUtils.realest_path('/*/y/z') == '/*/y/z' # # TODO: Move this to wherever util/path_helper is these days. diff --git a/lib/chef/cookbook/file_system_file_vendor.rb b/lib/chef/cookbook/file_system_file_vendor.rb index 9cf3593838..a4a6711270 100644 --- a/lib/chef/cookbook/file_system_file_vendor.rb +++ b/lib/chef/cookbook/file_system_file_vendor.rb @@ -27,7 +27,7 @@ class Chef # and throws the rest away then re-builds the list of files on the # disk. This is due to the manifest not having the on-disk file # locations, since in the chef-client case, that information is - # non-sensical. + # nonsensical. class FileSystemFileVendor < FileVendor attr_reader :cookbook_name diff --git a/lib/chef/cookbook/metadata.rb b/lib/chef/cookbook/metadata.rb index ef0b920b5f..c1393abcab 100644 --- a/lib/chef/cookbook/metadata.rb +++ b/lib/chef/cookbook/metadata.rb @@ -357,7 +357,7 @@ class Chef # Array<String> - array of files or globs to eagerly load, otherwise it is treated like `false` # # @params arg [Array,String,TrueClass,FalseClass] - # @params [Array,TrueClass,FalseCalss] + # @params [Array,TrueClass,FalseClass] def eager_load_libraries(arg = nil) set_or_return( :eager_load_libraries, diff --git a/lib/chef/cookbook_loader.rb b/lib/chef/cookbook_loader.rb index 1ee447c51f..e6e6a4805d 100644 --- a/lib/chef/cookbook_loader.rb +++ b/lib/chef/cookbook_loader.rb @@ -138,7 +138,7 @@ class Chef cookbooks_by_name.values end - # This method creates tmp directory and copies all cookbooks into it and creates cookbook loder object which points to tmp directory + # This method creates tmp directory and copies all cookbooks into it and creates cookbook loader object which points to tmp directory def self.copy_to_tmp_dir_from_array(cookbooks) tmp_cookbook_file = Tempfile.new("tmp_working_dir_path") tmp_cookbook_file.close diff --git a/lib/chef/cookbook_manifest.rb b/lib/chef/cookbook_manifest.rb index 3b45da121a..765133b49a 100644 --- a/lib/chef/cookbook_manifest.rb +++ b/lib/chef/cookbook_manifest.rb @@ -44,7 +44,7 @@ class Chef # cookbook_version in the "manifest" format, or #to_json to get a JSON # representation of the cookbook_version. # - # The inferface for this behavior is expected to change as we implement new + # The interface for this behavior is expected to change as we implement new # manifest formats. The entire class should be considered a private API for # now. # diff --git a/lib/chef/cookbook_site_streaming_uploader.rb b/lib/chef/cookbook_site_streaming_uploader.rb index e719be8de6..1598808234 100644 --- a/lib/chef/cookbook_site_streaming_uploader.rb +++ b/lib/chef/cookbook_site_streaming_uploader.rb @@ -147,7 +147,7 @@ class Chef class << res alias :to_s :body - # BUGBUG this makes the response compatible with what respsonse_steps expects to test headers (response.headers[] -> response[]) + # BUG this makes the response compatible with what response_steps expects to test headers (response.headers[] -> response[]) def headers # rubocop:disable Lint/NestedMethodDefinition self end diff --git a/lib/chef/cookbook_version.rb b/lib/chef/cookbook_version.rb index 12adb50b4c..2e9bb77151 100644 --- a/lib/chef/cookbook_version.rb +++ b/lib/chef/cookbook_version.rb @@ -358,7 +358,7 @@ class Chef # extract the preference part from the path. if manifest_record_path =~ %r{(#{Regexp.escape(segment.to_s)}/[^/]+/#{Regexp.escape(dirname)})/.+$} - # Note the specificy_dirname includes the segment and + # Note the specificity_dirname includes the segment and # dirname argument as above, which is what # preferences_for_path returns. It could be # "files/ubuntu-9.10/dirname", for example. @@ -566,7 +566,7 @@ class Chef def find_preferred_manifest_record(node, segment, filename) preferences = preferences_for_path(node, segment, filename) - # in order of prefernce, look for the filename in the manifest + # in order of preference, look for the filename in the manifest preferences.find { |preferred_filename| manifest_records_by_path[preferred_filename] } end diff --git a/lib/chef/data_collector.rb b/lib/chef/data_collector.rb index e0145b177d..6c7b2edb56 100644 --- a/lib/chef/data_collector.rb +++ b/lib/chef/data_collector.rb @@ -184,7 +184,7 @@ class Chef begin code = e&.response&.code&.to_s rescue - # i really dont care + # i really don't care end code ||= "No HTTP Code" diff --git a/lib/chef/data_collector/error_handlers.rb b/lib/chef/data_collector/error_handlers.rb index 36252149a2..5cda3bde10 100644 --- a/lib/chef/data_collector/error_handlers.rb +++ b/lib/chef/data_collector/error_handlers.rb @@ -18,7 +18,7 @@ class Chef class DataCollector - # This module isolates the handling of collecting error descriptions to insert into the data_colletor + # This module isolates the handling of collecting error descriptions to insert into the data_collector # report output. For very early errors it is responsible for collecting the node_name for the report # to use. For all failure conditions that have an ErrorMapper it collects the output. # diff --git a/lib/chef/decorator/lazy_array.rb b/lib/chef/decorator/lazy_array.rb index 7e3177c713..9859c49d77 100644 --- a/lib/chef/decorator/lazy_array.rb +++ b/lib/chef/decorator/lazy_array.rb @@ -21,8 +21,8 @@ class Chef class Decorator # Lazy Array around Lazy Objects # - # This only lazys access through `#[]`. In order to implement #each we need to - # know how many items we have and what their indexes are, so we'd have to evalute + # This makes access lazy through `#[]`. In order to implement #each we need to + # know how many items we have and what their indexes are, so we'd have to evaluate # the proc which makes that impossible. You can call methods like #each and the # decorator will forward the method, but item access will not be lazy. # diff --git a/lib/chef/dsl/declare_resource.rb b/lib/chef/dsl/declare_resource.rb index 02ad64c77a..8053098085 100644 --- a/lib/chef/dsl/declare_resource.rb +++ b/lib/chef/dsl/declare_resource.rb @@ -151,7 +151,7 @@ class Chef # source "y.txt.erb" # variables {} # end - # resource.variables.merge!({ home: "/home/klowns" }) + # resource.variables.merge!({ home: "/home/clowns" }) # def edit_resource(type, name, created_at: nil, run_context: self.run_context, &resource_attrs_block) edit_resource!(type, name, created_at: created_at, run_context: run_context, &resource_attrs_block) diff --git a/lib/chef/formatters/base.rb b/lib/chef/formatters/base.rb index 3e2c3cc6b0..2471cfe844 100644 --- a/lib/chef/formatters/base.rb +++ b/lib/chef/formatters/base.rb @@ -142,7 +142,7 @@ class Chef # Generic callback for any attribute/library/lwrp/recipe file in a # cookbook getting loaded. The per-filetype callbacks for file load are - # overriden so that they call this instead. This means that a subclass of + # overridden so that they call this instead. This means that a subclass of # Formatters::Base can implement #file_loaded to do the same thing for # every kind of file that Chef loads from a recipe instead of # implementing all the per-filetype callbacks. diff --git a/lib/chef/http.rb b/lib/chef/http.rb index 80db24fa3b..d31d4d3027 100644 --- a/lib/chef/http.rb +++ b/lib/chef/http.rb @@ -269,7 +269,7 @@ class Chef if keepalives && !base_url.nil? # only reuse the http_client if we want keepalives and have a base_url @http_client ||= {} - # the per-host per-port cache here gets peristent connections correct when + # the per-host per-port cache here gets persistent connections correct when # redirecting to different servers if base_url.is_a?(String) # sigh, this kind of abuse can't happen with strongly typed languages @http_client[base_url] ||= build_http_client(base_url) diff --git a/lib/chef/http/decompressor.rb b/lib/chef/http/decompressor.rb index abe801b654..36329ee63e 100644 --- a/lib/chef/http/decompressor.rb +++ b/lib/chef/http/decompressor.rb @@ -22,7 +22,7 @@ require_relative "http_request" class Chef class HTTP - # Middleware-esque class for handling compression in HTTP responses. + # Middleware-ish class for handling compression in HTTP responses. class Decompressor class NoopInflater def inflate(chunk) diff --git a/lib/chef/json_compat.rb b/lib/chef/json_compat.rb index 120af43d6e..79ed3f1ba2 100644 --- a/lib/chef/json_compat.rb +++ b/lib/chef/json_compat.rb @@ -28,7 +28,7 @@ class Chef class <<self - # API to use to avoid create_addtions + # API to use to avoid create_additions def parse(source, opts = {}) FFI_Yajl::Parser.parse(source, opts) rescue FFI_Yajl::ParseError => e diff --git a/lib/chef/knife.rb b/lib/chef/knife.rb index bdab024579..2531059d37 100644 --- a/lib/chef/knife.rb +++ b/lib/chef/knife.rb @@ -327,7 +327,7 @@ class Chef end # Grab a copy before config merge occurs, so that we can later identify - # whare a given config value is sourced from. + # where a given config value is sourced from. @original_config = config.dup # copy Mixlib::CLI over so that it can be configured in config.rb/knife.rb diff --git a/lib/chef/knife/bootstrap.rb b/lib/chef/knife/bootstrap.rb index f9c3b7bb81..6e0f86240d 100644 --- a/lib/chef/knife/bootstrap.rb +++ b/lib/chef/knife/bootstrap.rb @@ -94,7 +94,7 @@ class Chef boolean: true # This option was provided in knife bootstrap windows winrm, - # but it is ignored in knife-windows/WinrmSession, and so remains unimplemeneted here. + # but it is ignored in knife-windows/WinrmSession, and so remains unimplemented here. # option :kerberos_keytab_file, # :short => "-T KEYTAB_FILE", # :long => "--keytab-file KEYTAB_FILE", @@ -275,7 +275,7 @@ class Chef accumulator } - # bootstrap override: url of a an installer shell script touse in place of omnitruck + # bootstrap override: url of a an installer shell script to use in place of omnitruck # Note that the bootstrap template _only_ references this out of Chef::Config, and not from # the provided options to knife bootstrap, so we set the Chef::Config option here. option :bootstrap_url, @@ -713,7 +713,7 @@ class Chef # Fail if using plaintext auth without ssl because # this can expose keys in plaintext on the wire. # TODO test for this method - # TODO check that the protoocol is valid. + # TODO check that the protocol is valid. def validate_winrm_transport_opts! return true unless winrm? @@ -967,7 +967,7 @@ class Chef gw_host = split[1] end gw_host, gw_port = gw_host.split(":", 2) - # TODO - validate convertable port in config validation? + # TODO - validate convertible port in config validation? gw_port = Integer(gw_port) rescue nil opts[:bastion_host] = gw_host opts[:bastion_user] = gw_user @@ -1073,7 +1073,7 @@ class Chef remote_path end - # build the command string for bootrapping + # build the command string for bootstrapping # @return String def bootstrap_command(remote_path) if connection.windows? diff --git a/lib/chef/knife/bootstrap/chef_vault_handler.rb b/lib/chef/knife/bootstrap/chef_vault_handler.rb index 00f902d728..b36c178d8e 100644 --- a/lib/chef/knife/bootstrap/chef_vault_handler.rb +++ b/lib/chef/knife/bootstrap/chef_vault_handler.rb @@ -102,7 +102,7 @@ class Chef config[:bootstrap_vault_item] end - # Helper to return a ruby object represeting all the data bags and items + # Helper to return a ruby object representing all the data bags and items # to update via chef-vault. # # @return [Hash] deserialized ruby hash with all the vault items diff --git a/lib/chef/knife/bootstrap/client_builder.rb b/lib/chef/knife/bootstrap/client_builder.rb index b2c07e8019..d9c3d83d06 100644 --- a/lib/chef/knife/bootstrap/client_builder.rb +++ b/lib/chef/knife/bootstrap/client_builder.rb @@ -86,7 +86,7 @@ class Chef config[:chef_node_name] end - # @return [String] enviroment from the config + # @return [String] environment from the config def environment config[:environment] end diff --git a/lib/chef/knife/core/hashed_command_loader.rb b/lib/chef/knife/core/hashed_command_loader.rb index c76a596dde..d31865affc 100644 --- a/lib/chef/knife/core/hashed_command_loader.rb +++ b/lib/chef/knife/core/hashed_command_loader.rb @@ -44,7 +44,7 @@ class Chef else commands = manifest[KEY]["plugins_by_category"] end - # If any of the specified plugins in the manifest dont have a valid path we will + # If any of the specified plugins in the manifest don't have a valid path we will # eventually get an error and the user will need to rehash - instead, lets just # print out 1 error here telling them to rehash errors = {} diff --git a/lib/chef/knife/core/node_presenter.rb b/lib/chef/knife/core/node_presenter.rb index 14433f8353..6690bc1075 100644 --- a/lib/chef/knife/core/node_presenter.rb +++ b/lib/chef/knife/core/node_presenter.rb @@ -94,7 +94,7 @@ class Chef def summarize(data) if data.is_a?(Chef::Node) node = data - # special case clouds with their split horizon whatsis. + # special case clouds with their split horizon thing. ip = (node[:cloud] && node[:cloud][:public_ipv4_addrs] && node[:cloud][:public_ipv4_addrs].first) || node[:ipaddress] summarized = <<~SUMMARY diff --git a/lib/chef/knife/core/status_presenter.rb b/lib/chef/knife/core/status_presenter.rb index c8b3a23636..9a4ea76508 100644 --- a/lib/chef/knife/core/status_presenter.rb +++ b/lib/chef/knife/core/status_presenter.rb @@ -95,7 +95,7 @@ class Chef summarized = "" list.each do |data| node = data - # special case clouds with their split horizon whatsis. + # special case clouds with their split horizon thing. ip = (node[:cloud] && node[:cloud][:public_ipv4_addrs] && node[:cloud][:public_ipv4_addrs].first) || node[:ipaddress] fqdn = (node[:cloud] && node[:cloud][:public_hostname]) || node[:fqdn] name = node["name"] || node.name diff --git a/lib/chef/knife/core/subcommand_loader.rb b/lib/chef/knife/core/subcommand_loader.rb index e941b10d47..dd363b6634 100644 --- a/lib/chef/knife/core/subcommand_loader.rb +++ b/lib/chef/knife/core/subcommand_loader.rb @@ -32,7 +32,7 @@ class Chef # optionally filtering by category # subcommand_files - returns an array of all subcommand files # that could be loaded - # commnad_class_from(args) - returns the subcommand class for the + # command_class_from(args) - returns the subcommand class for the # user-requested command # class SubcommandLoader diff --git a/lib/chef/knife/core/windows_bootstrap_context.rb b/lib/chef/knife/core/windows_bootstrap_context.rb index 2ef9f16499..d2b9bc5636 100644 --- a/lib/chef/knife/core/windows_bootstrap_context.rb +++ b/lib/chef/knife/core/windows_bootstrap_context.rb @@ -24,7 +24,7 @@ class Chef class Knife module Core # Instances of BootstrapContext are the context objects (i.e., +self+) for - # bootstrap templates. For backwards compatability, they +must+ set the + # bootstrap templates. For backwards compatibility, they +must+ set the # following instance variables: # * @config - a hash of knife's config values # * @run_list - the run list for the node to boostrap diff --git a/lib/chef/knife/key_create_base.rb b/lib/chef/knife/key_create_base.rb index a856a07867..a1d658e43c 100644 --- a/lib/chef/knife/key_create_base.rb +++ b/lib/chef/knife/key_create_base.rb @@ -42,7 +42,7 @@ class Chef option :expiration_date, short: "-e DATE", long: "--expiration-date DATE", - description: "Optionally pass the expiration date for the key in ISO 8601 fomatted string: YYYY-MM-DDTHH:MM:SSZ e.g. 2013-12-24T21:00:00Z. Defaults to infinity if not passed. UTC timezone assumed." + description: "Optionally pass the expiration date for the key in ISO 8601 formatted string: YYYY-MM-DDTHH:MM:SSZ e.g. 2013-12-24T21:00:00Z. Defaults to infinity if not passed. UTC timezone assumed." end end end diff --git a/lib/chef/knife/key_edit_base.rb b/lib/chef/knife/key_edit_base.rb index b5f38b5c56..b094877190 100644 --- a/lib/chef/knife/key_edit_base.rb +++ b/lib/chef/knife/key_edit_base.rb @@ -47,7 +47,7 @@ class Chef option :expiration_date, short: "-e DATE", long: "--expiration-date DATE", - description: "Updates the expiration_date field of your key if passed. Pass in ISO 8601 fomatted string: YYYY-MM-DDTHH:MM:SSZ e.g. 2013-12-24T21:00:00Z or infinity. UTC timezone assumed." + description: "Updates the expiration_date field of your key if passed. Pass in ISO 8601 formatted string: YYYY-MM-DDTHH:MM:SSZ e.g. 2013-12-24T21:00:00Z or infinity. UTC timezone assumed." end end end diff --git a/lib/chef/knife/ssh.rb b/lib/chef/knife/ssh.rb index 837ba780f5..ea40cee191 100644 --- a/lib/chef/knife/ssh.rb +++ b/lib/chef/knife/ssh.rb @@ -59,7 +59,7 @@ class Chef option :prefix_attribute, long: "--prefix-attribute ATTR", - description: "The attribute to use for prefixing the ouput - default depends on the context." + description: "The attribute to use for prefixing the output - default depends on the context." option :ssh_user, short: "-x USERNAME", diff --git a/lib/chef/mixin/api_version_request_handling.rb b/lib/chef/mixin/api_version_request_handling.rb index 2c6d2aa6da..a46e001dd8 100644 --- a/lib/chef/mixin/api_version_request_handling.rb +++ b/lib/chef/mixin/api_version_request_handling.rb @@ -53,7 +53,7 @@ class Chef <<~EOH The reregister command only supports server API version 0. The server that received the request supports a min version of #{min_version} and a max version of #{max_version}. - User keys are now managed via the key rotation commmands. + User keys are now managed via the key rotation commands. Please refer to the documentation on how to manage your keys via the key rotation commands: https://docs.chef.io/ctl_chef_server/#key-rotation EOH diff --git a/lib/chef/mixin/properties.rb b/lib/chef/mixin/properties.rb index b0bccaac87..eca0787dc4 100644 --- a/lib/chef/mixin/properties.rb +++ b/lib/chef/mixin/properties.rb @@ -264,7 +264,7 @@ class Chef end result = properties.values.select(&:identity?) - # if there are no other identity properites set, then the name_property becomes the identity, or + # if there are no other identity properties set, then the name_property becomes the identity, or # failing that we use the actual name. if result.empty? result = name_property ? [ properties[name_property] ] : [ properties[:name] ] @@ -355,7 +355,7 @@ class Chef # # @param other [Object] the other object (Chef::Resource) which implements the properties API # @param includes [Array<Symbol>] splat-args list of symbols of the properties to copy. - # @param exclude [Array<Symbol>] list of symbosl of the properties to exclude. + # @param exclude [Array<Symbol>] list of symbols of the properties to exclude. # @return the self object the properties were copied to for method chaining # def copy_properties_from(other, *includes, exclude: [ :name ]) diff --git a/lib/chef/mixin/shell_out.rb b/lib/chef/mixin/shell_out.rb index 1331d48c59..62916b06de 100644 --- a/lib/chef/mixin/shell_out.rb +++ b/lib/chef/mixin/shell_out.rb @@ -71,7 +71,7 @@ class Chef default_val = 900 return options if options.key?(:timeout) - # FIXME: need to nuke descendents tracker out of Chef::Provider so we can just define that class here without requiring the + # FIXME: need to nuke descendent tracker out of Chef::Provider so we can just define that class here without requiring the # world, and then just use symbol lookup if obj.class.ancestors.map(&:name).include?("Chef::Provider") && obj.respond_to?(:new_resource) && obj.new_resource.respond_to?(:timeout) && !options.key?(:timeout) options[:timeout] = obj.new_resource.timeout ? obj.new_resource.timeout.to_f : default_val diff --git a/lib/chef/node/attribute.rb b/lib/chef/node/attribute.rb index 72556e1bc4..e9a48d8b0e 100644 --- a/lib/chef/node/attribute.rb +++ b/lib/chef/node/attribute.rb @@ -184,7 +184,7 @@ class Chef # return the role level override attribute component attr_reader :role_override - # return the enviroment level override attribute component + # return the environment level override attribute component attr_reader :env_override # return the force override level attribute component @@ -535,7 +535,7 @@ class Chef e end - # Deep merge all attribute levels using hash-only merging between different precidence + # Deep merge all attribute levels using hash-only merging between different precedence # levels (so override arrays completely replace arrays set at any default level). # # The path allows for selectively deep-merging a subtree of the node object. diff --git a/lib/chef/node/immutable_collections.rb b/lib/chef/node/immutable_collections.rb index d1d0596287..49dc0256b9 100644 --- a/lib/chef/node/immutable_collections.rb +++ b/lib/chef/node/immutable_collections.rb @@ -120,7 +120,7 @@ class Chef # ImmutableMash acts like a Mash (Hash that is indifferent to String or # Symbol keys), with some important exceptions: # * Methods that mutate state are overridden to raise an error instead. - # * Methods that read from the collection are overriden so that they check + # * Methods that read from the collection are overridden so that they check # if the Chef::Node::Attribute has been modified since an instance of # this class was generated. An error is raised if the object detects that # it is stale. diff --git a/lib/chef/policy_builder/policyfile.rb b/lib/chef/policy_builder/policyfile.rb index 4a626a1cb7..0055f9d4b6 100644 --- a/lib/chef/policy_builder/policyfile.rb +++ b/lib/chef/policy_builder/policyfile.rb @@ -328,7 +328,7 @@ class Chef end end - # Do some mimimal validation of the policyfile we fetched from the + # Do some minimal validation of the policyfile we fetched from the # server. Compatibility mode relies on using data bags to store policy # files; therefore no real validation will be performed server-side and # we need to make additional checks to ensure the data will be formatted diff --git a/lib/chef/property.rb b/lib/chef/property.rb index d65545c138..720fa70dd1 100644 --- a/lib/chef/property.rb +++ b/lib/chef/property.rb @@ -574,7 +574,7 @@ class Chef # be using the existing getter/setter to manipulate it instead. return unless instance_variable_name - # Properties may override existing properties up the inheritance heirarchy, but + # Properties may override existing properties up the inheritance hierarchy, but # properties must not override inherited methods like Object#hash. When the Resource is # placed into the resource collection the ruby Hash object will call the # Object#hash method on the resource, and overriding that with a property will cause @@ -702,7 +702,7 @@ class Chef # override their own properties. return false unless [ Object, BasicObject, Kernel, Chef::Resource ].include?(declared_in.instance_method(name).owner) - # Allow top-level Chef::Resource proprties, such as `name`, to be overridden. + # Allow top-level Chef::Resource properties, such as `name`, to be overridden. # As of this writing, `name` is the only Chef::Resource property created with the # `property` definition, but this will allow for future properties to be extended # as needed. diff --git a/lib/chef/provider.rb b/lib/chef/provider.rb index 947a890806..3607b24752 100644 --- a/lib/chef/provider.rb +++ b/lib/chef/provider.rb @@ -152,7 +152,7 @@ class Chef new_resource.cookbook_name end - # hook that subclasses can use to do lazy validation for where properties aren't flexibile enough + # hook that subclasses can use to do lazy validation for where properties aren't flexible enough def check_resource_semantics!; end # a simple placeholder method that will be called / raise if a resource tries to @@ -167,7 +167,7 @@ class Chef def load_after_resource # This is a backwards compatible hack, custom resources properly wire up a new after_resource - # via load_current_value. It is acceptible for old style resources that cannot be easily made + # via load_current_value. It is acceptable for old style resources that cannot be easily made # into custom resources to override this method and provide a proper after_resource. @after_resource = @new_resource end @@ -190,7 +190,7 @@ class Chef def run_action(action = nil) @action = action unless action.nil? - # hook that subclasses can use to do lazy validation for where properties aren't flexibile enough + # hook that subclasses can use to do lazy validation for where properties aren't flexible enough check_resource_semantics! # force the validation of required properties diff --git a/lib/chef/provider/directory.rb b/lib/chef/provider/directory.rb index d031ab567c..555340d91e 100644 --- a/lib/chef/provider/directory.rb +++ b/lib/chef/provider/directory.rb @@ -142,7 +142,7 @@ class Chef converge_by("delete existing directory #{new_resource.path}") do if new_resource.recursive == true # we don't use rm_rf here because it masks all errors, including - # IO errors or permission errors that would prvent the deletion + # IO errors or permission errors that would prevent the deletion FileUtils.rm_r(new_resource.path) logger.info("#{new_resource} deleted #{new_resource.path} recursively") else diff --git a/lib/chef/provider/package/chocolatey.rb b/lib/chef/provider/package/chocolatey.rb index f1f2307f5b..498a98f2d0 100644 --- a/lib/chef/provider/package/chocolatey.rb +++ b/lib/chef/provider/package/chocolatey.rb @@ -249,7 +249,7 @@ class Chef end # Helper to convert choco.exe list output to a Hash - # (names are downcased for case-insenstive matching) + # (names are downcased for case-insensitive matching) # # @param cmd [String] command to run # @return [Hash] list output converted to ruby Hash diff --git a/lib/chef/provider/package/dpkg.rb b/lib/chef/provider/package/dpkg.rb index e6012edee8..08829e9b26 100644 --- a/lib/chef/provider/package/dpkg.rb +++ b/lib/chef/provider/package/dpkg.rb @@ -149,7 +149,7 @@ class Chef resolved_source_array.all? { |s| s && ::File.exist?(s) } end - # Helper to return all the nanes of the missing sources for error messages. + # Helper to return all the names of the missing sources for error messages. # # @return [Array<String>] Array of missing sources def missing_sources diff --git a/lib/chef/provider/package/portage.rb b/lib/chef/provider/package/portage.rb index 12bc33698e..002c1f96d4 100644 --- a/lib/chef/provider/package/portage.rb +++ b/lib/chef/provider/package/portage.rb @@ -70,6 +70,7 @@ class Chef if pkginfo.exitstatus != 0 pkginfo.stderr.each_line do |line| + # cspell:disable-next-line if line =~ /[Uu]nqualified atom .*match.* multiple/ raise_error_for_query("matched multiple packages (please specify a category):\n#{pkginfo.inspect}") end diff --git a/lib/chef/provider/package/rubygems.rb b/lib/chef/provider/package/rubygems.rb index 03d2757112..fa2b5a66d7 100644 --- a/lib/chef/provider/package/rubygems.rb +++ b/lib/chef/provider/package/rubygems.rb @@ -250,7 +250,7 @@ class Chef private def logger - Chef::Log.with_child({ subsytem: "gem_installer_environment" }) + Chef::Log.with_child({ subsystem: "gem_installer_environment" }) end end diff --git a/lib/chef/provider/package/windows.rb b/lib/chef/provider/package/windows.rb index 7c77461499..8ee5b36f5d 100644 --- a/lib/chef/provider/package/windows.rb +++ b/lib/chef/provider/package/windows.rb @@ -169,7 +169,7 @@ class Chef # is not multipackage. The existing implementation of package_provider.installed_version should probably # be what `uninstall_version_array` is, and then that list should be sorted and last/first'd into the # current_resource.version. The current_version_array method was not intended to be overwritten by - # sublasses (but ruby provides no feature to block doing so -- it is already marked as private). + # subclasses (but ruby provides no feature to block doing so -- it is already marked as private). # def current_version_array [ current_resource.version ] diff --git a/lib/chef/provider/package/yum.rb b/lib/chef/provider/package/yum.rb index 863f0da8e0..76b9b15172 100644 --- a/lib/chef/provider/package/yum.rb +++ b/lib/chef/provider/package/yum.rb @@ -100,7 +100,7 @@ class Chef # If this is a package like the kernel that can be installed multiple times, we'll skip over this logic if new_resource.allow_downgrade && version_gt?(iv.version_with_arch, av.version_with_arch) && !python_helper.install_only_packages(name) - # We allow downgrading only in the evenit of single-package + # We allow downgrading only in the event of single-package # rules where the user explicitly allowed it method = "downgrade" end diff --git a/lib/chef/provider/package/yum/yum_cache.rb b/lib/chef/provider/package/yum/yum_cache.rb index cec848dbd9..b65e1e560f 100644 --- a/lib/chef/provider/package/yum/yum_cache.rb +++ b/lib/chef/provider/package/yum/yum_cache.rb @@ -22,7 +22,7 @@ require "singleton" unless defined?(Singleton) # # These are largely historical APIs, the YumCache object no longer exists and this is a -# fascade over the python helper class. It should be considered deprecated-lite and +# facade over the python helper class. It should be considered deprecated-lite and # no new APIs should be added and should be added to the python_helper instead. # diff --git a/lib/chef/provider/remote_directory.rb b/lib/chef/provider/remote_directory.rb index c1d537c8cc..0c2cce4026 100644 --- a/lib/chef/provider/remote_directory.rb +++ b/lib/chef/provider/remote_directory.rb @@ -147,7 +147,7 @@ class Chef new_resource.updated_by_last_action(true) if res.updated? end - # Get the files to tranfer. This returns files in lexicographical sort order. + # Get the files to transfer. This returns files in lexicographical sort order. # # FIXME: it should do breadth-first, see CHEF-5080 (please use a performant sort) # @@ -245,7 +245,7 @@ class Chef res = Chef::Resource::Directory.new(dir, run_context) res.cookbook_name = resource_cookbook if ChefUtils.windows? && rights - # rights are only meant to be applied to the toppest-level directory; + # rights are only meant to be applied to the most top-level directory; # Windows will handle inheritance. if dir == path rights.each do |r| diff --git a/lib/chef/provider/service/arch.rb b/lib/chef/provider/service/arch.rb index ee6d3dfacd..24064f26ac 100644 --- a/lib/chef/provider/service/arch.rb +++ b/lib/chef/provider/service/arch.rb @@ -42,7 +42,7 @@ class Chef::Provider::Service::Arch < Chef::Provider::Service::Init end # Get list of all daemons from the file '/etc/rc.conf'. - # Mutiple lines and background form are supported. Example: + # Multiple lines and background form are supported. Example: # DAEMONS=(\ # foobar \ # @example \ diff --git a/lib/chef/provider/service/upstart.rb b/lib/chef/provider/service/upstart.rb index 2feb0edd70..5b93e6f5a9 100644 --- a/lib/chef/provider/service/upstart.rb +++ b/lib/chef/provider/service/upstart.rb @@ -41,7 +41,7 @@ class Chef # Upstart does more than start or stop a service, creating multiple 'states' [1] that a service can be in. # In chef, when we ask a service to start, we expect it to have started before performing the next step - # since we have top down dependencies. Which is to say we may follow witha resource next that requires + # since we have top down dependencies. Which is to say we may follow with a resource next that requires # that service to be running. According to [2] we can trust that sending a 'goal' such as start will not # return until that 'goal' is reached, or some error has occurred. # diff --git a/lib/chef/provider/user/aix.rb b/lib/chef/provider/user/aix.rb index f41d0f5067..893f304a96 100644 --- a/lib/chef/provider/user/aix.rb +++ b/lib/chef/provider/user/aix.rb @@ -40,7 +40,7 @@ class Chef shell_out!("userdel", userdel_options, new_resource.username) end - # Aix does not support -r like other unix, sytem account is created by adding to 'system' group + # Aix does not support -r like other unix, system account is created by adding to 'system' group def useradd_options opts = [] opts << "-g" << "system" if new_resource.system diff --git a/lib/chef/provider/user/mac.rb b/lib/chef/provider/user/mac.rb index bc0c067d2f..05684d77d8 100644 --- a/lib/chef/provider/user/mac.rb +++ b/lib/chef/provider/user/mac.rb @@ -102,7 +102,7 @@ class Chef shadow_hash_hex = user_plist[:shadow_hash][0] return unless shadow_hash_hex && shadow_hash_hex != "" - # The password infomation is stored in the ShadowHashData key in the + # The password information is stored in the ShadowHashData key in the # plist. However, parsing it is a bit tricky as the value is itself # another encoded binary plist. We have to extract the encoded plist, # decode it from hex to a binary plist and then convert the binary @@ -116,6 +116,8 @@ class Chef # # eg: # + # spellchecker: disable + # # <array> # <string>77687920 63616e27 74206170 706c6520 6275696c 6420636f 6e736973 74656e74 20746f6f 6c696e67</string> # </array> @@ -126,6 +128,8 @@ class Chef # <data>AADKAAAKAA4LAA0MAAAAAAAAAAA=</data> # </array> # + # spellchecker: disable + # begin shadow_binary_plist = [shadow_hash_hex.delete(" ")].pack("H*") shadow_xml_plist = shell_out("plutil", "-convert", "xml1", "-o", "-", "-", input: shadow_binary_plist).stdout @@ -179,7 +183,7 @@ class Chef end if new_resource.manage_home - # "sydadminctl -addUser" will create the home directory if it's + # "sysadminctl -addUser" will create the home directory if it's # the default /Users/<username>, otherwise it sets it in plist # but does not create it. Here we'll ensure that it gets created # if we've been given a directory that is not the default. @@ -554,7 +558,7 @@ class Chef # 0x0A End of record denoted by \n # 0x5C Escaping is denoted by \ # 0x3A Fields are separated by : - # 0x2C Values are seperated by , + # 0x2C Values are separated by , # dsRecTypeStandard:Users The record type we're configuring # 2 How many properties we're going to set # dsAttrTypeStandard:RecordName Property 1: our users record name @@ -598,7 +602,7 @@ class Chef def run_sysadminctl(args) # sysadminctl doesn't exit with a non-zero code when errors are encountered - # and ouputs everything to STDERR instead of STDOUT and STDERR. Therefore we'll + # and outputs everything to STDERR instead of STDOUT and STDERR. Therefore we'll # return the STDERR and let the caller handle it. shell_out!("sysadminctl", args).stderr end diff --git a/lib/chef/provider/windows_task.rb b/lib/chef/provider/windows_task.rb index ff0d338b48..63a7b331e1 100644 --- a/lib/chef/provider/windows_task.rb +++ b/lib/chef/provider/windows_task.rb @@ -72,6 +72,7 @@ class Chef 6 => TaskScheduler::TASK_SIXTH, 7 => TaskScheduler::TASK_SEVENTH, 8 => TaskScheduler::TASK_EIGHTH, + # cspell:disable-next-line 9 => TaskScheduler::TASK_NINETH, 10 => TaskScheduler::TASK_TENTH, 11 => TaskScheduler::TASK_ELEVENTH, @@ -93,6 +94,7 @@ class Chef 27 => TaskScheduler::TASK_TWENTY_SEVENTH, 28 => TaskScheduler::TASK_TWENTY_EIGHTH, 29 => TaskScheduler::TASK_TWENTY_NINTH, + # cspell:disable-next-line 30 => TaskScheduler::TASK_THIRTYETH, 31 => TaskScheduler::TASK_THIRTY_FIRST, }.freeze @@ -229,7 +231,7 @@ class Chef private - # seprated command arguments from :command property + # separated command arguments from :command property def set_command_and_arguments cmd, *args = Chef::Util::PathHelper.split_args(new_resource.command) new_resource.command = cmd @@ -577,7 +579,7 @@ class Chef def logon_type # Ref: https://msdn.microsoft.com/en-us/library/windows/desktop/aa383566(v=vs.85).aspx - # if nothing is passed as logon_type the TASK_LOGON_SERVICE_ACCOUNT is getting set as default so using that for comparision. + # if nothing is passed as logon_type the TASK_LOGON_SERVICE_ACCOUNT is getting set as default so using that for comparison. user_id = new_resource.user.to_s password = new_resource.password.to_s if Chef::ReservedNames::Win32::Security::SID.service_account_user?(user_id) diff --git a/lib/chef/resource.rb b/lib/chef/resource.rb index fcf22a36b1..cd96c4c1e9 100644 --- a/lib/chef/resource.rb +++ b/lib/chef/resource.rb @@ -930,7 +930,7 @@ class Chef end # - # A hook called after a resource is created. Meant to be overriden by + # A hook called after a resource is created. Meant to be overridden by # subclasses. # def after_created @@ -1114,7 +1114,7 @@ class Chef # `action_class` method, the presence of either indicates that this is # going to be a Chef-12.5 custom resource. If we never see one of these # directives then we are constructing an old-style Resource+Provider or - # LWRP or whatevs. + # LWRP or whatever. # # If a block is passed, the action_class is always created and the block is # run inside it. @@ -1327,7 +1327,7 @@ class Chef # Once we no longer care about supporting chef < 14.4 then we can deprecate # this API. # - # @param arg [String] version constrant to match against (e.g. "> 14") + # @param arg [String] version constraint to match against (e.g. "> 14") # def self.chef_version_for_provides(constraint) @chef_version_for_provides = constraint diff --git a/lib/chef/resource/chef_handler.rb b/lib/chef/resource/chef_handler.rb index 0138baeaec..f2daab3d6e 100644 --- a/lib/chef/resource/chef_handler.rb +++ b/lib/chef/resource/chef_handler.rb @@ -107,7 +107,7 @@ class Chef end end - # Walks down the namespace heirarchy to return the class object for the given class name. + # Walks down the namespace hierarchy to return the class object for the given class name. # If the class is not available, NameError is thrown. # # @param class_full_name [String] full class name such as 'Chef::Handler::Foo' or 'MyHandler'. @@ -118,7 +118,7 @@ class Chef class_name = ancestors.pop # We need to search the ancestors only for the first/uppermost namespace of the class, so we - # need to enable the #const_get inherit paramenter only when we are searching in Kernel scope + # need to enable the #const_get inherit parameter only when we are searching in Kernel scope # (see COOK-4117). parent = ancestors.inject(Kernel) { |scope, const_name| scope.const_get(const_name, scope === Kernel) } child = parent.const_get(class_name, parent === Kernel) diff --git a/lib/chef/resource/chef_vault_secret.rb b/lib/chef/resource/chef_vault_secret.rb index 551962d86e..bbd21ec543 100644 --- a/lib/chef/resource/chef_vault_secret.rb +++ b/lib/chef/resource/chef_vault_secret.rb @@ -45,7 +45,7 @@ class Chef chef_vault_secret 'root-password' do admins 'jtimberman,paulmooring' data_bag 'secrets' - raw_data({'auth' => 'DontUseThisPasswordForRoot'}) + raw_data({'auth' => 'DoNotUseThisPasswordForRoot'}) search '*:*' end ``` diff --git a/lib/chef/resource/cron.rb b/lib/chef/resource/cron.rb index 73460859fa..79cf5642af 100644 --- a/lib/chef/resource/cron.rb +++ b/lib/chef/resource/cron.rb @@ -136,7 +136,7 @@ class Chef raise Chef::Exceptions::ValidationFailed, error_msg end unless h.values.all? { |x| x =~ TIMEOUT_REGEX } - error_msg = "Values of option time_out should be non-empty string without any leading whitespaces." + error_msg = "Values of option time_out should be non-empty string without any leading whitespace." raise Chef::Exceptions::ValidationFailed, error_msg end h diff --git a/lib/chef/resource/cron_d.rb b/lib/chef/resource/cron_d.rb index a3225c8fdb..c60240acc2 100644 --- a/lib/chef/resource/cron_d.rb +++ b/lib/chef/resource/cron_d.rb @@ -175,7 +175,7 @@ class Chef raise Chef::Exceptions::ValidationFailed, error_msg end unless h.values.all? { |x| x =~ TIMEOUT_REGEX } - error_msg = "Values of option time_out should be non-empty string without any leading whitespaces." + error_msg = "Values of option time_out should be non-empty string without any leading whitespace." raise Chef::Exceptions::ValidationFailed, error_msg end h diff --git a/lib/chef/resource/execute.rb b/lib/chef/resource/execute.rb index 192210799c..5a6b7ee960 100644 --- a/lib/chef/resource/execute.rb +++ b/lib/chef/resource/execute.rb @@ -84,7 +84,7 @@ class Chef desired_state: false property :user, [ String, Integer ], - description: "The user name of the user identity with which to launch the new process. The user name may optionally be specifed with a domain, i.e. domainuser or user@my.dns.domain.com via Universal Principal Name (UPN)format. It can also be specified without a domain simply as user if the domain is instead specified using the domain property. On Windows only, if this property is specified, the password property must be specified." + description: "The user name of the user identity with which to launch the new process. The user name may optionally be specified with a domain, i.e. domainuser or user@my.dns.domain.com via Universal Principal Name (UPN)format. It can also be specified without a domain simply as user if the domain is instead specified using the domain property. On Windows only, if this property is specified, the password property must be specified." property :domain, String, introduced: "12.21", diff --git a/lib/chef/resource/locale.rb b/lib/chef/resource/locale.rb index bb4f6628e2..ea7f5098ab 100644 --- a/lib/chef/resource/locale.rb +++ b/lib/chef/resource/locale.rb @@ -45,7 +45,7 @@ class Chef property :lang, String, description: "Sets the default system language.", regex: [LOCALE_REGEX], - validation_message: "The provided lang is not valid. It should be a non-empty string without any leading whitespaces." + validation_message: "The provided lang is not valid. It should be a non-empty string without any leading whitespace." property :lc_env, Hash, description: "A Hash of LC_* env variables in the form of `({ 'LC_ENV_VARIABLE' => 'VALUE' })`.", @@ -59,7 +59,7 @@ class Chef end end unless h.values.all? { |x| x =~ LOCALE_REGEX } - error_msg = "Values of option lc_env should be non-empty string without any leading whitespaces." + error_msg = "Values of option lc_env should be non-empty string without any leading whitespace." raise Chef::Exceptions::ValidationFailed, error_msg end h @@ -120,7 +120,7 @@ class Chef end end - # Generates the localisation files from templates using locale-gen. + # Generates the localization files from templates using locale-gen. # @see http://manpages.ubuntu.com/manpages/cosmic/man8/locale-gen.8.html # @raise [Mixlib::ShellOut::ShellCommandFailed] not a supported language or locale # diff --git a/lib/chef/resource/scm/git.rb b/lib/chef/resource/scm/git.rb index c399f9fb24..b8c8f06347 100644 --- a/lib/chef/resource/scm/git.rb +++ b/lib/chef/resource/scm/git.rb @@ -53,7 +53,7 @@ class Chef description: "The path to the wrapper script used when running SSH with git. The `GIT_SSH` environment variable is set to this." property :checkout_branch, String, - description: "Set this to use a local branch to avoid checking SHAs or tags to a detatched head state." + description: "Set this to use a local branch to avoid checking SHAs or tags to a detached head state." alias :branch :revision alias :reference :revision diff --git a/lib/chef/resource/windows_dfs_server.rb b/lib/chef/resource/windows_dfs_server.rb index cb2bee1234..c4abf75f20 100644 --- a/lib/chef/resource/windows_dfs_server.rb +++ b/lib/chef/resource/windows_dfs_server.rb @@ -50,7 +50,7 @@ class Chef ps_results = powershell_out("Get-DfsnServerConfiguration -ComputerName '#{ENV["COMPUTERNAME"]}' | Select LdapTimeoutSec, PreferLogonDC, EnableSiteCostedReferrals, SyncIntervalSec, UseFqdn | ConvertTo-Json") if ps_results.error? - raise "The dfs_server resource failed to fetch the current state via the Get-DfsnServerConfiguration PowerShell cmlet. Is the DFS Windows feature installed?" + raise "The dfs_server resource failed to fetch the current state via the Get-DfsnServerConfiguration PowerShell cmdlet. Is the DFS Windows feature installed?" end Chef::Log.debug("The Get-DfsnServerConfiguration results were #{ps_results.stdout}") diff --git a/lib/chef/resource/windows_pagefile.rb b/lib/chef/resource/windows_pagefile.rb index d459b01033..928a8d03e0 100644 --- a/lib/chef/resource/windows_pagefile.rb +++ b/lib/chef/resource/windows_pagefile.rb @@ -124,7 +124,7 @@ class Chef # @return [Boolean] def exists?(pagefile) @exists ||= begin - logger.trace("Checking if #{pagefile} exists by runing: wmic.exe pagefileset where SettingID=\"#{get_setting_id(pagefile)}\" list /format:list") + logger.trace("Checking if #{pagefile} exists by running: wmic.exe pagefileset where SettingID=\"#{get_setting_id(pagefile)}\" list /format:list") cmd = shell_out("wmic.exe pagefileset where SettingID=\"#{get_setting_id(pagefile)}\" list /format:list", returns: [0]) cmd.stderr.empty? && (cmd.stdout =~ /SettingID=#{get_setting_id(pagefile)}/i) end diff --git a/lib/chef/resource/windows_task.rb b/lib/chef/resource/windows_task.rb index 5e2aa70c47..d73030311e 100644 --- a/lib/chef/resource/windows_task.rb +++ b/lib/chef/resource/windows_task.rb @@ -274,7 +274,7 @@ class Chef ## Resource is not idempotent when day, start_day is not provided with frequency :weekly ## we set start_day when not given by user as current date based on which we set the day property for current current date day is monday .. - ## we set the monday as the day so at next run when new_resource.day is nil and current_resource day is monday due to which udpate gets called + ## we set the monday as the day so at next run when new_resource.day is nil and current_resource day is monday due to which update gets called def idempotency_warning_for_frequency_weekly(day, start_day) if start_day.nil? && day.nil? logger.warn "To maintain idempotency for frequency :weekly provide start_day, start_time and day." @@ -295,19 +295,19 @@ class Chef end def validate_frequency_monthly(frequency_modifier, months, day) - # validates the frequency :monthly and raises error if frequency_modifier is first, second, thrid etc and day is not provided + # validates the frequency :monthly and raises error if frequency_modifier is first, second, third etc and day is not provided if (frequency_modifier != 1) && (frequency_modifier_includes_days_of_weeks?(frequency_modifier)) && !(day) - raise ArgumentError, "Please select day on which you want to run the task e.g. 'Mon, Tue'. Multiple values must be seprated by comma." + raise ArgumentError, "Please select day on which you want to run the task e.g. 'Mon, Tue'. Multiple values must be separated by comma." end - # frequency_modifer 2-12 is used to set every (n) months, so using :months propety with frequency_modifer is not valid since they both used to set months. - # Not checking value 1 here for frequecy_modifier since we are setting that as default value it won't break anything since preference is given to months property + # frequency_modifier 2-12 is used to set every (n) months, so using :months property with frequency_modifier is not valid since they both used to set months. + # Not checking value 1 here for frequency_modifier since we are setting that as default value it won't break anything since preference is given to months property if (frequency_modifier.to_i.between?(2, 12)) && !(months.nil?) raise ArgumentError, "For frequency :monthly either use property months or frequency_modifier to set months." end end - # returns true if frequency_modifer has values First, second, third, fourth, last, lastday + # returns true if frequency_modifier has values First, second, third, fourth, last, lastday def frequency_modifier_includes_days_of_weeks?(frequency_modifier) frequency_modifier = frequency_modifier.to_s.split(",") frequency_modifier.map! { |value| value.strip.upcase } diff --git a/lib/chef/resource/windows_user_privilege.rb b/lib/chef/resource/windows_user_privilege.rb index f159b20226..1228712092 100644 --- a/lib/chef/resource/windows_user_privilege.rb +++ b/lib/chef/resource/windows_user_privilege.rb @@ -76,7 +76,7 @@ class Chef **Set the SeNetworkLogonRight Privilege for the Builtin Administrators Group and Authenticated Users**: ```ruby - windows_user_privilege 'Netowrk Logon Rights' do + windows_user_privilege 'Network Logon Rights' do privilege 'SeNetworkLogonRight' users ['BUILTIN\Administrators', 'NT AUTHORITY\Authenticated Users'] action :set diff --git a/lib/chef/run_context/cookbook_compiler.rb b/lib/chef/run_context/cookbook_compiler.rb index 6f70445082..9d8ea87360 100644 --- a/lib/chef/run_context/cookbook_compiler.rb +++ b/lib/chef/run_context/cookbook_compiler.rb @@ -101,7 +101,7 @@ class Chef @events.library_load_start(count_files_by_segment(:libraries)) cookbook_order.each do |cookbook| eager_load_libraries = cookbook_collection[cookbook].metadata.eager_load_libraries - if eager_load_libraries == true # actully true, not truthy + if eager_load_libraries == true # actually true, not truthy load_libraries_from_cookbook(cookbook) else $LOAD_PATH.unshift File.expand_path("libraries", cookbook_collection[cookbook].root_dir) diff --git a/lib/chef/shell/ext.rb b/lib/chef/shell/ext.rb index 01a7407de5..f8b8d2e0e3 100644 --- a/lib/chef/shell/ext.rb +++ b/lib/chef/shell/ext.rb @@ -37,7 +37,7 @@ module Shell module ObjectCoreExtensions def ensure_session_select_defined - # irb breaks if you prematurely define IRB::JobMangager + # irb breaks if you prematurely define IRB::JobManager # so these methods need to be defined at the latest possible time. unless jobs.respond_to?(:select_session_by_context) def jobs.select_session_by_context(&block) # rubocop:disable Lint/NestedMethodDefinition diff --git a/lib/chef/win32/api.rb b/lib/chef/win32/api.rb index 9e551707e6..957823220d 100644 --- a/lib/chef/win32/api.rb +++ b/lib/chef/win32/api.rb @@ -94,7 +94,7 @@ class Chef host.typedef :ulong, :HMENU # (L) Handle to a menu. http://msdn.microsoft.com/en-us/library/ms646977%28VS.85%29.aspx host.typedef :ulong, :HMETAFILE # (L) Handle to a metafile. http://msdn.microsoft.com/en-us/library/dd145051%28VS.85%29.aspx host.typedef :ulong, :HMODULE # (L) Handle to an instance. Same as HINSTANCE today, but was different in 16-bit Windows. - host.typedef :ulong, :HMONITOR # (L) Рandle to a display monitor. WinDef.h: if(WINVER >= 0x0500) host.typedef HANDLE HMONITOR; + host.typedef :ulong, :HMONITOR # (L) Handle to a display monitor. WinDef.h: if(WINVER >= 0x0500) host.typedef HANDLE HMONITOR; host.typedef :ulong, :HPALETTE # (L) Handle to a palette. host.typedef :ulong, :HPEN # (L) Handle to a pen. http://msdn.microsoft.com/en-us/library/dd162786%28VS.85%29.aspx host.typedef :long, :HRESULT # Return code used by COM interfaces. For more info, Structure of the COM Error Codes. @@ -115,7 +115,7 @@ class Chef host.typedef :uint32, :LCID # Locale identifier. For more information, see Locales. host.typedef :uint32, :LCTYPE # Locale information type. For a list, see Locale Information Constants. host.typedef :uint32, :LGRPID # Language group identifier. For a list, see EnumLanguageGroupLocales. - host.typedef :pointer, :LMSTR # Pointer to null termiated string of unicode characters + host.typedef :pointer, :LMSTR # Pointer to null terminated string of unicode characters host.typedef :long, :LONG # 32-bit signed integer. The range is -2,147,483,648 through +...647 decimal. host.typedef :int32, :LONG32 # 32-bit signed integer. The range is -2,147,483,648 through +...647 decimal. host.typedef :int64, :LONG64 # 64-bit signed integer. The range is –9,223,372,036,854,775,808 through +...807 diff --git a/lib/chef/win32/api/error.rb b/lib/chef/win32/api/error.rb index 6792fb6b34..0e1b943724 100644 --- a/lib/chef/win32/api/error.rb +++ b/lib/chef/win32/api/error.rb @@ -64,7 +64,7 @@ class Chef ERROR_SHARING_VIOLATION = 32 ERROR_LOCK_VIOLATION = 33 ERROR_WRONG_DISK = 34 - ERROR_FCB_UNAVAILABLE = 35 # gets returned for some unsuccessful DeviceIoControl calls + ERROR_FCB_UNAVAILABLE = 35 # gets returned for some unsuccessful DeviceIoControl calls ERROR_SHARING_BUFFER_EXCEEDED = 36 ERROR_HANDLE_EOF = 38 ERROR_HANDLE_DISK_FULL = 39 @@ -90,6 +90,7 @@ class Chef ERROR_TOO_MANY_NAMES = 68 ERROR_TOO_MANY_SESS = 69 ERROR_SHARING_PAUSED = 70 + # cspell:disable-next-line ERROR_REQ_NOT_ACCEP = 71 ERROR_REDIR_PAUSED = 72 @@ -876,6 +877,7 @@ class Chef # Flags for LoadLibraryEx + # cspell:disable-next-line DONT_RESOLVE_DLL_REFERENCES = 0x00000001 LOAD_IGNORE_CODE_AUTHZ_LEVEL = 0x00000010 LOAD_LIBRARY_AS_DATAFILE = 0x00000002 diff --git a/lib/chef/win32/api/file.rb b/lib/chef/win32/api/file.rb index 11a18e26d1..eb83e2487d 100644 --- a/lib/chef/win32/api/file.rb +++ b/lib/chef/win32/api/file.rb @@ -540,7 +540,7 @@ BOOL WINAPI VerQueryValue( def file_search_handle(path) # Workaround for CHEF-4419: # Make sure paths starting with "/" has a drive letter - # assigned from the current working diretory. + # assigned from the current working directory. # Note: With CHEF-4427 this issue will be fixed with a # broader fix to map all the paths starting with "/" to # SYSTEM_DRIVE on windows. diff --git a/lib/chef/win32/api/net.rb b/lib/chef/win32/api/net.rb index 87eac8f79b..374c2e231e 100644 --- a/lib/chef/win32/api/net.rb +++ b/lib/chef/win32/api/net.rb @@ -39,6 +39,7 @@ class Chef UF_ACCOUNTDISABLE = 0x000002 UF_PASSWD_CANT_CHANGE = 0x000040 UF_NORMAL_ACCOUNT = 0x000200 + # cspell:disable-next-line UF_DONT_EXPIRE_PASSWD = 0x010000 USE_NOFORCE = 0 diff --git a/lib/chef/win32/mutex.rb b/lib/chef/win32/mutex.rb index bac94e8166..85f4036c87 100644 --- a/lib/chef/win32/mutex.rb +++ b/lib/chef/win32/mutex.rb @@ -95,7 +95,7 @@ if other threads attempt to acquire the mutex.") @handle = OpenMutexW(SYNCHRONIZE, true, name.to_wstring) if @handle == 0 - # Mutext doesn't exist so create one. + # Mutex doesn't exist so create one. # In the initial creation of the mutex initial_owner is set to # false so that mutex will not be acquired until someone calls # acquire. diff --git a/lib/chef/win32/net.rb b/lib/chef/win32/net.rb index fb98276455..f985891c17 100644 --- a/lib/chef/win32/net.rb +++ b/lib/chef/win32/net.rb @@ -40,6 +40,7 @@ class Chef usri3_priv: 0, usri3_home_dir: nil, usri3_comment: nil, + # cspell:disable-next-line usri3_flags: UF_SCRIPT | UF_DONT_EXPIRE_PASSWD | UF_NORMAL_ACCOUNT, usri3_script_path: nil, usri3_auth_flags: 0, diff --git a/lib/chef/win32/security/sid.rb b/lib/chef/win32/security/sid.rb index e1727ddd3d..ed6c7bd65d 100644 --- a/lib/chef/win32/security/sid.rb +++ b/lib/chef/win32/security/sid.rb @@ -261,7 +261,7 @@ class Chef SYSTEM_USER = SERVICE_ACCOUNT_USERS + BUILT_IN_GROUPS - # Сheck if the user belongs to service accounts category + # Check if the user belongs to service accounts category # # @return [Boolean] True or False # @@ -269,7 +269,7 @@ class Chef SERVICE_ACCOUNT_USERS.include?(user.to_s.upcase) end - # Сheck if the user is in builtin system group + # Check if the user is in builtin system group # # @return [Boolean] True or False # @@ -277,7 +277,7 @@ class Chef BUILT_IN_GROUPS.include?(user.to_s.upcase) end - # Сheck if the user belongs to system users category + # Check if the user belongs to system users category # # @return [Boolean] True or False # @@ -325,7 +325,7 @@ class Chef Array.new(entriesread.read_long) do |i| user_info = USER_INFO_3.new(bufptr.read_pointer + i * USER_INFO_3.size) # Check if the account is the Administrator account - # RID for the Administrator account is always 500 and it's privilage is set to USER_PRIV_ADMIN + # RID for the Administrator account is always 500 and it's privilege is set to USER_PRIV_ADMIN if user_info[:usri3_user_id] == 500 && user_info[:usri3_priv] == 2 # USER_PRIV_ADMIN (2) - Administrator admin_account_name = user_info[:usri3_name].read_wstring break diff --git a/omnibus/omnibus-test.ps1 b/omnibus/omnibus-test.ps1 index 45b6ba5d27..09a01c94bc 100644 --- a/omnibus/omnibus-test.ps1 +++ b/omnibus/omnibus-test.ps1 @@ -91,7 +91,7 @@ winrm quickconfig -quiet bundle If ($lastexitcode -ne 0) { Exit $lastexitcode } -# FIXME: we need to add back unit and integration tests here. we have no converage of those on e.g. AIX +# FIXME: we need to add back unit and integration tests here. we have no coverage of those on e.g. AIX # # chocolatey functional tests fail so disable that tag directly <-- and this is a bug that needs fixing. bundle exec rspec -r rspec_junit_formatter -f RspecJunitFormatter -o test.xml -f documentation --tag ~choco_installed spec/functional diff --git a/omnibus/omnibus-test.sh b/omnibus/omnibus-test.sh index 2a3b6e520e..d33ade448c 100644 --- a/omnibus/omnibus-test.sh +++ b/omnibus/omnibus-test.sh @@ -157,5 +157,5 @@ CHEF_LICENSE=accept-no-persist cd "$chef_gem" sudo -E bundle install -# FIXME: we need to add back unit and integration tests here. we have no converage of those on e.g. AIX +# FIXME: we need to add back unit and integration tests here. we have no coverage of those on e.g. AIX sudo -E bundle exec rspec -r rspec_junit_formatter -f RspecJunitFormatter -o test.xml -f documentation spec/functional diff --git a/omnibus/package-scripts/angrychef/postrm b/omnibus/package-scripts/angrychef/postrm index a153da7102..0963b1d901 100755 --- a/omnibus/package-scripts/angrychef/postrm +++ b/omnibus/package-scripts/angrychef/postrm @@ -45,6 +45,6 @@ if [ ! -f /etc/redhat-release -a ! -f /etc/fedora-release -a ! -f /etc/system-re # not a redhat-ish RPM-based system cleanup_symlinks elif [ "x$1" = "x0" ]; then - # RPM-based system and we're deinstalling rather than upgrading + # RPM-based system and we're uninstalling rather than upgrading cleanup_symlinks fi diff --git a/omnibus/package-scripts/chef/postrm b/omnibus/package-scripts/chef/postrm index a153da7102..0963b1d901 100755 --- a/omnibus/package-scripts/chef/postrm +++ b/omnibus/package-scripts/chef/postrm @@ -45,6 +45,6 @@ if [ ! -f /etc/redhat-release -a ! -f /etc/fedora-release -a ! -f /etc/system-re # not a redhat-ish RPM-based system cleanup_symlinks elif [ "x$1" = "x0" ]; then - # RPM-based system and we're deinstalling rather than upgrading + # RPM-based system and we're uninstalling rather than upgrading cleanup_symlinks fi diff --git a/spec/functional/resource/git_spec.rb b/spec/functional/resource/git_spec.rb index ca1bd30893..f8064fef20 100644 --- a/spec/functional/resource/git_spec.rb +++ b/spec/functional/resource/git_spec.rb @@ -103,7 +103,7 @@ describe Chef::Resource::Git, requires_git: true do revision "v1.0.0" end.should_be_updated expect_revision_to_be("HEAD", v1_commit) - expect_branch_to_be("tags/v1.0.0^0") # detatched + expect_branch_to_be("tags/v1.0.0^0") # detached # also verify the tag commit itself is what we expect as an extra sanity check expect_revision_to_be("v1.0.0", v1_tag) end @@ -116,7 +116,7 @@ describe Chef::Resource::Git, requires_git: true do git deploy_directory do repository origin_repo revision "v1.0.0" - expect_branch_to_be("tags/v1.0.0^0") # detatched + expect_branch_to_be("tags/v1.0.0^0") # detached end.should_not_be_updated end end @@ -128,7 +128,7 @@ describe Chef::Resource::Git, requires_git: true do revision rev_foo end.should_be_updated expect_revision_to_be("HEAD", rev_foo) - expect_branch_to_be("master~1") # detatched + expect_branch_to_be("master~1") # detached end it "checks out the expected revision ed18 to a local branch" do @@ -138,7 +138,7 @@ describe Chef::Resource::Git, requires_git: true do checkout_branch "deploy" end.should_be_updated expect_revision_to_be("HEAD", rev_foo) - expect_branch_to_be("deploy") # detatched + expect_branch_to_be("deploy") # detached end it "doesn't update if up-to-date" do @@ -152,7 +152,7 @@ describe Chef::Resource::Git, requires_git: true do repository origin_repo revision rev_foo end.should_not_be_updated - expect_branch_to_be("master~1") # detatched + expect_branch_to_be("master~1") # detached end it "checks out the expected revision 972d" do @@ -161,7 +161,7 @@ describe Chef::Resource::Git, requires_git: true do revision rev_testing end.should_be_updated expect_revision_to_be("HEAD", rev_testing) - expect_branch_to_be("master~2") # detatched + expect_branch_to_be("master~2") # detached end it "checks out the expected revision 972d to a local branch" do diff --git a/spec/functional/resource/windows_task_spec.rb b/spec/functional/resource/windows_task_spec.rb index 8ed8d5c522..5a044e0924 100644 --- a/spec/functional/resource/windows_task_spec.rb +++ b/spec/functional/resource/windows_task_spec.rb @@ -317,12 +317,12 @@ describe Chef::Resource::WindowsTask, :windows_only do expect(subject).not_to be_updated_by_last_action end - it "updates a scheduled task to run every 5 hrs when frequency modifer updated to 5" do + it "updates a scheduled task to run every 5 hrs when frequency modifier updated to 5" do subject.run_action(:create) current_resource = call_for_load_current_resource trigger_details = current_resource.task.trigger(0) expect(trigger_details[:minutes_interval]).to eq(180) - # updating frequency modifer to 5 from 3 + # updating frequency modifier to 5 from 3 subject.frequency_modifier 5 subject.run_action(:create) expect(subject).to be_updated_by_last_action @@ -501,7 +501,7 @@ describe Chef::Resource::WindowsTask, :windows_only do it "raises argument error if frequency_modifier is 'first, second' and day is not provided." do subject.frequency_modifier "first, second" - expect { subject.after_created }.to raise_error("Please select day on which you want to run the task e.g. 'Mon, Tue'. Multiple values must be seprated by comma.") + expect { subject.after_created }.to raise_error("Please select day on which you want to run the task e.g. 'Mon, Tue'. Multiple values must be separated by comma.") end it "raises argument error if months is passed along with frequency_modifier" do @@ -532,7 +532,7 @@ describe Chef::Resource::WindowsTask, :windows_only do expect { subject.after_created }.to raise_error("frequency_modifier value 0 is invalid. Valid values for :monthly frequency are 1 - 12, 'FIRST', 'SECOND', 'THIRD', 'FOURTH', 'LAST'.") end - it "creates scheduled task to run task monthly on Monday and Friday of first, second and thrid week of month" do + it "creates scheduled task to run task monthly on Monday and Friday of first, second and third week of month" do subject.frequency_modifier "first, second, third" subject.day "Mon, Fri" expect { subject.after_created }.not_to raise_error(ArgumentError) diff --git a/spec/support/shared/unit/provider/useradd_based_user_provider.rb b/spec/support/shared/unit/provider/useradd_based_user_provider.rb index 97c7ab3d3e..1f9f87866c 100644 --- a/spec/support/shared/unit/provider/useradd_based_user_provider.rb +++ b/spec/support/shared/unit/provider/useradd_based_user_provider.rb @@ -106,25 +106,25 @@ shared_examples_for "a useradd-based user provider" do |supported_useradd_option describe "when the resource has a different home directory and supports home directory management" do before do - @new_resource.home "/wowaweea" + @new_resource.home "/banana" @new_resource.manage_home true end it "should set -m -d /homedir" do - expect(provider.universal_options).to eq(%w{-d /wowaweea}) + expect(provider.universal_options).to eq(%w{-d /banana}) expect(provider.usermod_options).to eq(%w{-m}) end end describe "when the resource has a different home directory and supports home directory management (using real attributes)" do before do - @new_resource.home("/wowaweea") + @new_resource.home("/banana") @new_resource.manage_home true @new_resource.non_unique false end it "should set -m -d /homedir" do - expect(provider.universal_options).to eq(%w{-d /wowaweea}) + expect(provider.universal_options).to eq(%w{-d /banana}) expect(provider.usermod_options).to eq(%w{-m}) end end diff --git a/spec/unit/knife/core/windows_bootstrap_context_spec.rb b/spec/unit/knife/core/windows_bootstrap_context_spec.rb index e0ca7f17ab..6b041c5311 100644 --- a/spec/unit/knife/core/windows_bootstrap_context_spec.rb +++ b/spec/unit/knife/core/windows_bootstrap_context_spec.rb @@ -217,7 +217,7 @@ describe Chef::Knife::Core::WindowsBootstrapContext do let(:custom_url) { "file://something" } let(:config) { { msi_url: custom_url, install: true } } - it "returns the overriden url" do + it "returns the overridden url" do expect(bootstrap_context.msi_url).to eq(custom_url) end diff --git a/spec/unit/node/attribute_spec.rb b/spec/unit/node/attribute_spec.rb index 564dc1a231..6e78725bd9 100644 --- a/spec/unit/node/attribute_spec.rb +++ b/spec/unit/node/attribute_spec.rb @@ -382,7 +382,7 @@ describe Chef::Node::Attribute do expect(@attributes["command"]["ps"]).to eq("ps -ef") end - it "should return default data if it is not overriden or in attribute data" do + it "should return default data if it is not overridden or in attribute data" do expect(@attributes["music"]["mastodon"]).to eq("rocks") end diff --git a/spec/unit/provider/group/groupadd_spec.rb b/spec/unit/provider/group/groupadd_spec.rb index ad075f0c42..50ee766cdb 100644 --- a/spec/unit/provider/group/groupadd_spec.rb +++ b/spec/unit/provider/group/groupadd_spec.rb @@ -57,7 +57,7 @@ describe Chef::Provider::Group::Groupadd do end it "should set the option for #{property} if the new resources #{property} is not null" do - allow(new_resource).to receive(property).and_return("wowaweea") + allow(new_resource).to receive(property).and_return("cactus") expect(provider.set_options).to eql([ option, new_resource.send(property), new_resource.group_name]) end end diff --git a/spec/unit/provider/package/portage_spec.rb b/spec/unit/provider/package/portage_spec.rb index bc7ad22854..8fdd7f877a 100644 --- a/spec/unit/provider/package/portage_spec.rb +++ b/spec/unit/provider/package/portage_spec.rb @@ -118,13 +118,13 @@ describe Chef::Provider::Package::Portage, "load_current_resource" do expect { @provider.candidate_version }.to raise_error(Chef::Exceptions::Package) end - it "should find the candidate_version if a category is specifed and there are no duplicates" do + it "should find the candidate_version if a category is specified and there are no duplicates" do status = double(stdout: "dev-vcs/git-2.16.2", exitstatus: 0) expect(@provider).to receive(:shell_out_compacted).and_return(status) expect(@provider.candidate_version).to eq("2.16.2") end - it "should find the candidate_version if a category is not specifed and there are no duplicates" do + it "should find the candidate_version if a category is not specified and there are no duplicates" do status = double(stdout: "dev-vcs/git-2.16.2", exitstatus: 0) @provider = Chef::Provider::Package::Portage.new(@new_resource_without_category, @run_context) expect(@provider).to receive(:shell_out_compacted).and_return(status) diff --git a/spec/unit/provider/package/powershell_spec.rb b/spec/unit/provider/package/powershell_spec.rb index 865cce4b22..a0d081fd78 100644 --- a/spec/unit/provider/package/powershell_spec.rb +++ b/spec/unit/provider/package/powershell_spec.rb @@ -131,7 +131,7 @@ describe Chef::Provider::Package::Powershell, :windows_only do expect(provider.candidate_version).to eql(["2.12.0.0"]) end - it "should set the candidate_version to the latest version when not pinning and package name is space seperated" do + it "should set the candidate_version to the latest version when not pinning and package name is space separated" do allow(provider).to receive(:powershell_out).with("( Find-Package '7-Zip 16.02 (x64)' -Force -ForceBootstrap ).Version", { timeout: new_resource.timeout }).and_return(package_7zip_available) new_resource.package_name(["7-Zip 16.02 (x64)"]) new_resource.version(nil) diff --git a/spec/unit/win32/registry_spec.rb b/spec/unit/win32/registry_spec.rb index f75a85a32b..124765129b 100644 --- a/spec/unit/win32/registry_spec.rb +++ b/spec/unit/win32/registry_spec.rb @@ -30,7 +30,7 @@ describe Chef::Win32::Registry do let(:sub_key) { "OpscodePrimes" } let(:missing_key_path) { 'HKCU\Software' } let(:registry) { Chef::Win32::Registry.new } - let(:hive_mock) { double("::Win32::Registry::KHKEY_CURRENT_USER") } + let(:hive_mock) { double("::Win32::Registry::HKEY_CURRENT_USER") } let(:reg_mock) { double("reg") } before(:all) do diff --git a/tasks/docs.rb b/tasks/docs.rb index f0aff0e32a..ef77cd03a9 100755 --- a/tasks/docs.rb +++ b/tasks/docs.rb @@ -11,7 +11,7 @@ namespace :docs_site do require "fileutils" require "yaml" - # @return [String, nil] a pretty defaul value string or nil if we want to skip it + # @return [String, nil] a pretty default value string or nil if we want to skip it def pretty_default(default) return nil if default.nil? || default == "" || default == "lazy default" |