diff options
author | Tim Smith <tsmith@chef.io> | 2019-03-04 17:05:35 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-03-04 17:05:35 -0800 |
commit | 97a972b30a4c96312e1792b6644c22cacb48322b (patch) | |
tree | 53ed8050eb26c95baa8ace88ab8c9fde1f2a08fb | |
parent | 188dfc83bec9d9e7075e1cf19e1eb43d7b11e74d (diff) | |
parent | a777a110abbd8e63b9568cd37eb6fe3df75a8977 (diff) | |
download | chef-97a972b30a4c96312e1792b6644c22cacb48322b.tar.gz |
Merge pull request #8271 from gsreynolds/fix-aix-mount-error
mount: Add proper new lines when on AIX to prevent failures
-rw-r--r-- | lib/chef/provider/mount/aix.rb | 2 | ||||
-rw-r--r-- | spec/unit/provider/mount/aix_spec.rb | 10 |
2 files changed, 10 insertions, 2 deletions
diff --git a/lib/chef/provider/mount/aix.rb b/lib/chef/provider/mount/aix.rb index 9614fc1e7f..2d7fc1d9c3 100644 --- a/lib/chef/provider/mount/aix.rb +++ b/lib/chef/provider/mount/aix.rb @@ -164,7 +164,7 @@ class Chef disable_fs end ::File.open("/etc/filesystems", "a") do |fstab| - fstab.puts("#{@new_resource.mount_point}:") + fstab.puts("\n\n#{@new_resource.mount_point}:") if network_device? device_details = device_fstab.split(":") fstab.puts("\tdev\t\t= #{device_details[1]}") diff --git a/spec/unit/provider/mount/aix_spec.rb b/spec/unit/provider/mount/aix_spec.rb index e1cc140855..8af22368ea 100644 --- a/spec/unit/provider/mount/aix_spec.rb +++ b/spec/unit/provider/mount/aix_spec.rb @@ -202,12 +202,20 @@ describe Chef::Provider::Mount::Aix do it "should enable mount if it is mounted and not enabled" do @new_resource.options("nodev,rw") stub_mounted_enabled(@provider, @mounted_output, "") + # Add existing mount to test enable action appends additional mount with seperating blank line filesystems = StringIO.new + filesystems.puts <<~ETCFILESYSTEMS + /tmp/abc: + dev = /dev/sdz2 + vfs = jfs2 + mount = true + options = rw + ETCFILESYSTEMS allow(::File).to receive(:open).with("/etc/filesystems", "a").and_yield(filesystems) @provider.run_action(:enable) - expect(filesystems.string).to match(%r{^/tmp/foo:\n\tdev\t\t= /dev/sdz1\n\tvfs\t\t= jfs2\n\tmount\t\t= false\n\toptions\t\t= nodev,rw\n$}) + expect(filesystems.string).to match(%r{^\n\n/tmp/foo:\n\tdev\t\t= /dev/sdz1\n\tvfs\t\t= jfs2\n\tmount\t\t= false\n\toptions\t\t= nodev,rw\n$}) end it "should not enable mount if it is mounted and already enabled and mount options are unchanged" do |