summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Schaumburg <pschaumburg@tecracer.de>2020-03-30 16:12:58 +0200
committerPatrick Schaumburg <pschaumburg@tecracer.de>2020-03-30 16:12:58 +0200
commit0bdeca2ea7d7108db6418c597f5c379da6eba7e8 (patch)
treef6869f4fc9caf96765da1b15cc6b33c2ce5c62c2
parent060229bc5d9d462cff553263cd58b7e8748fa1ee (diff)
downloadchef-0bdeca2ea7d7108db6418c597f5c379da6eba7e8.tar.gz
fix second check
-rw-r--r--lib/chef/resource/windows_firewall_rule.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/chef/resource/windows_firewall_rule.rb b/lib/chef/resource/windows_firewall_rule.rb
index 52aa4ac7cd..dcdec77395 100644
--- a/lib/chef/resource/windows_firewall_rule.rb
+++ b/lib/chef/resource/windows_firewall_rule.rb
@@ -252,7 +252,7 @@ class Chef
elsif icmp_type.is_a?(String)
return false if !protocol.start_with?("ICMP") && icmp_type !~ /^\D+$/
- return false if icmp_type.count("a-zA-Z") > 0 || icmp_type.count(":") > 1
+ return false if icmp_type.count("a-zA-Z") > 0 && icmp_type.count(":") > 1
if protocol.start_with?("ICMP") && icmp_type.include?(":")
return icmp_type.split(":").all? { |type| (0..255).include?(type.to_i) }