Skip more resources and set others to desired state false

Signed-off-by: Tim Smith <tsmith@chef.io>

17 files changed, 26 insertions, 19 deletions

diff --git a/lib/chef/resource/apt_update.rb b/lib/chef/resource/apt_update.rb
index 04a9407813..680806bc26 100644
--- a/lib/chef/resource/apt_update.rb
+++ b/lib/chef/resource/apt_update.rb
@@ -29,6 +29,7 @@ class Chef
 
       # allow bare apt_update with no name
       property :name, String, default: ""
+
       property :frequency, Integer,
                 description: "Determines how frequently (in seconds) APT repository updates are made. Use this property when the :periodic action is specified.",
                 default: 86_400
diff --git a/lib/chef/resource/build_essential.rb b/lib/chef/resource/build_essential.rb
index 99722b14ed..d9d75fb83b 100644
--- a/lib/chef/resource/build_essential.rb
+++ b/lib/chef/resource/build_essential.rb
@@ -30,7 +30,7 @@ class Chef
 
       property :compile_time, [TrueClass, FalseClass],
                description: "Install the build essential packages at compile time.",
-               default: false
+               default: false, desired_state: false
 
       action :install do
 
diff --git a/lib/chef/resource/cookbook_file.rb b/lib/chef/resource/cookbook_file.rb
index 0caa9d0553..c96e794469 100644
--- a/lib/chef/resource/cookbook_file.rb
+++ b/lib/chef/resource/cookbook_file.rb
@@ -36,7 +36,8 @@ class Chef
                 default: lazy { ::File.basename(name) }
 
       property :cookbook, String,
-                description: "The cookbook in which a file is located (if it is not located in the current cookbook)."
+                description: "The cookbook in which a file is located (if it is not located in the current cookbook).",
+                desired_state: false
 
       default_action :create
     end
diff --git a/lib/chef/resource/cron_d.rb b/lib/chef/resource/cron_d.rb
index ab6d600a16..6beff4936e 100644
--- a/lib/chef/resource/cron_d.rb
+++ b/lib/chef/resource/cron_d.rb
@@ -91,7 +91,7 @@ class Chef
                description: "Set the name of the cron job. If this isn't specified we'll use the resource name.",
                name_property: true
 
-      property :cookbook, String
+      property :cookbook, String, desired_state: false
 
       property :predefined_value, String,
                description: 'Schedule your cron job with one of the special predefined value instead of ** * pattern. This correspond to "@reboot", "@yearly", "@annually", "@monthly", "@weekly", "@daily", "@midnight" or "@hourly".',
diff --git a/lib/chef/resource/execute.rb b/lib/chef/resource/execute.rb
index 2643a45756..e74d0c1439 100644
--- a/lib/chef/resource/execute.rb
+++ b/lib/chef/resource/execute.rb
@@ -62,7 +62,7 @@ class Chef
                description: "Prevent a command from creating a file when that file already exists."
 
       property :cwd, String,
-               description: "Set the current working directory before running a command."
+               description: "The current working directory from which the command will be run."
 
       property :environment, Hash,
                description: "Specify a Hash of environment variables to be set."
diff --git a/lib/chef/resource/file.rb b/lib/chef/resource/file.rb
index cac20f2356..8db15fc661 100644
--- a/lib/chef/resource/file.rb
+++ b/lib/chef/resource/file.rb
@@ -66,7 +66,7 @@ class Chef
       property :content, [ String, nil ], desired_state: false,
                description: "A string that is written to the file. The contents of this property replace any previous content when this property has something other than the default value. The default behavior will not modify content."
 
-      property :diff, [ String, nil ], desired_state: false
+      property :diff, [ String, nil ], desired_state: false, skip_docs: true
 
       property :force_unlink, [ TrueClass, FalseClass ], desired_state: false, default: false,
                description: "How the chef-client handles certain situations when the target file turns out not to be a file. For example, when a target file is actually a symlink. Set to true for the chef-client delete the non-file target and replace it with the specified file. Set to false for the chef-client to raise an error."
diff --git a/lib/chef/resource/hostname.rb b/lib/chef/resource/hostname.rb
index 30446fbead..37106efd74 100644
--- a/lib/chef/resource/hostname.rb
+++ b/lib/chef/resource/hostname.rb
@@ -32,7 +32,7 @@ class Chef
 
       property :compile_time, [ TrueClass, FalseClass ],
                description: "Determines whether or not the resource shoul be run at compile time.",
-               default: true
+               default: true, desired_state: false
 
       property :ipaddress, String,
                description: "The IP address to use when configuring the hosts file.",
diff --git a/lib/chef/resource/locale.rb b/lib/chef/resource/locale.rb
index 9c5e7d0eea..bf4efd733a 100644
--- a/lib/chef/resource/locale.rb
+++ b/lib/chef/resource/locale.rb
@@ -29,6 +29,7 @@ class Chef
       property :lang, String,
                default: "en_US.utf8",
                description: "Sets the default system language."
+
       property :lc_all, String,
                default: "en_US.utf8",
                description: "Sets the fallback system language."
diff --git a/lib/chef/resource/mdadm.rb b/lib/chef/resource/mdadm.rb
index 3fc5b7c338..ee0284ec37 100644
--- a/lib/chef/resource/mdadm.rb
+++ b/lib/chef/resource/mdadm.rb
@@ -40,9 +40,10 @@ class Chef
                default: lazy { [] },
                description: "The devices to be part of a RAID array."
 
+      # @todo this should get refactored away
       property :exists, [ TrueClass, FalseClass ],
                default: false,
-               description: "Indicates whether the RAID array exists."
+               skip_docs: true
 
       property :level, Integer,
                default: 1,
diff --git a/lib/chef/resource/mount.rb b/lib/chef/resource/mount.rb
index 71e23c8cdb..4c20a62cf8 100644
--- a/lib/chef/resource/mount.rb
+++ b/lib/chef/resource/mount.rb
@@ -50,7 +50,7 @@ class Chef
                equal_to: RUBY_PLATFORM =~ /solaris/i ? %i{ device } : %i{ device label uuid }
 
       # @todo this should get refactored away: https://github.com/chef/chef/issues/7621
-      property :mounted, [TrueClass, FalseClass], default: false
+      property :mounted, [TrueClass, FalseClass], default: false, skip_docs: true
 
       property :fsck_device, String,
                description: "Solaris only: The fsck device.",
diff --git a/lib/chef/resource/powershell_package.rb b/lib/chef/resource/powershell_package.rb
index 91e300584f..d63f9f3dc2 100644
--- a/lib/chef/resource/powershell_package.rb
+++ b/lib/chef/resource/powershell_package.rb
@@ -45,7 +45,7 @@ class Chef
 
       property :skip_publisher_check, [true, false],
                description: "Skip validating module author.",
-               default: false, introduced: "14.3"
+               default: false, introduced: "14.3", desired_state: false
 
     end
   end
diff --git a/lib/chef/resource/remote_directory.rb b/lib/chef/resource/remote_directory.rb
index f03b13ef02..b9f701ee6d 100644
--- a/lib/chef/resource/remote_directory.rb
+++ b/lib/chef/resource/remote_directory.rb
@@ -56,8 +56,8 @@ class Chef
       property :source, String, default: lazy { ::File.basename(path) }
       property :files_backup, [ Integer, FalseClass ], default: 5, desired_state: false
       property :purge, [ TrueClass, FalseClass ], default: false, desired_state: false
-      property :overwrite, [ TrueClass, FalseClass ], default: true
-      property :cookbook, String
+      property :overwrite, [ TrueClass, FalseClass ], default: true, desired_state: false
+      property :cookbook, String, desired_state: false
 
       def files_group(arg = nil)
         set_or_return(
diff --git a/lib/chef/resource/windows_ad_join.rb b/lib/chef/resource/windows_ad_join.rb
index cb0f43e9d1..645dab5ad0 100644
--- a/lib/chef/resource/windows_ad_join.rb
+++ b/lib/chef/resource/windows_ad_join.rb
@@ -58,7 +58,7 @@ class Chef
 
       # define this again so we can default it to true. Otherwise failures print the password
       property :sensitive, [TrueClass, FalseClass],
-               default: true
+               default: true, desired_state: false
 
       action :join do
         description "Join the Active Directory domain."
diff --git a/lib/chef/resource/windows_printer.rb b/lib/chef/resource/windows_printer.rb
index 7d596a9691..1b9047a222 100644
--- a/lib/chef/resource/windows_printer.rb
+++ b/lib/chef/resource/windows_printer.rb
@@ -61,7 +61,7 @@ class Chef
                regex: Resolv::IPv4::Regex
 
       property :exists, [TrueClass, FalseClass],
-               desired_state: true
+               skip_docs: true
 
       PRINTERS_REG_KEY = 'HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Print\Printers\\'.freeze unless defined?(PRINTERS_REG_KEY)
 
diff --git a/lib/chef/resource/windows_printer_port.rb b/lib/chef/resource/windows_printer_port.rb
index 3d54c72f47..07f0778d9b 100644
--- a/lib/chef/resource/windows_printer_port.rb
+++ b/lib/chef/resource/windows_printer_port.rb
@@ -56,7 +56,7 @@ class Chef
                default: 1, equal_to: [1, 2]
 
       property :exists, [TrueClass, FalseClass],
-               desired_state: true
+               skip_docs: true
 
       PORTS_REG_KEY = 'HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Print\Monitors\Standard TCP/IP Port\Ports\\'.freeze unless defined?(PORTS_REG_KEY)
 
diff --git a/lib/chef/resource/windows_workgroup.rb b/lib/chef/resource/windows_workgroup.rb
index 229afa2e8e..f8391a88cd 100644
--- a/lib/chef/resource/windows_workgroup.rb
+++ b/lib/chef/resource/windows_workgroup.rb
@@ -36,20 +36,22 @@ class Chef
                name_property: true
 
       property :user, String,
-               description: "The local administrator user to use to change the workgroup."
+               description: "The local administrator user to use to change the workgroup.",
+               desired_state: false
 
       property :password, String,
-               description: "The password for the local administrator user."
+               description: "The password for the local administrator user.",
+               desired_state: false
 
       property :reboot, Symbol,
                equal_to: [:immediate, :delayed, :never, :request_reboot, :reboot_now],
                validation_message: "The reboot property accepts :immediate (reboot as soon as the resource completes), :delayed (reboot once the Chef run completes), and :never (Don't reboot)",
                description: "Controls the system reboot behavior post workgroup joining. Reboot immediately, after the Chef run completes, or never. Note that a reboot is necessary for changes to take effect.",
-               default: :immediate
+               default: :immediate, desired_state: false
 
       # define this again so we can default it to true. Otherwise failures print the password
       property :sensitive, [TrueClass, FalseClass],
-               default: true
+               default: true, desired_state: false
 
       action :join do
         description "Update the workgroup."
diff --git a/lib/chef/resource/zypper_repository.rb b/lib/chef/resource/zypper_repository.rb
index b3e1db6b83..e4db20d446 100644
--- a/lib/chef/resource/zypper_repository.rb
+++ b/lib/chef/resource/zypper_repository.rb
@@ -85,7 +85,8 @@ class Chef
                description: "The name of the template for the repository file. Only necessary if you're not using the built in template."
 
       property :cookbook, String,
-               description: "The cookbook to source the repository template file from. Only necessary if you're not using the built in template."
+               description: "The cookbook to source the repository template file from. Only necessary if you're not using the built in template.",
+               desired_state: false
 
       property :gpgautoimportkeys, [TrueClass, FalseClass],
                description: "Automatically import the specified key when setting up the repository.",