Fix how enforce_license is set in run method for chef-apply

I recently discovered that when using
Chef::Application::Apply.new.run(enforce_license: false), chef-apply will still
run the license verification when I expected it to be disabled. It seems this
feature works if you install this as a gem, however if you build chef using
omnibus with this set, it refuses to work. I suspect this might be something
with appbundler.

I noticed that other binaries (i.e. solo) were using "run(enforce_license:
false)" instead of "run(enforce_license = false)" which chef-apply uses. If I
changed this to "run(enforce_license: false)", this worked as expected.

Signed-off-by: Lance Albertson <lance@osuosl.org>

2 files changed, 8 insertions, 1 deletions

diff --git a/lib/chef/application/apply.rb b/lib/chef/application/apply.rb
index 33a8a97f5b..4ed2d2a1f2 100644
--- a/lib/chef/application/apply.rb
+++ b/lib/chef/application/apply.rb
@@ -233,7 +233,7 @@ class Chef::Application::Apply < Chef::Application
   end
 
   # Get this party started
-  def run(enforce_license = false)
+  def run(enforce_license: false)
     reconfigure
     check_license_acceptance if enforce_license
     run_application
diff --git a/spec/unit/application_spec.rb b/spec/unit/application_spec.rb
index ea784f1d55..031132f31d 100644
--- a/spec/unit/application_spec.rb
+++ b/spec/unit/application_spec.rb
@@ -94,6 +94,13 @@ describe Chef::Application do
           end
         end
 
+        describe "when enforce_license is set to false" do
+          it "should not check the license acceptance" do
+            expect(@app).to_not receive(:check_license_acceptance)
+            @app.run(enforce_license: false)
+          end
+        end
+
         it "should run the actual application" do
           expect(@app).to receive(:run_application).and_return(true)
           @app.run