summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLance Albertson <lance@osuosl.org>2021-04-02 17:04:46 -0700
committerLance Albertson <lance@osuosl.org>2021-04-07 15:06:55 -0700
commit594b539c131b765a3abe161e2a4e832e75cf0db1 (patch)
treec25849445d57280ebb47a09f87c138d426e81ce7
parent0dc00fae7b99d0cca1cc43c6539d0e79221c31ad (diff)
downloadchef-594b539c131b765a3abe161e2a4e832e75cf0db1.tar.gz
Add centos_stream_platform? helper
This checks /etc/os-release to see if the system is CentOS Stream. Signed-off-by: Lance Albertson <lance@osuosl.org>
-rw-r--r--chef-utils/lib/chef-utils/dsl/platform.rb12
-rw-r--r--chef-utils/spec/unit/dsl/platform_spec.rb133
2 files changed, 118 insertions, 27 deletions
diff --git a/chef-utils/lib/chef-utils/dsl/platform.rb b/chef-utils/lib/chef-utils/dsl/platform.rb
index f44cb811bb..c90117cb33 100644
--- a/chef-utils/lib/chef-utils/dsl/platform.rb
+++ b/chef-utils/lib/chef-utils/dsl/platform.rb
@@ -17,11 +17,13 @@
#
require_relative "../internal"
+require_relative "train_helpers"
module ChefUtils
module DSL
module Platform
include Internal
+ include TrainHelpers
# NOTE: if you are adding new platform helpers they should all have the `_platform?` suffix.
# DO NOT add new short aliases without the suffix (they will be deprecated in the future)
@@ -123,6 +125,16 @@ module ChefUtils
# chef-sugar backcompat method
alias_method :centos?, :centos_platform?
+ # Determine if the current node is CentOS Stream.
+ #
+ # @since 17.0
+ #
+ # @return [Boolean]
+ #
+ def centos_stream_platform?
+ file_exist?("/etc/os-release") && file_read("/etc/os-release").match?("CentOS Stream")
+ end
+
# Determine if the current node is Oracle Linux.
#
# @param [Chef::Node] node the node to check
diff --git a/chef-utils/spec/unit/dsl/platform_spec.rb b/chef-utils/spec/unit/dsl/platform_spec.rb
index 216e15f112..7d2b353b38 100644
--- a/chef-utils/spec/unit/dsl/platform_spec.rb
+++ b/chef-utils/spec/unit/dsl/platform_spec.rb
@@ -21,34 +21,67 @@ require "fauxhai"
def platform_reports_true_for(*args)
args.each do |method|
- it "reports true for #{method} on the module given a node" do
- expect(described_class.send(method, node)).to be true
- end
- it "reports true for #{method} when mixed into a class with a node" do
- expect(thing_with_a_node.send(method, node)).to be true
- end
- it "reports true for #{method} when mixed into a class with a run_context" do
- expect(thing_with_a_run_context.send(method, node)).to be true
- end
- it "reports true for #{method} when mixed into a class with the dsl" do
- expect(thing_with_the_dsl.send(method, node)).to be true
- end
- it "reports true for #{method} on the main class give a node" do
- expect(ChefUtils.send(method, node)).to be true
+ if method.match?("centos_stream_platform")
+ it "reports true for #{method} on the module given a node" do
+ expect(described_class.send(method)).to be true
+ end
+ it "reports true for #{method} when mixed into a class with a node" do
+ expect(thing_with_a_node.send(method)).to be true
+ end
+ it "reports true for #{method} when mixed into a class with a run_context" do
+ expect(thing_with_a_run_context.send(method)).to be true
+ end
+ it "reports true for #{method} when mixed into a class with the dsl" do
+ expect(thing_with_the_dsl.send(method)).to be true
+ end
+ it "reports true for #{method} on the main class give a node" do
+ expect(ChefUtils.send(method)).to be true
+ end
+ else
+ it "reports true for #{method} on the module given a node" do
+ expect(described_class.send(method, node)).to be true
+ end
+ it "reports true for #{method} when mixed into a class with a node" do
+ expect(thing_with_a_node.send(method, node)).to be true
+ end
+ it "reports true for #{method} when mixed into a class with a run_context" do
+ expect(thing_with_a_run_context.send(method, node)).to be true
+ end
+ it "reports true for #{method} when mixed into a class with the dsl" do
+ expect(thing_with_the_dsl.send(method, node)).to be true
+ end
+ it "reports true for #{method} on the main class give a node" do
+ expect(ChefUtils.send(method, node)).to be true
+ end
end
end
- (PLATFORM_HELPERS - args).each do |method|
- it "reports false for #{method} on the module given a node" do
- expect(described_class.send(method, node)).to be false
- end
- it "reports false for #{method} when mixed into a class with a node" do
- expect(thing_with_a_node.send(method, node)).to be false
- end
- it "reports false for #{method} when mixed into a class with the dsl" do
- expect(thing_with_the_dsl.send(method, node)).to be false
- end
- it "reports false for #{method} on the main class give a node" do
- expect(ChefUtils.send(method, node)).to be false
+ (PLATFORM_HELPERS - ChefUtils::DSL::TrainHelpers.methods - args).each do |method|
+ if method.match?("centos_stream_platform")
+ it "reports false for #{method} on the module given a node" do
+ expect(described_class.send(method)).to be false
+ end
+ it "reports false for #{method} when mixed into a class with a node" do
+ expect(thing_with_a_node.send(method)).to be false
+ end
+ it "reports false for #{method} when mixed into a class with the dsl" do
+ expect(thing_with_the_dsl.send(method)).to be false
+ end
+ it "reports false for #{method} on the main class give a node" do
+ expect(ChefUtils.send(method)).to be false
+ end
+ else
+ it "reports false for #{method} on the module given a node" do
+ expect(described_class.send(method, node)).to be false
+ end
+ it "reports false for #{method} when mixed into a class with a node" do
+ expect(thing_with_a_node.send(method, node)).to be false
+ end
+ it "reports false for #{method} when mixed into a class with the dsl" do
+ expect(thing_with_the_dsl.send(method, node)).to be false
+ end
+ it "reports false for #{method} on the main class give a node" do
+ expect(ChefUtils.send(method, node)).to be false
+ end
end
end
end
@@ -93,7 +126,7 @@ RSpec.describe ChefUtils::DSL::Platform do
( HELPER_MODULES - [ described_class ] ).each do |klass|
it "does not have methods that collide with #{klass}" do
- expect((klass.methods - Module.methods) & PLATFORM_HELPERS).to be_empty
+ expect((klass.methods - Module.methods - ChefUtils::DSL::TrainHelpers.methods ) & PLATFORM_HELPERS).to be_empty
end
end
@@ -236,3 +269,49 @@ RSpec.describe ChefUtils::DSL::Platform do
end
end
+
+RSpec.describe ChefUtils::DSL::Platform do
+ class PlatformTestClass
+ include ChefUtils::DSL::Platform
+ end
+
+ let(:test_instance) { PlatformTestClass.new }
+
+ let(:os_release_stream) do
+ <<~OS_RELEASE
+ NAME="CentOS Stream"
+ VERSION="8"
+ ID="centos"
+ ID_LIKE="rhel fedora"
+ VERSION_ID="8"
+ PRETTY_NAME="CentOS Stream 8"
+ OS_RELEASE
+ end
+
+ let(:os_release_centos) do
+ <<~OS_RELEASE
+ NAME="CentOS Linux"
+ VERSION="8"
+ ID="centos"
+ ID_LIKE="rhel fedora"
+ VERSION_ID="8"
+ PRETTY_NAME="CentOS Linux 8"
+ OS_RELEASE
+ end
+
+ context "on centos stream" do
+ it "returns true if on centos_stream_platform?" do
+ expect(File).to receive(:exist?).with("/etc/os-release").and_return(true)
+ expect(File).to receive(:open).with("/etc/os-release").and_return(StringIO.new(os_release_stream))
+ expect(test_instance.centos_stream_platform?).to be true
+ end
+ end
+
+ context "on centos linux" do
+ it "returns false if on centos_stream_platform?" do
+ expect(File).to receive(:exist?).with("/etc/os-release").and_return(true)
+ expect(File).to receive(:open).with("/etc/os-release").and_return(StringIO.new(os_release_centos))
+ expect(test_instance.centos_stream_platform?).to be false
+ end
+ end
+end