diff options
| author | Tim Smith <tsmith@chef.io> | 2020-08-03 15:55:13 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-03 15:55:13 -0700 |
| commit | 0e3e4ba243264a4e08c807cdd4c5450904b76f9b (patch) | |
| tree | 563e7833d19286cb22213f10b6c80e6dce2e344a | |
| parent | 8ed7a20faaa13c50fd69da35a41a7633951c655d (diff) | |
| parent | 413632d2e593d520231801423a4a9d8ea30591e0 (diff) | |
| download | chef-0e3e4ba243264a4e08c807cdd4c5450904b76f9b.tar.gz | |
Merge pull request #10245 from chef/rubocop_Performance_RangeInclude
Resolve Performance/RangeInclude warnings
| -rw-r--r-- | lib/chef/resource/windows_firewall_rule.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/chef/resource/windows_firewall_rule.rb b/lib/chef/resource/windows_firewall_rule.rb index f1a039267d..7398fb6eb5 100644 --- a/lib/chef/resource/windows_firewall_rule.rb +++ b/lib/chef/resource/windows_firewall_rule.rb @@ -273,11 +273,11 @@ class Chef requirements.assert(:create) do |a| a.assertion do if new_resource.icmp_type.is_a?(Integer) - (0..255).include?(new_resource.icmp_type) + (0..255).cover?(new_resource.icmp_type) elsif new_resource.icmp_type.is_a?(String) && !new_resource.icmp_type.include?(":") && new_resource.protocol.start_with?("ICMP") - (0..255).include?(new_resource.icmp_type.to_i) + (0..255).cover?(new_resource.icmp_type.to_i) elsif new_resource.icmp_type.is_a?(String) && new_resource.icmp_type.include?(":") && new_resource.protocol.start_with?("ICMP") - new_resource.icmp_type.split(":").all? { |type| (0..255).include?(type.to_i) } + new_resource.icmp_type.split(":").all? { |type| (0..255).cover?(type.to_i) } else true end |