summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLamont Granquist <lamont@scriptkiddie.org>2020-05-07 18:17:49 -0700
committerLamont Granquist <lamont@scriptkiddie.org>2020-05-07 18:17:49 -0700
commit4ad4a59320176caf7c1bc75951fb8ed6dcb0c7ae (patch)
treedba9aa6dd3e8bedb69dba380f0d7c93e4cc23314
parent38ae8547689d560b57a7754686a34890fc451300 (diff)
downloadchef-4ad4a59320176caf7c1bc75951fb8ed6dcb0c7ae.tar.gz
Remove the config hash defaultslcg/remove-config-defaults
The backport to Chef-15 made me realize that this all needs to be deleted. The :hints looks necessary to initialize that to a Hash and to create the config context to begin with. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
-rw-r--r--chef-config/lib/chef-config/config.rb27
1 files changed, 0 insertions, 27 deletions
diff --git a/chef-config/lib/chef-config/config.rb b/chef-config/lib/chef-config/config.rb
index e7a92c6b6d..f34f6d82a3 100644
--- a/chef-config/lib/chef-config/config.rb
+++ b/chef-config/lib/chef-config/config.rb
@@ -847,33 +847,6 @@ module ChefConfig
# knife configuration data
config_context :knife do
- # XXX: none of these default values are applied to knife (and would create a backcompat
- # break in knife if this bug was fixed since many of the defaults below are wrong). this appears
- # to be the start of an attempt to be able to use config_strict_mode true? if so, this approach
- # is fraught with peril because this namespace is used by every knife plugin in the wild and
- # we would need to validate every cli option in every knife attribute out there and list them all here.
- #
- # based on the way that people may define `knife[:foobar] = "something"` for the knife-foobar
- # gem plugin i'm pretty certain we can never turn on anything like config_string_mode since
- # any config value may be a typo or it may be in some gem in some knife plugin we don't know about.
- #
- # we do still need to maintain at least one of these so that the knife config hash gets
- # created.
- #
- # this whole situation is deeply unsatisfying.
- default :ssh_port, nil
- default :ssh_user, nil
- default :ssh_attribute, nil
- default :ssh_gateway, nil
- default :ssh_gateway_identity, nil
- default :bootstrap_version, nil
- default :bootstrap_proxy, nil
- default :bootstrap_template, nil
- default :secret, nil
- default :secret_file, nil
- default :host_key_verify, nil
- default :forward_agent, nil
- default :sort_status_reverse, nil
default :hints, {}
end