summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorskippy <jonathan.yates.jones@gmail.com>2019-11-17 17:31:11 +0000
committerskippy <jonathan.yates.jones@gmail.com>2019-11-17 17:31:11 +0000
commit37c52233266920f457e5053607cec6d13e66144c (patch)
tree1fd2e882f9c4d05a1243f4f1b3c90cb81edb624d
parent611611b50dfeea77d4de92f3746ed0b681209286 (diff)
downloadchef-37c52233266920f457e5053607cec6d13e66144c.tar.gz
re-un-inverted my previous 3am coding adventure in double negatives
Signed-off-by: Jonathan Jones <gitmaster@thespooky.house>
-rw-r--r--lib/chef/provider/user/linux.rb2
-rw-r--r--spec/support/shared/unit/provider/useradd_based_user_provider.rb6
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/chef/provider/user/linux.rb b/lib/chef/provider/user/linux.rb
index d905e1985f..529d8806d3 100644
--- a/lib/chef/provider/user/linux.rb
+++ b/lib/chef/provider/user/linux.rb
@@ -61,7 +61,7 @@ class Chef
if updating_home?
if new_resource.manage_home
home_dir_not_exist = shell_out("test", "-d", new_resource.home, returns: [1])
- if home_dir_not_exist
+ if home_dir_not_exist.error?
ret_codes << 12
end
end
diff --git a/spec/support/shared/unit/provider/useradd_based_user_provider.rb b/spec/support/shared/unit/provider/useradd_based_user_provider.rb
index dc260460cd..a5b96af703 100644
--- a/spec/support/shared/unit/provider/useradd_based_user_provider.rb
+++ b/spec/support/shared/unit/provider/useradd_based_user_provider.rb
@@ -160,7 +160,7 @@ shared_examples_for "a useradd-based user provider" do |supported_useradd_option
"-d", "/Users/mud",
"-m",
"adam"])
- command.concat([{:returns=>[0,12]}])
+ command.concat([{:returns=>[0]}])
expect(provider).to receive(:shell_out_compacted!).with(*command).and_return(true)
provider.create_user
end
@@ -210,7 +210,7 @@ shared_examples_for "a useradd-based user provider" do |supported_useradd_option
"-d", "/Users/mud",
"-m",
"adam"]
- command.concat([{:returns=>[0,12]}])
+ command.concat([{:returns=>[0]}])
expect(provider).to receive(:shell_out_compacted!).with(*command).and_return(true)
provider.manage_user
end
@@ -222,7 +222,7 @@ shared_examples_for "a useradd-based user provider" do |supported_useradd_option
"-d", "/Users/mud",
"-m",
"adam"]
- command.concat([{:returns=>[0,12]}])
+ command.concat([{:returns=>[0]}])
expect(provider).to receive(:shell_out_compacted!).with(*command).and_return(true)
provider.manage_user
end