Instead of silently failing, raise an exception for bad reporter types.

Signed-off-by: Pete Higgins <pete@peterhiggins.org>

2 files changed, 3 insertions, 6 deletions

diff --git a/lib/chef/compliance/runner.rb b/lib/chef/compliance/runner.rb
index 978dc33b32..8948d9c895 100644
--- a/lib/chef/compliance/runner.rb
+++ b/lib/chef/compliance/runner.rb
@@ -239,8 +239,7 @@ class Chef
         when "audit-enforcer"
           Chef::Compliance::Reporter::ComplianceEnforcer.new
         else
-          logger.warn "'#{reporter_type}' is not a supported reporter for Compliance Phase."
-          nil
+          raise "'#{reporter_type}' is not a supported reporter for Compliance Phase."
         end
       end
 
diff --git a/spec/unit/compliance/runner_spec.rb b/spec/unit/compliance/runner_spec.rb
index e1ca1c5d3a..f9f3d61dd2 100644
--- a/spec/unit/compliance/runner_spec.rb
+++ b/spec/unit/compliance/runner_spec.rb
@@ -133,10 +133,8 @@ describe Chef::Compliance::Runner do
       end
     end
 
-    it "returns nil for unexpected reporter value" do
-      expect(logger).to receive(:warn).with("'tacos' is not a supported reporter for Chef Infra Client's Compliance Phase")
-
-      expect(runner.reporter("tacos")).to be_nil
+    it "fails with unexpected reporter value" do
+      expect { runner.reporter("tacos") }.to raise_error(/'tacos' is not a supported reporter for Compliance Phase/)
     end
   end
 end