summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLamont Granquist <lamont@scriptkiddie.org>2018-02-13 09:44:37 -0800
committerLamont Granquist <lamont@scriptkiddie.org>2018-02-13 09:44:37 -0800
commit4c73efee6f0962f66139bc54ed1dca2d20803b9e (patch)
tree97b4a44f6bf46a06c9b67d5313560b91f04c605f
parent4aa6f211880a840721104592c0b65b6959cec88d (diff)
downloadchef-4c73efee6f0962f66139bc54ed1dca2d20803b9e.tar.gz
add specs
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
-rw-r--r--lib/chef/node_map.rb3
-rw-r--r--spec/unit/node_map_spec.rb29
2 files changed, 30 insertions, 2 deletions
diff --git a/lib/chef/node_map.rb b/lib/chef/node_map.rb
index 4de1526b8a..0406b3c1d6 100644
--- a/lib/chef/node_map.rb
+++ b/lib/chef/node_map.rb
@@ -120,6 +120,9 @@ class Chef
# Remove a class from all its matchers in the node_map, will remove mappings completely if its the last matcher left
#
+ # Note that this leaks the internal structure out a bit, but the main consumer of this (poise/halite) cares only about
+ # the keys in the returned Hash.
+ #
# @param klass [Class] the class to seek and destroy
#
# @return [Hash] deleted entries in the same format as the @map
diff --git a/spec/unit/node_map_spec.rb b/spec/unit/node_map_spec.rb
index 67bb741ec5..27ec4d5f1a 100644
--- a/spec/unit/node_map_spec.rb
+++ b/spec/unit/node_map_spec.rb
@@ -19,6 +19,9 @@
require "spec_helper"
require "chef/node_map"
+class Foo; end
+class Bar; end
+
describe Chef::NodeMap do
let(:node_map) { Chef::NodeMap.new }
@@ -120,8 +123,6 @@ describe Chef::NodeMap do
end
describe "ordering classes" do
- class Foo; end
- class Bar; end
it "last writer wins when its reverse alphabetic order" do
node_map.set(:thing, Foo)
node_map.set(:thing, Bar)
@@ -135,6 +136,30 @@ describe Chef::NodeMap do
end
end
+ describe "deleting classes" do
+ it "deletes a class and removes the mapping completely" do
+ node_map.set(:thing, Bar)
+ expect( node_map.delete_class(Bar) ).to eql({:thing=>[{:klass=>Bar}]})
+ expect( node_map.get(node, :thing) ).to eql(nil)
+ end
+
+ it "deletes a class and leaves the mapping that still has an entry" do
+ node_map.set(:thing, Bar)
+ node_map.set(:thing, Foo)
+ expect( node_map.delete_class(Bar) ).to eql({:thing=>[{:klass=>Bar}]})
+ expect( node_map.get(node, :thing) ).to eql(Foo)
+ end
+
+ it "handles deleting classes from multiple keys" do
+ node_map.set(:thing1, Bar)
+ node_map.set(:thing2, Bar)
+ node_map.set(:thing2, Foo)
+ expect( node_map.delete_class(Bar) ).to eql({:thing1=>[{:klass=>Bar}], :thing2=>[{:klass=>Bar}]})
+ expect( node_map.get(node, :thing1) ).to eql(nil)
+ expect( node_map.get(node, :thing2) ).to eql(Foo)
+ end
+ end
+
describe "with a block doing platform_version checks" do
before do
node_map.set(:thing, :foo, platform_family: "rhel") do |node|