diff options
author | Jay Mundrawala <jdmundrawala@gmail.com> | 2015-04-30 13:00:01 -0700 |
---|---|---|
committer | Jay Mundrawala <jdmundrawala@gmail.com> | 2015-04-30 13:03:02 -0700 |
commit | bbeea431eeb0ab1ef443b9342be8225a567c7a8d (patch) | |
tree | d988fb65e519207a9acfa8a6ec7d6e37b8a2e74b | |
parent | 2d7f8a477b68767373068f363f785b84b9b832ae (diff) | |
download | chef-jdm/winstaller-idempotent.tar.gz |
windows_package is idempotent againjdm/winstaller-idempotent
This was broken in #3034. The issue is that the package does not get detected
as installed because the version that is installed has \x00 at the end,
while the version from the msi does not. This fails comparison, and we fall
into code that does not use source and thus requires candidate version and we
die. (Or something like that)
Solves #3316
-rw-r--r-- | lib/chef/win32/api/installer.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/chef/win32/api/installer.rb b/lib/chef/win32/api/installer.rb index 6864a26e7d..b4851eccf1 100644 --- a/lib/chef/win32/api/installer.rb +++ b/lib/chef/win32/api/installer.rb @@ -158,7 +158,7 @@ UINT MsiCloseHandle( raise Chef::Exceptions::Package, msg end - version + version.chomp(0.chr) end end end |