summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortyler-ball <tyleraball@gmail.com>2014-09-10 18:18:41 -0700
committertyler-ball <tyleraball@gmail.com>2014-09-29 08:31:08 -0700
commitce03bb01bff58fac8d65b402e4f1fd424f85ca6e (patch)
tree8aa08c82d1c3fd94b2849562bb8504edabaafb8d
parentefcaafeaae481a7b49e5e9b44b79218cee20385d (diff)
downloadchef-ce03bb01bff58fac8d65b402e4f1fd424f85ca6e.tar.gz
Fixing broken tests and updating all tests to (attempt) to use describe/context blocks for readability
-rw-r--r--lib/chef/knife/data_bag_show.rb2
-rw-r--r--spec/unit/knife/data_bag_common_spec.rb1
-rw-r--r--spec/unit/knife/data_bag_create_spec.rb2
-rw-r--r--spec/unit/knife/data_bag_edit_spec.rb7
-rw-r--r--spec/unit/knife/data_bag_from_file_spec.rb213
-rw-r--r--spec/unit/knife/data_bag_show_spec.rb146
6 files changed, 174 insertions, 197 deletions
diff --git a/lib/chef/knife/data_bag_show.rb b/lib/chef/knife/data_bag_show.rb
index 72f76734e7..2a759d1b43 100644
--- a/lib/chef/knife/data_bag_show.rb
+++ b/lib/chef/knife/data_bag_show.rb
@@ -35,7 +35,7 @@ class Chef
def run
display = case @name_args.length
when 2 # Bag and Item names provided
- secret = read_secret
+ secret = encryption_secret_provided? ? read_secret : nil
raw_data = Chef::DataBagItem.load(@name_args[0], @name_args[1]).raw_data
encrypted = encrypted?(raw_data)
diff --git a/spec/unit/knife/data_bag_common_spec.rb b/spec/unit/knife/data_bag_common_spec.rb
index ebba9033ba..3e4ebf5026 100644
--- a/spec/unit/knife/data_bag_common_spec.rb
+++ b/spec/unit/knife/data_bag_common_spec.rb
@@ -46,7 +46,6 @@ describe Chef::Knife::DataBagCommon do
end
after do
- Chef::Config.reset
secret_file.close
secret_file.unlink
end
diff --git a/spec/unit/knife/data_bag_create_spec.rb b/spec/unit/knife/data_bag_create_spec.rb
index ae34b68a13..c31c88577d 100644
--- a/spec/unit/knife/data_bag_create_spec.rb
+++ b/spec/unit/knife/data_bag_create_spec.rb
@@ -28,7 +28,7 @@ describe Chef::Knife::DataBagCreate do
k
end
- let(:rest) { double("ChefSpecs::ChefRest") }
+ let(:rest) { double("Chef::REST") }
let(:stdout) { StringIO.new }
let(:bag_name) { "sudoing_admins" }
diff --git a/spec/unit/knife/data_bag_edit_spec.rb b/spec/unit/knife/data_bag_edit_spec.rb
index 6a7c8b33b2..96bfc3cbf6 100644
--- a/spec/unit/knife/data_bag_edit_spec.rb
+++ b/spec/unit/knife/data_bag_edit_spec.rb
@@ -29,7 +29,7 @@ describe Chef::Knife::DataBagEdit do
let(:knife) do
k = Chef::Knife::DataBagEdit.new
allow(k).to receive(:rest).and_return(rest)
- allow(k).to receive(:stdout).and_return(stdout)
+ allow(k.ui).to receive(:stdout).and_return(stdout)
k
end
@@ -38,7 +38,7 @@ describe Chef::Knife::DataBagEdit do
let(:edited_hash) { {"login_name" => "rho", "id" => "item_name", "new_key" => "new_value"} }
let(:edited_db) {Chef::DataBagItem.from_hash(edited_hash)}
- let(:rest) { double("ChefSpecs::ChefRest") }
+ let(:rest) { double("Chef::REST") }
let(:stdout) { StringIO.new }
let(:bag_name) { "sudoing_admins" }
@@ -46,14 +46,13 @@ describe Chef::Knife::DataBagEdit do
let(:secret) { "abc123SECRET" }
- let(:raw_hash) {{ "login_name" => "alphaomega", "id" => item_name }}
-
let(:config) { {} }
it "requires data bag and item arguments" do
knife.name_args = []
expect(stdout).to receive(:puts).twice.with(anything)
expect {knife.run}.to exit_with_code(1)
+ expect(stdout.string).to eq("")
end
it "saves edits on a data bag item" do
diff --git a/spec/unit/knife/data_bag_from_file_spec.rb b/spec/unit/knife/data_bag_from_file_spec.rb
index 1ad6b4712c..150ad42148 100644
--- a/spec/unit/knife/data_bag_from_file_spec.rb
+++ b/spec/unit/knife/data_bag_from_file_spec.rb
@@ -26,79 +26,95 @@ Chef::Knife::DataBagFromFile.load_deps
describe Chef::Knife::DataBagFromFile do
before :each do
- Chef::Config[:node_name] = "webmonkey.example.com"
- @knife = Chef::Knife::DataBagFromFile.new
- @rest = double("Chef::REST")
- @knife.stub(:rest).and_return(@rest)
- @stdout = StringIO.new
- @knife.ui.stub(:stdout).and_return(@stdout)
- @tmp_dir = Dir.mktmpdir
- @db_folder = File.join(@tmp_dir, 'data_bags', 'bag_name')
- FileUtils.mkdir_p(@db_folder)
- @db_file = Tempfile.new(["data_bag_from_file_test", ".json"], @db_folder)
- @db_file2 = Tempfile.new(["data_bag_from_file_test2", ".json"], @db_folder)
- @db_folder2 = File.join(@tmp_dir, 'data_bags', 'bag_name2')
- FileUtils.mkdir_p(@db_folder2)
- @db_file3 = Tempfile.new(["data_bag_from_file_test3", ".json"], @db_folder2)
- @plain_data = {
- "id" => "item_name",
- "greeting" => "hello",
- "nested" => { "a1" => [1, 2, 3], "a2" => { "b1" => true }}
- }
- @db_file.write(@plain_data.to_json)
- @db_file.flush
- @knife.instance_variable_set(:@name_args, ['bag_name', @db_file.path])
+ Chef::Config[:node_name] = "webmonkey.example.com"
+ FileUtils.mkdir_p([db_folder, db_folder2])
+ db_file.write(plain_data.to_json)
+ db_file.flush
+ knife.name_args = [bag_name, db_file.path]
+ allow(knife).to receive(:config).and_return(config)
end
# We have to explicitly clean up Tempfile on Windows because it said so.
after :each do
- @db_file.close
- @db_file2.close
- @db_file3.close
- FileUtils.rm_rf(@db_folder)
- FileUtils.rm_rf(@db_folder2)
- FileUtils.remove_entry_secure @tmp_dir
+ db_file.close
+ db_file2.close
+ db_file3.close
+ FileUtils.rm_rf(db_folder)
+ FileUtils.rm_rf(db_folder2)
+ FileUtils.remove_entry_secure tmp_dir
end
+ let(:knife) do
+ k = Chef::Knife::DataBagFromFile.new
+ allow(k).to receive(:rest).and_return(rest)
+ allow(k.ui).to receive(:stdout).and_return(stdout)
+ k
+ end
+
+ let(:tmp_dir) { Dir.mktmpdir }
+ let(:db_folder) { File.join(tmp_dir, data_bags_path, bag_name) }
+ let(:db_file) { Tempfile.new(["data_bag_from_file_test", ".json"], db_folder) }
+ let(:db_file2) { Tempfile.new(["data_bag_from_file_test2", ".json"], db_folder) }
+ let(:db_folder2) { File.join(tmp_dir, data_bags_path, bag_name2) }
+ let(:db_file3) { Tempfile.new(["data_bag_from_file_test3", ".json"], db_folder2) }
+
+ def plain_bag(b = bag_name)
+ data_bag = double("Chef::DataBagItem")
+ expect(data_bag).to receive(:data_bag).with(b)
+ expect(data_bag).to receive(:raw_data=).with(plain_data)
+ expect(data_bag).to receive(:save)
+ expect(data_bag).to receive(:data_bag)
+ expect(data_bag).to receive(:id)
+ data_bag
+ end
+ let(:data_bags_path) { "data_bags" }
+ let(:plain_data) { {
+ "id" => "item_name",
+ "greeting" => "hello",
+ "nested" => { "a1" => [1, 2, 3], "a2" => { "b1" => true }}
+ } }
+
+ let(:rest) { double("Chef::REST") }
+ let(:stdout) { StringIO.new }
+
+ let(:bag_name) { "sudoing_admins" }
+ let(:bag_name2) { "sudoing_admins2" }
+ let(:item_name) { "ME" }
+
+ let(:secret) { "abc123SECRET" }
+
+ let(:config) { {} }
+
it "loads from a file and saves" do
- @knife.loader.should_receive(:load_from).with("data_bags", 'bag_name', @db_file.path).and_return(@plain_data)
- dbag = Chef::DataBagItem.new
- Chef::DataBagItem.stub(:new).and_return(dbag)
- dbag.should_receive(:save)
- @knife.run
-
- dbag.data_bag.should == 'bag_name'
- dbag.raw_data.should == @plain_data
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name, db_file.path).and_return(plain_data)
+ expect(Chef::DataBagItem).to receive(:new).and_return(plain_bag)
+
+ knife.run
end
- it "loads all from a mutiple files and saves" do
- @knife.name_args = [ 'bag_name', @db_file.path, @db_file2.path ]
- @knife.loader.should_receive(:load_from).with("data_bags", 'bag_name', @db_file.path).and_return(@plain_data)
- @knife.loader.should_receive(:load_from).with("data_bags", 'bag_name', @db_file2.path).and_return(@plain_data)
- dbag = Chef::DataBagItem.new
- Chef::DataBagItem.stub(:new).and_return(dbag)
- dbag.should_receive(:save).twice
- @knife.run
-
- dbag.data_bag.should == 'bag_name'
- dbag.raw_data.should == @plain_data
+ it "loads all from multiple files and saves" do
+ knife.name_args = [ bag_name, db_file.path, db_file2.path ]
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name, db_file.path).and_return(plain_data)
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name, db_file2.path).and_return(plain_data)
+ expect(Chef::DataBagItem).to receive(:new).twice.and_return(plain_bag, plain_bag)
+
+ knife.run
end
it "loads all from a folder and saves" do
- @knife.name_args = [ 'bag_name', @db_folder ]
- @knife.loader.should_receive(:load_from).with("data_bags", 'bag_name', @db_file.path).and_return(@plain_data)
- @knife.loader.should_receive(:load_from).with("data_bags", 'bag_name', @db_file2.path).and_return(@plain_data)
- dbag = Chef::DataBagItem.new
- Chef::DataBagItem.stub(:new).and_return(dbag)
- dbag.should_receive(:save).twice
- @knife.run
+ knife.name_args = [ bag_name, db_folder ]
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name, db_file.path).and_return(plain_data)
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name, db_file2.path).and_return(plain_data)
+ expect(Chef::DataBagItem).to receive(:new).twice.and_return(plain_bag, plain_bag)
+
+ knife.run
end
describe "loading all data bags" do
before do
@pwd = Dir.pwd
- Dir.chdir(@tmp_dir)
+ Dir.chdir(tmp_dir)
end
after do
@@ -106,88 +122,49 @@ describe Chef::Knife::DataBagFromFile do
end
it "loads all data bags when -a or --all options is provided" do
- @knife.name_args = []
- @knife.stub(:config).and_return({:all => true})
- @knife.loader.should_receive(:load_from).with("data_bags", "bag_name", File.basename(@db_file.path)).
- and_return(@plain_data)
- @knife.loader.should_receive(:load_from).with("data_bags", "bag_name", File.basename(@db_file2.path)).
- and_return(@plain_data)
- @knife.loader.should_receive(:load_from).with("data_bags", "bag_name2", File.basename(@db_file3.path)).
- and_return(@plain_data)
- dbag = Chef::DataBagItem.new
- Chef::DataBagItem.stub(:new).and_return(dbag)
- dbag.should_receive(:save).exactly(3).times
- @knife.run
+ knife.name_args = []
+ config[:all] = true
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name, File.basename(db_file.path)).and_return(plain_data)
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name, File.basename(db_file2.path)).and_return(plain_data)
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name2, File.basename(db_file3.path)).and_return(plain_data)
+ expect(Chef::DataBagItem).to receive(:new).exactly(3).times.and_return(plain_bag, plain_bag, plain_bag(bag_name2))
+
+ knife.run
end
it "loads all data bags items when -a or --all options is provided" do
- @knife.name_args = ["bag_name2"]
- @knife.stub(:config).and_return({:all => true})
- @knife.loader.should_receive(:load_from).with("data_bags", "bag_name2", File.basename(@db_file3.path)).
- and_return(@plain_data)
- dbag = Chef::DataBagItem.new
- Chef::DataBagItem.stub(:new).and_return(dbag)
- dbag.should_receive(:save)
- @knife.run
- dbag.data_bag.should == 'bag_name2'
- dbag.raw_data.should == @plain_data
+ knife.name_args = [bag_name2]
+ config[:all] = true
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name2, File.basename(db_file3.path)).and_return(plain_data)
+ expect(Chef::DataBagItem).to receive(:new).and_return(plain_bag(bag_name2))
+
+ knife.run
end
end
describe "encrypted data bag items" do
before(:each) do
- @secret = "abc123SECRET"
- @enc_data = Chef::EncryptedDataBagItem.encrypt_data_bag_item(@plain_data,
- @secret)
-
- # Random IV is used each time the data bag item is encrypted, so values
- # will not be equal if we re-encrypt.
- Chef::EncryptedDataBagItem.should_receive(:encrypt_data_bag_item).and_return(@enc_data)
-
- @secret_file = Tempfile.new("encrypted_data_bag_secret_file_test")
- @secret_file.puts(@secret)
- @secret_file.flush
- end
-
- after do
- @secret_file.close
- @secret_file.unlink
+ expect(knife).to receive(:encryption_secret_provided?).and_return(true)
+ expect(knife).to receive(:read_secret).and_return(secret)
+ # TODO this should return encrypted data
+ expect(Chef::EncryptedDataBagItem).to receive(:encrypt_data_bag_item).with(plain_data, secret).and_return(plain_data)
end
it "encrypts values when given --secret" do
- @knife.stub(:config).and_return({:secret => @secret})
-
- @knife.loader.should_receive(:load_from).with("data_bags", "bag_name", @db_file.path).and_return(@plain_data)
- dbag = Chef::DataBagItem.new
- Chef::DataBagItem.stub(:new).and_return(dbag)
- dbag.should_receive(:save)
- @knife.run
- dbag.data_bag.should == 'bag_name'
- dbag.raw_data.should == @enc_data
- end
-
- it "encrypts values when given --secret_file" do
- @knife.stub(:config).and_return({:secret_file => @secret_file.path})
+ expect(knife.loader).to receive(:load_from).with(data_bags_path, bag_name, db_file.path).and_return(plain_data)
+ expect(Chef::DataBagItem).to receive(:new).and_return(plain_bag)
- @knife.loader.stub(:load_from).with("data_bags", 'bag_name', @db_file.path).and_return(@plain_data)
- dbag = Chef::DataBagItem.new
- Chef::DataBagItem.stub(:new).and_return(dbag)
- dbag.should_receive(:save)
- @knife.run
- dbag.data_bag.should == 'bag_name'
- dbag.raw_data.should == @enc_data
+ knife.run
end
end
describe "command line parsing" do
it "prints help if given no arguments" do
- @knife.instance_variable_set(:@name_args, [])
- lambda { @knife.run }.should raise_error(SystemExit)
- help_text = "knife data bag from file BAG FILE|FOLDER [FILE|FOLDER..] (options)"
- help_text_regex = Regexp.new("^#{Regexp.escape(help_text)}")
- @stdout.string.should match(help_text_regex)
+ knife.name_args = [bag_name]
+ expect {knife.run}.to exit_with_code(1)
+ expect(stdout.string).to start_with("knife data bag from file BAG FILE|FOLDER [FILE|FOLDER..] (options)")
end
end
diff --git a/spec/unit/knife/data_bag_show_spec.rb b/spec/unit/knife/data_bag_show_spec.rb
index ac368ed6da..49632a2911 100644
--- a/spec/unit/knife/data_bag_show_spec.rb
+++ b/spec/unit/knife/data_bag_show_spec.rb
@@ -25,97 +25,99 @@ require 'chef/json_compat'
require 'tempfile'
describe Chef::Knife::DataBagShow do
+
before do
- Chef::Config[:node_name] = "webmonkey.example.com"
- @knife = Chef::Knife::DataBagShow.new
- @knife.config[:format] = 'json'
- @rest = double("Chef::REST")
- allow(@knife).to receive(:rest).and_return(@rest)
- @stdout = StringIO.new
- allow(@knife.ui).to receive(:stdout).and_return(@stdout)
+ Chef::Config[:node_name] = "webmonkey.example.com"
+ knife.name_args = [bag_name, item_name]
+ allow(knife).to receive(:config).and_return(config)
end
-
- it "prints the ids of the data bag items when given a bag name" do
- @knife.instance_variable_set(:@name_args, ['bag_o_data'])
- data_bag_contents = { "baz"=>"http://localhost:4000/data/bag_o_data/baz",
- "qux"=>"http://localhost:4000/data/bag_o_data/qux"}
- expect(Chef::DataBag).to receive(:load).and_return(data_bag_contents)
- expected = %q|[
- "baz",
- "qux"
-]|
- @knife.run
- expect(@stdout.string.strip).to eq(expected)
+ let(:knife) do
+ k = Chef::Knife::DataBagShow.new
+ allow(k).to receive(:rest).and_return(rest)
+ allow(k.ui).to receive(:stdout).and_return(stdout)
+ k
end
- it "prints the contents of the data bag item when given a bag and item name" do
- @knife.instance_variable_set(:@name_args, ['bag_o_data', 'an_item'])
- data_item = Chef::DataBagItem.new.tap {|item| item.raw_data = {"id" => "an_item", "zsh" => "victory_through_tabbing"}}
+ let(:rest) { double("Chef::REST") }
+ let(:stdout) { StringIO.new }
- expect(Chef::DataBagItem).to receive(:load).with('bag_o_data', 'an_item').and_return(data_item)
-
- @knife.run
- expect(Chef::JSONCompat.from_json(@stdout.string)).to eq(data_item.raw_data)
- end
+ let(:bag_name) { "sudoing_admins" }
+ let(:item_name) { "ME" }
- it "should pretty print the data bag contents" do
- @knife.instance_variable_set(:@name_args, ['bag_o_data', 'an_item'])
- data_item = Chef::DataBagItem.new.tap {|item| item.raw_data = {"id" => "an_item", "zsh" => "victory_through_tabbing"}}
+ let(:data_bag_contents) { { "id" => "id", "baz"=>"http://localhost:4000/data/bag_o_data/baz",
+ "qux"=>"http://localhost:4000/data/bag_o_data/qux"} }
+ let(:enc_hash) {Chef::EncryptedDataBagItem.encrypt_data_bag_item(data_bag_contents, secret)}
+ let(:data_bag) {Chef::DataBagItem.from_hash(data_bag_contents)}
+ let(:data_bag_with_encoded_hash) { Chef::DataBagItem.from_hash(enc_hash) }
+ let(:enc_data_bag) { Chef::EncryptedDataBagItem.new(enc_hash, secret) }
- expect(Chef::DataBagItem).to receive(:load).with('bag_o_data', 'an_item').and_return(data_item)
+ let(:secret) { "abc123SECRET" }
+ #
+ # let(:raw_hash) {{ "login_name" => "alphaomega", "id" => item_name }}
+ #
+ let(:config) { {format: "json"} }
- @knife.run
- expect(@stdout.string).to eql("{\n \"id\": \"an_item\",\n \"zsh\": \"victory_through_tabbing\"\n}\n")
- end
+ context "Data bag to show is encrypted" do
+ before do
+ allow(knife).to receive(:encrypted?).and_return(true)
+ end
- describe "encrypted data bag items" do
- before(:each) do
- @secret = "abc123SECRET"
- @plain_data = {
- "id" => "item_name",
- "greeting" => "hello",
- "nested" => { "a1" => [1, 2, 3], "a2" => { "b1" => true }}
- }
- @enc_data = Chef::EncryptedDataBagItem.encrypt_data_bag_item(@plain_data,
- @secret)
- @knife.instance_variable_set(:@name_args, ['bag_name', 'item_name'])
-
- @secret_file = Tempfile.new("encrypted_data_bag_secret_file_test")
- @secret_file.puts(@secret)
- @secret_file.flush
+ it "decrypts and displays the encrypted data bag when the secret is provided" do
+ expect(knife).to receive(:encryption_secret_provided?).and_return(true)
+ expect(knife).to receive(:read_secret).and_return(secret)
+ expect(Chef::DataBagItem).to receive(:load).with(bag_name, item_name).and_return(data_bag_with_encoded_hash)
+ expect(knife.ui).to receive(:info).with("Encrypted data bag detected, decrypting with provided secret.")
+ expect(Chef::EncryptedDataBagItem).to receive(:load).with(bag_name, item_name, secret).and_return(enc_data_bag)
+
+ expected = %q|baz: http://localhost:4000/data/bag_o_data/baz
+id: id
+qux: http://localhost:4000/data/bag_o_data/qux|
+ knife.run
+ expect(stdout.string.strip).to eq(expected)
end
- after do
- @secret_file.close
- @secret_file.unlink
+ it "displays the encrypted data bag when the secret is not provided" do
+ expect(knife).to receive(:encryption_secret_provided?).and_return(false)
+ expect(Chef::DataBagItem).to receive(:load).with(bag_name, item_name).and_return(data_bag_with_encoded_hash)
+ expect(knife.ui).to receive(:warn).with("Encrypted data bag detected, but no secret provided for decoding. Displaying encrypted data.")
+
+ knife.run
+ expect(stdout.string.strip).to include("baz", "qux", "cipher")
end
+ end
- it "prints the decrypted contents of an item when given --secret and --encrypted" do
- allow(@knife).to receive(:config).and_return({:secret => @secret, :encrypted => true})
- expect(Chef::EncryptedDataBagItem).to receive(:load).
- with('bag_name', 'item_name', @secret).
- and_return(Chef::EncryptedDataBagItem.new(@enc_data, @secret))
- @knife.run
- expect(Chef::JSONCompat.from_json(@stdout.string)).to eq(@plain_data)
+ context "Data bag to show is not encrypted" do
+ before do
+ allow(knife).to receive(:encrypted?).and_return(false)
+ expect(knife).to receive(:read_secret).exactly(0).times
end
- it "prints the decrypted contents of an item when given --secret_file and --encrypted" do
- allow(@knife).to receive(:config).and_return({:secret_file => @secret_file.path, :encrypted => true})
- expect(Chef::EncryptedDataBagItem).to receive(:load).
- with('bag_name', 'item_name', @secret).
- and_return(Chef::EncryptedDataBagItem.new(@enc_data, @secret))
- @knife.run
- expect(Chef::JSONCompat.from_json(@stdout.string)).to eq(@plain_data)
+ it "displays the data bag" do
+ expect(Chef::DataBagItem).to receive(:load).with(bag_name, item_name).and_return(data_bag)
+ expect(knife.ui).to receive(:info).with("Unencrypted data bag detected, ignoring any provided secret options.")
+
+ expected = %q|baz: http://localhost:4000/data/bag_o_data/baz
+id: id
+qux: http://localhost:4000/data/bag_o_data/qux|
+ knife.run
+ expect(stdout.string.strip).to eq(expected)
end
end
- describe "command line parsing" do
- it "prints help if given no arguments" do
- @knife.instance_variable_set(:@name_args, [])
- expect { @knife.run }.to raise_error(SystemExit)
- expect(@stdout.string).to match(/^knife data bag show BAG \[ITEM\] \(options\)/)
- end
+ it "displays the list of items in the data bag when only one @name_arg is provided" do
+ knife.name_args = [bag_name]
+ expect(Chef::DataBag).to receive(:load).with(bag_name).and_return({})
+
+ knife.run
+ expect(stdout.string.strip).to eq("")
+ end
+
+ it "raises an error when no @name_args are provided" do
+ knife.name_args = []
+
+ expect {knife.run}.to exit_with_code(1)
+ expect(stdout.string).to start_with("knife data bag show BAG [ITEM] (options)")
end
end