summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLamont Granquist <lamont@scriptkiddie.org>2014-03-12 17:42:20 -0700
committersersut <serdar@opscode.com>2014-05-07 16:01:08 -0700
commit58810790bd94953a4f2c28c77487f29d435b5ab5 (patch)
treedf59597799851de6b4262a87a3a8b00150f9feaa
parentb688769988158f1cb01085d6c55b6bba47b95cd3 (diff)
downloadchef-58810790bd94953a4f2c28c77487f29d435b5ab5.tar.gz
CHEF-5092: chef_gem should use omnibus `gem` binary
-rw-r--r--lib/chef/resource/chef_gem.rb3
-rw-r--r--spec/unit/resource/chef_gem_spec.rb5
2 files changed, 7 insertions, 1 deletions
diff --git a/lib/chef/resource/chef_gem.rb b/lib/chef/resource/chef_gem.rb
index d8de0edc00..af45cb93e6 100644
--- a/lib/chef/resource/chef_gem.rb
+++ b/lib/chef/resource/chef_gem.rb
@@ -28,6 +28,7 @@ class Chef
def initialize(name, run_context=nil)
super
@resource_name = :chef_gem
+ @gem_binary = RbConfig::CONFIG['bindir'] + "/gem"
@provider = Chef::Provider::Package::Rubygems
end
@@ -37,7 +38,7 @@ class Chef
raise ArgumentError, "The chef_gem resource is restricted to the current gem environment, use gem_package to install to other environments."
end
- nil
+ @gem_binary
end
def after_created
diff --git a/spec/unit/resource/chef_gem_spec.rb b/spec/unit/resource/chef_gem_spec.rb
index 1d7ca8a81e..dda65f8741 100644
--- a/spec/unit/resource/chef_gem_spec.rb
+++ b/spec/unit/resource/chef_gem_spec.rb
@@ -40,10 +40,15 @@ end
describe Chef::Resource::ChefGem, "gem_binary" do
before(:each) do
+ expect(RbConfig::CONFIG).to receive(:[]).with('bindir').and_return("/opt/chef/embedded/bin")
@resource = Chef::Resource::ChefGem.new("foo")
end
it "should raise an exception when gem_binary is set" do
lambda { @resource.gem_binary("/lol/cats/gem") }.should raise_error(ArgumentError)
end
+
+ it "should set the gem_binary based on computing it from RbConfig" do
+ expect(@resource.gem_binary).to eql("/opt/chef/embedded/bin/gem")
+ end
end