summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoah Kantrowitz <noah@coderanger.net>2015-07-19 10:50:05 -0700
committerNoah Kantrowitz <noah@coderanger.net>2015-07-19 10:50:05 -0700
commit1360d2ca0c43d22f634deb74f097edfcc73c1a3e (patch)
treefc024b6cf3d141c6908f17f468d06ae52436c5d4
parentecb66fe3ff773ad6232248ad616b0488e1b13674 (diff)
downloadchef-1360d2ca0c43d22f634deb74f097edfcc73c1a3e.tar.gz
Remove warnings about hander overrides.
These are high-volume, difficult to silence, and often not actually an error (in which case they may be impossible to silence forever). Worse, doing what the error says and setting override:true without understanding what that does can have unexpected effects (https://github.com/jssjr/git/issues/71).
-rw-r--r--lib/chef/platform/handler_map.rb5
1 files changed, 0 insertions, 5 deletions
diff --git a/lib/chef/platform/handler_map.rb b/lib/chef/platform/handler_map.rb
index 001eb3dc8f..a9551a344b 100644
--- a/lib/chef/platform/handler_map.rb
+++ b/lib/chef/platform/handler_map.rb
@@ -31,11 +31,6 @@ class Chef
# are exactly equal
if new_matcher[:value].is_a?(Class) && !new_matcher[:override]
cmp = compare_matcher_properties(new_matcher, matcher) { |m| m[:value].name }
- if cmp < 0
- Chef::Log.warn "You are overriding #{key} on #{new_matcher[:filters].inspect} with #{new_matcher[:value].inspect}: used to be #{matcher[:value].inspect}. Use override: true if this is what you intended."
- elsif cmp > 0
- Chef::Log.warn "You declared a new resource #{new_matcher[:value].inspect} for resource #{key}, but it comes alphabetically after #{matcher[:value].inspect} and has the same filters (#{new_matcher[:filters].inspect}), so it will not be used. Use override: true if you want to use it for #{key}."
- end
end
end
cmp