diff options
author | Lamont Granquist <lamont@scriptkiddie.org> | 2016-11-15 14:56:40 -0800 |
---|---|---|
committer | Lamont Granquist <lamont@scriptkiddie.org> | 2016-12-06 13:08:25 -0800 |
commit | dd8feda809f4396d4a802e483e84e19d2f5e9d9a (patch) | |
tree | b98873caaf187f8f41242bd32d4790e90a71a60e | |
parent | ebbd30f036c7e6938ea2e5d3624543ffe0b5cb41 (diff) | |
download | chef-dd8feda809f4396d4a802e483e84e19d2f5e9d9a.tar.gz |
fix Performance/SortWithBlock cop
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
-rw-r--r-- | lib/chef/cookbook_loader.rb | 2 | ||||
-rw-r--r-- | spec/unit/cookbook/metadata_spec.rb | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/chef/cookbook_loader.rb b/lib/chef/cookbook_loader.rb index bff77fa13b..a965b43c61 100644 --- a/lib/chef/cookbook_loader.rb +++ b/lib/chef/cookbook_loader.rb @@ -137,7 +137,7 @@ class Chef alias :key? :has_key? def each - @cookbooks_by_name.keys.sort { |a, b| a.to_s <=> b.to_s }.each do |cname| + @cookbooks_by_name.keys.sort_by(&:to_s).each do |cname| yield(cname, @cookbooks_by_name[cname]) end end diff --git a/spec/unit/cookbook/metadata_spec.rb b/spec/unit/cookbook/metadata_spec.rb index 389f02501a..d1117127f1 100644 --- a/spec/unit/cookbook/metadata_spec.rb +++ b/spec/unit/cookbook/metadata_spec.rb @@ -206,7 +206,7 @@ describe Chef::Cookbook::Metadata do :issues_url => "http://example.com/issues", :privacy => true, } - params.sort { |a, b| a.to_s <=> b.to_s }.each do |field, field_value| + params.sort_by(&:to_s).each do |field, field_value| describe field do it "should be set-able via #{field}" do expect(metadata.send(field, field_value)).to eql(field_value) @@ -240,7 +240,7 @@ describe Chef::Cookbook::Metadata do :provides => [ :providing, "foo::bar", "<= 0.2" ], :replaces => [ :replacing, "foo::bar", "= 0.2.1" ], } - dep_types.sort { |a, b| a.to_s <=> b.to_s }.each do |dep, dep_args| + dep_types.sort_by(&:to_s).each do |dep, dep_args| check_with = dep_args.shift describe dep do it "should be set-able via #{dep}" do @@ -261,7 +261,7 @@ describe Chef::Cookbook::Metadata do :provides => [ :providing, "foo::bar", "<=0.2", "<= 0.2" ], :replaces => [ :replacing, "foo::bar", "=0.2.1", "= 0.2.1" ], } - dep_types.sort { |a, b| a.to_s <=> b.to_s }.each do |dep, dep_args| + dep_types.sort_by(&:to_s).each do |dep, dep_args| check_with = dep_args.shift normalized_version = dep_args.pop describe dep do |