add openbsd package provider

8 files changed, 690 insertions, 1 deletions

diff --git a/Gemfile b/Gemfile
index 1418235ebc..627a906a08 100644
--- a/Gemfile
+++ b/Gemfile
@@ -10,6 +10,7 @@ end
 group(:development, :test) do
   gem "simplecov"
   gem 'rack', "~> 1.5.1"
+  gem 'sqlite3' # needed by package provider tests for OpenBSD
 
   gem 'ruby-shadow', :platforms => :ruby unless RUBY_PLATFORM.downcase.match(/(aix|cygwin)/)
 end
diff --git a/lib/chef/platform/provider_mapping.rb b/lib/chef/platform/provider_mapping.rb
index 382df342f5..271e72f761 100644
--- a/lib/chef/platform/provider_mapping.rb
+++ b/lib/chef/platform/provider_mapping.rb
@@ -365,7 +365,8 @@ class Chef
             },
             :openbsd => {
               :default => {
-                :group => Chef::Provider::Group::Usermod
+                :group => Chef::Provider::Group::Usermod,
+                :package => Chef::Provider::Package::Openbsd
               }
             },
             :hpux => {
diff --git a/lib/chef/provider/package/openbsd.rb b/lib/chef/provider/package/openbsd.rb
new file mode 100644
index 0000000000..83c0683d66
--- /dev/null
+++ b/lib/chef/provider/package/openbsd.rb
@@ -0,0 +1,226 @@
+#
+# Authors:: Bryan McLellan (btm@loftninjas.org)
+#           Matthew Landauer (matthew@openaustralia.org)
+#           Richard Manyanza (liseki@nyikacraftsmen.com)
+#           Scott Bonds (scott@ggr.com)
+# Copyright:: Copyright (c) 2009 Bryan McLellan, Matthew Landauer
+# Copyright:: Copyright (c) 2014 Richard Manyanza, Scott Bonds
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'chef/resource/package'
+require 'chef/provider/package'
+require 'chef/mixin/shell_out'
+require 'chef/mixin/get_source_from_package'
+
+class Chef
+  class Provider
+    class Package
+      class Openbsd < Chef::Provider::Package
+        include Chef::Mixin::ShellOut
+        include Chef::Mixin::GetSourceFromPackage
+
+        @@sqlports = nil
+        @@repo_packages = nil
+
+        def initialize(*args)
+          super
+          @current_resource = Chef::Resource::Package.new(@new_resource.name)
+          @new_resource.source("#{mirror}/pub/#{node.kernel.name}/#{node.kernel.release}/packages/#{node.kernel.machine}/") if !@new_resource.source
+        end
+
+        def install_package(name, version)
+          unless @current_resource.version
+            version_string  = ''
+            version_string += "-#{version}" if version && version != '0.0.0'
+            case @new_resource.source
+            when /^http/, /^ftp/
+              if @new_resource.source =~ /\/$/
+                shell_out!("pkg_add -r #{short_package_name}#{version_string}", :env => { "PACKAGESITE" => @new_resource.source, 'LC_ALL' => nil }).status
+              else
+                shell_out!("pkg_add -r #{short_package_name}#{version_string}", :env => { "PACKAGEROOT" => @new_resource.source, 'LC_ALL' => nil }).status
+              end
+              Chef::Log.debug("#{@new_resource} installed from: #{@new_resource.source}")
+
+            when /^\//
+              shell_out!("pkg_add #{file_candidate_version_path}", :env => { "PKG_PATH" => @new_resource.source , 'LC_ALL'=>nil}).status
+              Chef::Log.debug("#{@new_resource} installed from: #{@new_resource.source}")
+
+            else
+              shell_out!("pkg_add -r #{latest_link_name}", :env => nil).status
+            end
+          end
+        end
+
+        def remove_package(name, version)
+          version_string  = ''
+          version_string += "-#{version}" if version && version != '0.0.0'
+          shell_out!("pkg_delete #{short_package_name}#{version_string}", :env => nil).status
+        end
+
+        # The name of the package (without the version number) as understood 
+        # by pkg_add and pkg_info.
+        def short_package_name
+          result = ''
+          info = find_package(@new_resource.package_name)
+          result += info[:short_name]
+          if info[:version]
+            subpackage = info[:version].match /(.*)-\d.*/
+            result += '-' + subpackage[1] if subpackage
+          end
+
+          result
+        end
+
+        def current_installed_version
+          pkg_info = shell_out!("pkg_info -e \"#{short_package_name}->0\"", :env => nil, :returns => [0,1])
+          result = pkg_info.stdout[/^inst:#{Regexp.escape(short_package_name)}-(.+)/, 1]
+          Chef::Log.debug("current_installed_version of '#{short_package_name}' is '#{result}'")
+          result
+        end
+
+        def candidate_version
+          case @new_resource.source
+          when /^http/, /^ftp/
+            repo_candidate_version
+          when /^\//
+            file_candidate_version
+          else
+            port_candidate_version
+          end
+        end
+
+        def file_candidate_version_path
+          Dir["#{@new_resource.source}/#{@current_resource.package_name}*"][-1].to_s
+        end
+
+        def file_candidate_version
+          file_candidate_version_path.split(/-/).last.split(/.tbz/).first
+        end
+
+        def repo_candidate_version(options={})
+          return '0.0.0' if @new_resource.package_name == 'sqlports'
+          info = find_package(@new_resource.package_name)
+          info[:fullpkgname].sub(/^#{info[:short_name]}-/,'')
+        end
+
+        def port_candidate_version
+          name = makefile_variable_value("DISTNAME", port_path) || 
+            makefile_variable_value("PKGNAME", port_path)
+          name.match(/.*?-(\d.*)/)[1]
+        end
+
+        # does NOT include port options, i.e. flavors and subpackages
+        # i.e. /usr/ports/meta/gnome,-extra ... does NOT include the ',-extra'
+        def port_path
+          '/usr/ports/' + find_package(@new_resource.package_name)[:fullpkgpath].split(',').first
+        end
+
+        def find_package(name)
+          return {short_name: 'sqlports'} if name == 'sqlports'
+
+          result = nil
+
+          query = "SELECT fullpkgname, fullpkgpath, pkgspec, pkgname FROM ports WHERE"
+          if name.include? '/'
+            rows = sqlports.execute "#{query} fullpkgpath = '#{name}'"
+            rows = sqlports.execute "#{query} fullpkgpath = '#{name},-main'" if rows.empty?
+          else
+            rows = sqlports.execute "#{query} fullpkgname = '#{name}'"
+            rows = sqlports.execute "#{query} pkgname = '#{name}'" if rows.empty?
+            rows = sqlports.execute "#{query} pkgspec = '#{name}-*'" if rows.empty?
+          end
+          if rows.size > 0
+            row = rows.first
+            result = {
+              short_name: row[2].sub(/-[\*><=].*/,''),
+              short_version: row[3].sub(row[2].sub(/[\*><=].*/,''), ''),
+              pkgspec: row[2],
+              fullpkgname: row[0],
+              fullpkgpath: row[1],
+           }
+          else
+            raise Chef::Exceptions::Package, "Could not find a package that matches: #{name}"
+          end
+
+          result
+        end
+
+        def mirror
+          'http://ftp.eu.openbsd.org'
+        end
+
+        def sqlports(options={})
+          # install the DB that maps ports paths to package names, assume it
+          # will stay installed during this chef run, we won't bother to check
+          # it on every call to this method
+          if !@@sqlports
+            Chef::Log.debug("Initializing sqlports")
+            shell_out!("pkg_add sqlports") unless ::File.exists?('/usr/local/share/sqlports')
+            shell_out!("gem install sqlite3", :returns => [0,1]) unless shell_out!("gem list | grep sqlite3").stdout.include?('sqlite3')
+            require 'sqlite3'
+            @@sqlports = SQLite3::Database.new '/usr/local/share/sqlports'
+          end
+
+          @@sqlports
+        end
+
+        def port_dir(port)
+          case port
+
+          # When the package name starts with a '/' treat it as the full path to the ports directory.
+          when /^\//
+            port
+
+          # Otherwise if the package name contains a '/' not at the start (like 'www/wordpress') treat
+          # as a relative path from /usr/ports.
+          when /\//
+            "/usr/ports/#{port}"
+
+          else
+            rows = sqlports.execute "SELECT fullpkgpath FROM ports WHERE pkgspec = '#{port}-*';"
+            if rows.size > 0
+              "/usr/ports/#{rows.first.first.split(',').first}"
+            else
+              raise Chef::Exceptions::Package, "Could not find port: #{port}"
+            end
+          end
+        end
+
+        def makefile_variable_value(variable, dir = nil)
+          options = dir ? { :cwd => dir } : {}
+          make_v = shell_out!("make -V #{variable}", options.merge!(:env => nil, :returns => [0,1]))
+
+          # $\ is the line separator, i.e. newline.
+          result = make_v.exitstatus.zero? ? make_v.stdout.strip.split($\).first : nil
+
+          # some make variables reference other variables, recurse to resolve
+          result = result.gsub(/\${?[A-Z0-9_]*}?/) {|match| makefile_variable_value(match[1..-1].gsub(/[\{\}]/,''), dir)} if result
+          result
+        end
+
+        def load_current_resource
+          @current_resource.package_name(@new_resource.package_name)
+          @current_resource.version(current_installed_version)
+          Chef::Log.debug("#{@new_resource} current version is #{@current_resource.version}") if @current_resource.version
+          @candidate_version = candidate_version
+          Chef::Log.debug("#{@new_resource} candidate version is #{@candidate_version}") if @candidate_version
+          @current_resource
+        end
+
+      end
+    end
+  end
+end
diff --git a/lib/chef/providers.rb b/lib/chef/providers.rb
index c4f1ce769d..38c0e6fc9a 100644
--- a/lib/chef/providers.rb
+++ b/lib/chef/providers.rb
@@ -63,6 +63,7 @@ require 'chef/provider/package/freebsd/pkgng'
 require 'chef/provider/package/homebrew'
 require 'chef/provider/package/ips'
 require 'chef/provider/package/macports'
+require 'chef/provider/package/openbsd'
 require 'chef/provider/package/pacman'
 require 'chef/provider/package/portage'
 require 'chef/provider/package/paludis'
diff --git a/lib/chef/resource/openbsd_package.rb b/lib/chef/resource/openbsd_package.rb
new file mode 100644
index 0000000000..e6788c8c37
--- /dev/null
+++ b/lib/chef/resource/openbsd_package.rb
@@ -0,0 +1,51 @@
+#
+# Authors:: AJ Christensen (<aj@opscode.com>)
+#           Richard Manyanza (<liseki@nyikacraftsmen.com>)
+#           Scott Bonds (<scott@ggr.com>)
+# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# Copyright:: Copyright (c) 2014 Richard Manyanza, Scott Bonds
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'chef/resource/package'
+require 'chef/provider/package/openbsd'
+require 'chef/mixin/shell_out'
+
+class Chef
+  class Resource
+    class OpenbsdPackage < Chef::Resource::Package
+      include Chef::Mixin::ShellOut
+
+      provides :package, :on_platforms => ["openbsd"]
+
+      def initialize(name, run_context=nil)
+        super
+        @resource_name = :openbsd_package
+      end
+
+      def after_created
+        assign_provider
+      end
+
+      private
+
+      def assign_provider
+        @provider = Chef::Provider::Package::Openbsd
+      end
+
+    end
+  end
+end
+
diff --git a/lib/chef/resources.rb b/lib/chef/resources.rb
index 696dbbdc55..680b393741 100644
--- a/lib/chef/resources.rb
+++ b/lib/chef/resources.rb
@@ -48,6 +48,7 @@ require 'chef/resource/macports_package'
 require 'chef/resource/mdadm'
 require 'chef/resource/mount'
 require 'chef/resource/ohai'
+require 'chef/resource/openbsd_package'
 require 'chef/resource/package'
 require 'chef/resource/pacman_package'
 require 'chef/resource/paludis_package'
diff --git a/spec/unit/provider/package/openbsd_spec.rb b/spec/unit/provider/package/openbsd_spec.rb
new file mode 100644
index 0000000000..ecf8402727
--- /dev/null
+++ b/spec/unit/provider/package/openbsd_spec.rb
@@ -0,0 +1,359 @@
+#
+# Author:: Scott Bonds (scott@ggr.com)
+# Copyright:: Copyright (c) 2014 Scott Bonds
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'ostruct'
+
+def running_compatible_os
+  @os ||= `uname`.downcase.strip
+  @os_version ||= `uname -r`.strip
+  @os_architecture ||= `uname -m`.downcase.strip
+  @os == 'openbsd' && @os_version == '5.5' && @os_architecture == 'amd64'
+end
+
+describe Chef::Provider::Package::Openbsd, 'find_package', :if => running_compatible_os do
+
+  before(:each) do
+    @node = Chef::Node.new
+    @node.default['kernel'] = {'name' => 'OpenBSD', 'release' => '5.5', 'machine' => 'amd64'}
+    @events = Chef::EventDispatch::Dispatcher.new
+    @run_context = Chef::RunContext.new(@node, {}, @events)
+  end
+
+  describe "plain package name (zsh)" do
+    before do
+      @name = 'zsh'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+
+    it "should parse as a plain package with no version" do
+      @info[:short_name].should     == 'zsh'
+      @info[:short_version].should  == '5.0.2'
+      @info[:pkgspec].should        == 'zsh-*'
+      @info[:fullpkgname].should    == 'zsh-5.0.2'
+      @info[:fullpkgpath].should    == 'shells/zsh'
+    end
+
+    it "should translate to a port path" do
+      @provider.port_path.should == '/usr/ports/shells/zsh'
+    end
+
+    it "should have a valid repo candidate version" do
+      @provider.repo_candidate_version.should == '5.0.2'
+    end
+
+    it "should have a valid port candidate version" do
+      @provider.port_candidate_version.should == '5.0.2'
+    end
+
+  end
+
+  describe "package name with unavailable version (zsh-5.0.10)" do
+    before do
+      @name = 'zsh-5.0.10'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+    end
+
+    it "should raise an exception when the requested version does not match whats available in the repo" do
+      expect {@provider.find_package(@name)}.to raise_error Chef::Exceptions::Package
+    end
+
+end
+
+  describe "package name with available version (zsh-5.0.2)" do
+    before do
+      @name = 'zsh-5.0.2'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+
+    it "should parse as a plain package with no version" do
+      @info[:short_name].should     == 'zsh'
+      @info[:short_version].should  == '5.0.2'
+      @info[:pkgspec].should        == 'zsh-*'
+      @info[:fullpkgname].should    == 'zsh-5.0.2'
+      @info[:fullpkgpath].should    == 'shells/zsh'
+    end
+
+   it "should translate to a port path" do
+      @provider.port_path.should == '/usr/ports/shells/zsh'
+    end
+
+    it "should have a valid repo candidate version" do
+      @provider.repo_candidate_version.should == '5.0.2'
+    end
+
+    it "should have a valid port candidate version" do
+      @provider.port_candidate_version.should == '5.0.2'
+    end
+
+  end
+
+  describe "package with version and flavor (mutt-1.5.22p0v0-sasl)" do
+    before do
+      @name = 'mutt-1.5.22p0v0-sasl'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+
+    it "should parse as a plain package with no version" do
+      @info[:short_name].should     == 'mutt'
+      @info[:short_version].should  == '1.5.22'
+      @info[:pkgspec].should        == 'mutt-*'
+      @info[:fullpkgname].should    == 'mutt-1.5.22p0v0-sasl'
+      @info[:fullpkgpath].should    == 'mail/mutt/snapshot,sasl'
+    end
+
+   it "should translate to a port path" do
+      @provider.port_path.should == '/usr/ports/mail/mutt/snapshot'
+    end
+
+    it "should have a valid repo candidate version" do
+      @provider.repo_candidate_version.should == '1.5.22p0v0-sasl'
+    end
+
+    it "should have a valid port candidate version" do
+      @provider.port_candidate_version.should == '1.5.22'
+    end
+
+  end
+
+  describe "package with subpackage (gnome-extra)" do
+    before do
+      @name = 'gnome-extra'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+
+    it "should parse as a plain package with no version" do
+      @info[:short_name].should     == 'gnome-extra'
+      @info[:short_version].should  == '3.10.2'
+      @info[:pkgspec].should        == 'gnome-extra-*'
+      @info[:fullpkgname].should    == 'gnome-extra-3.10.2'
+      @info[:fullpkgpath].should    == 'meta/gnome,-extra'
+    end
+
+    it "should translate to a port path" do
+      @provider.port_path.should == '/usr/ports/meta/gnome'
+    end
+
+    it "should have a valid repo candidate version" do
+      @provider.repo_candidate_version.should == '3.10.2'
+    end
+
+    it "should have a valid port candidate version" do
+      @provider.port_candidate_version.should == '3.10.2'
+    end
+
+  end
+
+  describe "port path with 'main' subpackage (mail/gmime,-main)" do
+    before do
+      @name = 'mail/gmime,-main'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+
+    it "should parse as a plain package with no version" do
+      @info[:short_name].should     == 'gmime'
+      @info[:short_version].should  == '2.6.19'
+      @info[:pkgspec].should        == 'gmime-*'
+      @info[:fullpkgname].should    == 'gmime-2.6.19'
+      @info[:fullpkgpath].should    == 'mail/gmime,-main'
+    end
+
+    it "should translate to a port path" do
+      @provider.port_path.should == '/usr/ports/mail/gmime'
+    end
+
+    it "should have a valid repo candidate version" do
+      @provider.repo_candidate_version.should == '2.6.19'
+    end
+
+    it "should have a valid port candidate version" do
+      @provider.port_candidate_version.should == '2.6.19'
+    end
+
+  end
+
+  describe "port path with non-'main' subpackage (mail/gmime,-mono)" do
+    before do
+      @name = 'mail/gmime,-mono'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+
+    it "should parse as a plain package with no version" do
+      @info[:short_name].should     == 'gmime-sharp'
+      @info[:short_version].should  == '2.6.19'
+      @info[:pkgspec].should        == 'gmime-sharp-*'
+      @info[:fullpkgname].should    == 'gmime-sharp-2.6.19'
+      @info[:fullpkgpath].should    == @name
+    end
+
+    it "should translate to a port path" do
+      @provider.port_path.should == '/usr/ports/mail/gmime'
+    end
+
+    it "should have a valid repo candidate version" do
+      @provider.repo_candidate_version.should == '2.6.19'
+    end
+
+    it "should have a valid port candidate version" do
+      @provider.port_candidate_version.should == '2.6.19'
+    end
+
+  end
+
+  describe "package with a dash in the name, multiple major versions, and different package and port versions (php-zip-5.4.24)" do
+    before do
+      @name = 'php-zip-5.4.24'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+
+    it "should parse as a plain package with no version" do
+      @info[:short_name].should     == 'php-zip'
+      @info[:short_version].should  == '5.4.24'
+      @info[:pkgspec].should        == 'php-zip->=5.4,<5.5'
+      @info[:fullpkgname].should    == 'php-zip-5.4.24'
+      @info[:fullpkgpath].should    == 'lang/php/5.4,-zip'
+    end
+
+    it "should translate to a port path" do
+      @provider.port_path.should == '/usr/ports/lang/php/5.4'
+    end
+
+    it "should have a valid repo candidate version" do
+      @provider.repo_candidate_version.should == '5.4.24'
+    end
+
+    it "should have a valid port candidate version" do
+      @provider.port_candidate_version.should =~ /5\.4\.\d*/
+    end
+
+  end
+
+  describe "another package name to parse, for good measure (clamav)" do
+    before do
+      @name = 'clamav'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+
+    it "should parse as a plain package with no version" do
+      @info[:short_name].should     == 'clamav'
+      @info[:short_version].should  == '0.98.1'
+      @info[:pkgspec].should        == 'clamav-*'
+      @info[:fullpkgname].should    == 'clamav-0.98.1'
+      @info[:fullpkgpath].should    == 'security/clamav'
+    end
+
+    it "should translate to a port path" do
+      @provider.port_path.should == '/usr/ports/security/clamav'
+    end
+
+    it "should have a valid repo candidate version" do
+      @provider.repo_candidate_version.should == '0.98.1'
+    end
+
+    it "should have a valid port candidate version" do
+      @provider.port_candidate_version.should == '0.98.4'
+    end
+
+  end
+
+  describe "install a package" do
+    before do
+      @name = 'zzuf'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+    it "should run the installation command" do
+      expect(@provider).to receive(:shell_out!).with(
+        "pkg_add -r #{@name}",
+        :env=>{
+          "PACKAGESITE" => "http://ftp.eu.openbsd.org/pub/OpenBSD/5.5/packages/amd64/",
+          "LC_ALL" => nil
+        }
+      ) {OpenStruct.new :status => true}
+      @provider.install_package(@name, nil)
+    end
+  end
+
+  describe "delete a package" do
+    before do
+      @name = 'sqlports'
+      @new_resource     = Chef::Resource::Package.new(@name)
+      @current_resource = Chef::Resource::Package.new(@name)
+      @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
+      @provider.current_resource = @current_resource
+      @provider.sqlports(:skip_installation => true)
+      @info = @provider.find_package(@name)
+    end
+    it "should run the command to delete the installed package" do
+      expect(@provider).to receive(:shell_out!).with(
+        "pkg_delete sqlports", :env=>nil
+      ) {OpenStruct.new :status => true}
+      @provider.remove_package(@name, nil)
+    end
+  end
+
+end
+
diff --git a/spec/unit/resource/openbsd_package_spec.rb b/spec/unit/resource/openbsd_package_spec.rb
new file mode 100644
index 0000000000..d5972240a2
--- /dev/null
+++ b/spec/unit/resource/openbsd_package_spec.rb
@@ -0,0 +1,49 @@
+#
+# Authors:: AJ Christensen (<aj@opscode.com>)
+#           Richard Manyanza (<liseki@nyikacraftsmen.com>)
+#           Scott Bonds (<scott@ggr.com>)
+# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# Copyright:: Copyright (c) 2014 Richard Manyanza, Scott Bonds
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'ostruct'
+
+describe Chef::Resource::OpenbsdPackage do
+
+  before(:each) do
+    @node = Chef::Node.new
+    @events = Chef::EventDispatch::Dispatcher.new
+    @run_context = Chef::RunContext.new(@node, {}, @events)
+    @resource = Chef::Resource::OpenbsdPackage.new("foo", @run_context)
+  end
+
+  describe "Initialization" do
+    it "should return a Chef::Resource::OpenbsdPackage" do
+      @resource.should be_a_kind_of(Chef::Resource::OpenbsdPackage)
+    end
+
+    it "should set the resource_name to :openbsd_package" do
+      @resource.resource_name.should eql(:openbsd_package)
+    end
+
+    it "should not set the provider" do
+      @resource.provider.should be_nil
+    end
+  end
+
+end
+