diff options
author | Lamont Granquist <lamont@scriptkiddie.org> | 2017-02-28 14:10:42 -0800 |
---|---|---|
committer | Lamont Granquist <lamont@scriptkiddie.org> | 2017-02-28 14:10:42 -0800 |
commit | 53bc529a03058ff9998d91d653585feaf8f735a6 (patch) | |
tree | 221d85f354731e8adc3a364d106281694fb80e86 | |
parent | 60e84d96d8fbe63e71eb497d9da0d931dc594ed4 (diff) | |
download | chef-53bc529a03058ff9998d91d653585feaf8f735a6.tar.gz |
self-deps are now just illegal
circular deps are poor form, but allowed, so we still need to check.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
-rw-r--r-- | spec/integration/knife/deps_spec.rb | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/spec/integration/knife/deps_spec.rb b/spec/integration/knife/deps_spec.rb index 292bce6002..40ec411780 100644 --- a/spec/integration/knife/deps_spec.rb +++ b/spec/integration/knife/deps_spec.rb @@ -1,6 +1,6 @@ # # Author:: John Keiser (<jkeiser@chef.io>) -# Copyright:: Copyright 2013-2016, Chef Software Inc. +# Copyright:: Copyright 2013-2017, Chef Software Inc. # License:: Apache License, Version 2.0 # # Licensed under the Apache License, Version 2.0 (the "License"); @@ -211,20 +211,16 @@ depends "bar"' depends "baz"' file "cookbooks/baz/metadata.rb", 'name "baz" depends "foo"' - file "cookbooks/self/metadata.rb", 'name "self" -depends "self"' end it "knife deps prints each once" do - knife("deps /cookbooks/foo /cookbooks/self").should_succeed( - stdout: "/cookbooks/baz\n/cookbooks/bar\n/cookbooks/foo\n/cookbooks/self\n", - stderr: "WARN: Ignoring self-dependency in cookbook self, please remove it (in the future this will be fatal).\n" + knife("deps /cookbooks/foo").should_succeed( + stdout: "/cookbooks/baz\n/cookbooks/bar\n/cookbooks/foo\n" ) end it "knife deps --tree prints each once" do - knife("deps --tree /cookbooks/foo /cookbooks/self").should_succeed( - stdout: "/cookbooks/foo\n /cookbooks/bar\n /cookbooks/baz\n /cookbooks/foo\n/cookbooks/self\n", - stderr: "WARN: Ignoring self-dependency in cookbook self, please remove it (in the future this will be fatal).\n" + knife("deps --tree /cookbooks/foo").should_succeed( + stdout: "/cookbooks/foo\n /cookbooks/bar\n /cookbooks/baz\n /cookbooks/foo\n" ) end end |