Improve the lets in the dscl provider specs

Signed-off-by: Tim Smith <tsmith@chef.io>

1 files changed, 15 insertions, 19 deletions

diff --git a/spec/unit/provider/user/dscl_spec.rb b/spec/unit/provider/user/dscl_spec.rb
index cff8986be4..4951315da4 100644
--- a/spec/unit/provider/user/dscl_spec.rb
+++ b/spec/unit/provider/user/dscl_spec.rb
@@ -23,25 +23,25 @@ describe Chef::Provider::User::Dscl do
   before do
     allow(ChefConfig).to receive(:windows?) { false }
   end
-  let(:shellcmdresult) do
-    Struct.new(:stdout, :stderr, :exitstatus)
-  end
-  let(:node) do
-    node = Chef::Node.new
-    allow(node).to receive(:[]).with(:platform).and_return("mac_os_x")
-    node
-  end
 
-  let(:events) do
-    Chef::EventDispatch::Dispatcher.new
-  end
+  let(:shellcmdresult) { Struct.new(:stdout, :stderr, :exitstatus) }
+
+  let(:password) { nil }
+  let(:salt) { nil }
+  let(:iterations) { nil }
 
-  let(:run_context) do
-    Chef::RunContext.new(node, {}, events)
+  let (:events) { Chef::EventDispatch::Dispatcher.new }
+
+  let(:node) do
+    Chef::Node.new.tap do |node|
+      node.automatic["os"] = "darwin"
+    end
   end
 
+  let (:run_context) { Chef::RunContext.new(node, {}, events) }
+
   let(:new_resource) do
-    r = Chef::Resource::User::DsclUser.new("toor")
+    r = Chef::Resource::User::DsclUser.new("toor", run_context)
     r.password(password)
     r.salt(salt)
     r.iterations(iterations)
@@ -52,10 +52,6 @@ describe Chef::Provider::User::Dscl do
     Chef::Provider::User::Dscl.new(new_resource, run_context)
   end
 
-  let(:password) { nil }
-  let(:salt) { nil }
-  let(:iterations) { nil }
-
   let(:salted_sha512_password) do
     "0f543f021c63255e64e121a3585601b8ecfedf6d2\
 705ddac69e682a33db5dbcdb9b56a2520bc8fff63a\
@@ -144,7 +140,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30"
       expect(provider).to receive(:run_dscl).with("list", "/Users", "uid").and_return("\nwheel      200\nstaff      201\nbrahms      500\nchopin      501\n")
     end
 
-    describe "when resource is configured as system" do
+    describe "when the system property is set to true" do
       before do
         new_resource.system(true)
       end