speed improvement for remote_directory() resource

problem:
doing ls(path) for a very large directory with > 1.8mil files takes
upwards of 10 minutes.

solution:
change filtering stage from files.reject! to files.reject

files.reject! does in place filtering and it looks like it copies the
whole array for every deletion. in my example it filtered out 300k rows,
    so that's 300k array copies.

switching to files.reject decreases the runtime of that function from
650seconds down to 6-7 seconds.

1 files changed, 1 insertions, 1 deletions

diff --git a/lib/chef/provider/remote_directory.rb b/lib/chef/provider/remote_directory.rb
index eaccce46cf..85ceb5cdae 100644
--- a/lib/chef/provider/remote_directory.rb
+++ b/lib/chef/provider/remote_directory.rb
@@ -67,7 +67,7 @@ class Chef
                  ::File::FNM_DOTMATCH)
 
         # Remove current directory and previous directory
-        files.reject! do |name|
+        files = files.reject do |name|
           basename = Pathname.new(name).basename().to_s
           ['.', '..'].include?(basename)
         end