summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Smith <tsmith@chef.io>2019-05-13 15:09:03 -0700
committerTim Smith <tsmith@chef.io>2019-05-13 15:09:03 -0700
commit3d1a19b294e125cf666c9ecfe3f4332674199097 (patch)
treea7470e541642368af99558a273e033527abb907d
parentb5237b5dd1975340a0d72f4a504284d5ee1a8876 (diff)
downloadchef-3d1a19b294e125cf666c9ecfe3f4332674199097.tar.gz
Rename the windows_dfs :install actions to :create
We're creating these dfs shares so it makes a lot more sense to make the action create. This is probably what people using Chef would expect. Signed-off-by: Tim Smith <tsmith@chef.io>
-rw-r--r--lib/chef/resource/windows_dfs_folder.rb2
-rw-r--r--lib/chef/resource/windows_dfs_namespace.rb2
-rw-r--r--spec/unit/resource/windows_dfs_folder_spec.rb8
-rw-r--r--spec/unit/resource/windows_dfs_namespace_spec.rb8
4 files changed, 10 insertions, 10 deletions
diff --git a/lib/chef/resource/windows_dfs_folder.rb b/lib/chef/resource/windows_dfs_folder.rb
index 1acf2a4acd..a93a11808c 100644
--- a/lib/chef/resource/windows_dfs_folder.rb
+++ b/lib/chef/resource/windows_dfs_folder.rb
@@ -41,7 +41,7 @@ class Chef
property :description, String,
description: "Description for the share."
- action :install do
+ action :create do
description "Creates the folder in dfs namespace."
raise "target_path is required for install" unless property_is_set?(:target_path)
diff --git a/lib/chef/resource/windows_dfs_namespace.rb b/lib/chef/resource/windows_dfs_namespace.rb
index da565b06bf..2610b7a999 100644
--- a/lib/chef/resource/windows_dfs_namespace.rb
+++ b/lib/chef/resource/windows_dfs_namespace.rb
@@ -51,7 +51,7 @@ class Chef
description: "The root from which to create the DFS tree. Defaults to C:\\DFSRoots.",
default: 'C:\\DFSRoots'
- action :install do
+ action :create do
description "Creates the dfs namespace on the server."
directory file_path do
diff --git a/spec/unit/resource/windows_dfs_folder_spec.rb b/spec/unit/resource/windows_dfs_folder_spec.rb
index 04436b9fca..7c7dbb6b6f 100644
--- a/spec/unit/resource/windows_dfs_folder_spec.rb
+++ b/spec/unit/resource/windows_dfs_folder_spec.rb
@@ -28,12 +28,12 @@ describe Chef::Resource::WindowsDfsFolder do
expect(resource.folder_path).to eql("fakey_fakerton")
end
- it "sets the default action as :install" do
- expect(resource.action).to eql([:install])
+ it "sets the default action as :create" do
+ expect(resource.action).to eql([:create])
end
- it "supports :install and :delete actions" do
- expect { resource.action :install }.not_to raise_error
+ it "supports :create and :delete actions" do
+ expect { resource.action :create }.not_to raise_error
expect { resource.action :delete }.not_to raise_error
end
end
diff --git a/spec/unit/resource/windows_dfs_namespace_spec.rb b/spec/unit/resource/windows_dfs_namespace_spec.rb
index 9830471b78..489493e576 100644
--- a/spec/unit/resource/windows_dfs_namespace_spec.rb
+++ b/spec/unit/resource/windows_dfs_namespace_spec.rb
@@ -28,12 +28,12 @@ describe Chef::Resource::WindowsDfsNamespace do
expect(resource.namespace_name).to eql("fakey_fakerton")
end
- it "sets the default action as :install" do
- expect(resource.action).to eql([:install])
+ it "sets the default action as :create" do
+ expect(resource.action).to eql([:create])
end
- it "supports :install and :delete actions" do
- expect { resource.action :install }.not_to raise_error
+ it "supports :create and :delete actions" do
+ expect { resource.action :create }.not_to raise_error
expect { resource.action :delete }.not_to raise_error
end
end