diff options
author | Pete Higgins <pete@peterhiggins.org> | 2020-06-22 17:54:37 -0700 |
---|---|---|
committer | Pete Higgins <pete@peterhiggins.org> | 2020-06-26 12:08:52 -0700 |
commit | 381b35b0aab145bb7f2028f48d55ef2612e22574 (patch) | |
tree | 497896ff1326a775801fc24465a2b499457325ec | |
parent | e23fe89f57148cbfb71a1f84b470c4b92b2ee0a7 (diff) | |
download | chef-381b35b0aab145bb7f2028f48d55ef2612e22574.tar.gz |
Remove test file that added a method to top-level scope.
Signed-off-by: Pete Higgins <pete@peterhiggins.org>
32 files changed, 58 insertions, 61 deletions
diff --git a/spec/functional/resource/aix_service_spec.rb b/spec/functional/resource/aix_service_spec.rb index 0bc3dd2aad..0db0ab2385 100755 --- a/spec/functional/resource/aix_service_spec.rb +++ b/spec/functional/resource/aix_service_spec.rb @@ -18,7 +18,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" shared_examples "src service" do diff --git a/spec/functional/resource/aixinit_service_spec.rb b/spec/functional/resource/aixinit_service_spec.rb index ed99472df3..0b69c9d9a5 100755 --- a/spec/functional/resource/aixinit_service_spec.rb +++ b/spec/functional/resource/aixinit_service_spec.rb @@ -18,7 +18,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" require "fileutils" diff --git a/spec/functional/resource/base.rb b/spec/functional/resource/base.rb deleted file mode 100644 index df7eb3ed5d..0000000000 --- a/spec/functional/resource/base.rb +++ /dev/null @@ -1,28 +0,0 @@ -# -# Author:: Kaustubh Deorukhkar (<kaustubh@clogeny.com>) -# Copyright:: Copyright (c) Chef Software Inc. -# License:: Apache License, Version 2.0 -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -def run_context - @run_context ||= begin - node = Chef::Node.new - node.default[:platform] = ohai[:platform] - node.default[:platform_version] = ohai[:platform_version] - node.default[:os] = ohai[:os] - events = Chef::EventDispatch::Dispatcher.new - Chef::RunContext.new(node, {}, events) - end -end diff --git a/spec/functional/resource/bash_spec.rb b/spec/functional/resource/bash_spec.rb index bc61bbd579..abb88f499f 100644 --- a/spec/functional/resource/bash_spec.rb +++ b/spec/functional/resource/bash_spec.rb @@ -17,11 +17,12 @@ # require "spec_helper" -require "functional/resource/base" describe Chef::Resource::Bash, :unix_only do let(:code) { "echo hello" } let(:resource) do + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + resource = Chef::Resource::Bash.new("foo_resource", run_context) resource.code(code) unless code.nil? resource diff --git a/spec/functional/resource/bff_spec.rb b/spec/functional/resource/bff_spec.rb index 4368824067..32358b4c39 100644 --- a/spec/functional/resource/bff_spec.rb +++ b/spec/functional/resource/bff_spec.rb @@ -16,7 +16,6 @@ # limitations under the License. # -require "functional/resource/base" require "chef/mixin/shell_out" # Run the test only for AIX platform. diff --git a/spec/functional/resource/chocolatey_package_spec.rb b/spec/functional/resource/chocolatey_package_spec.rb index e8b175f487..24975d2e01 100644 --- a/spec/functional/resource/chocolatey_package_spec.rb +++ b/spec/functional/resource/chocolatey_package_spec.rb @@ -25,6 +25,10 @@ describe Chef::Resource::ChocolateyPackage, :windows_only, :choco_installed do let(:package_list) { proc { powershell_out!("choco list -lo -r #{Array(package_name).join(" ")}").stdout.chomp } } let(:package_source) { File.join(CHEF_SPEC_ASSETS, "chocolatey_feed") } + let(:run_context) do + Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + end + subject do new_resource = Chef::Resource::ChocolateyPackage.new("test choco package", run_context) new_resource.package_name package_name diff --git a/spec/functional/resource/cron_spec.rb b/spec/functional/resource/cron_spec.rb index ed4905b980..932bef4a42 100644 --- a/spec/functional/resource/cron_spec.rb +++ b/spec/functional/resource/cron_spec.rb @@ -18,7 +18,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" describe Chef::Resource::Cron, :requires_root, :unix_only do @@ -54,6 +53,8 @@ describe Chef::Resource::Cron, :requires_root, :unix_only do # Actual tests let(:new_resource) do + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + new_resource = Chef::Resource::Cron.new("Chef functional test cron", run_context) new_resource.user "root" new_resource.minute "0" diff --git a/spec/functional/resource/dnf_package_spec.rb b/spec/functional/resource/dnf_package_spec.rb index d8618a5dee..eef0d6296b 100644 --- a/spec/functional/resource/dnf_package_spec.rb +++ b/spec/functional/resource/dnf_package_spec.rb @@ -16,7 +16,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" # run this test only for following platforms. @@ -66,6 +65,10 @@ describe Chef::Resource::DnfPackage, :requires_root, external: exclude_test do FileUtils.rm_f "/etc/yum.repos.d/chef-dnf-localtesting.repo" end + let(:run_context) do + Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + end + let(:package_name) { "chef_rpm" } let(:dnf_package) { Chef::Resource::DnfPackage.new(package_name, run_context) } diff --git a/spec/functional/resource/execute_spec.rb b/spec/functional/resource/execute_spec.rb index 874e2e5a41..3d7e185e17 100644 --- a/spec/functional/resource/execute_spec.rb +++ b/spec/functional/resource/execute_spec.rb @@ -17,11 +17,11 @@ # require "spec_helper" -require "functional/resource/base" require "timeout" describe Chef::Resource::Execute do let(:resource) do + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) resource = Chef::Resource::Execute.new("foo_resource", run_context) resource.command("echo hello") resource diff --git a/spec/functional/resource/group_spec.rb b/spec/functional/resource/group_spec.rb index 540e51f1e4..86217ebb1a 100644 --- a/spec/functional/resource/group_spec.rb +++ b/spec/functional/resource/group_spec.rb @@ -18,7 +18,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" describe Chef::Resource::Group, :requires_root_or_running_windows do @@ -88,6 +87,7 @@ describe Chef::Resource::Group, :requires_root_or_running_windows do end def user(username) + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) usr = Chef::Resource.resource_for_node(:user, node).new(username, run_context) if ohai[:platform_family] == "windows" usr.password("ComplexPass11!") @@ -309,6 +309,7 @@ describe Chef::Resource::Group, :requires_root_or_running_windows do let(:included_members) { [] } let(:excluded_members) { [] } let(:group_resource) do + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) group = Chef::Resource::Group.new(group_name, run_context) group.members(included_members) group.excluded_members(excluded_members) diff --git a/spec/functional/resource/ifconfig_spec.rb b/spec/functional/resource/ifconfig_spec.rb index a37dfac668..70ae0f0703 100644 --- a/spec/functional/resource/ifconfig_spec.rb +++ b/spec/functional/resource/ifconfig_spec.rb @@ -17,7 +17,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" # run this test only for following platforms. @@ -27,6 +26,7 @@ describe Chef::Resource::Ifconfig, :requires_root, :requires_ifconfig, external: include Chef::Mixin::ShellOut let(:new_resource) do + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) new_resource = Chef::Resource::Ifconfig.new("10.10.0.1", run_context) new_resource end diff --git a/spec/functional/resource/insserv_spec.rb b/spec/functional/resource/insserv_spec.rb index 51ea064f32..788a46469b 100644 --- a/spec/functional/resource/insserv_spec.rb +++ b/spec/functional/resource/insserv_spec.rb @@ -18,7 +18,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" require "fileutils" @@ -54,6 +53,8 @@ describe Chef::Resource::Service, :requires_root, :opensuse do # Actual tests let(:new_resource) do + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + new_resource = Chef::Resource::Service.new("inittest", run_context) new_resource.provider Chef::Provider::Service::Insserv new_resource.supports({ status: true, restart: true, reload: true }) diff --git a/spec/functional/resource/link_spec.rb b/spec/functional/resource/link_spec.rb index 24a1f5cd7b..ecceb84a52 100644 --- a/spec/functional/resource/link_spec.rb +++ b/spec/functional/resource/link_spec.rb @@ -71,6 +71,7 @@ describe Chef::Resource::Link do end def user(user) + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) usr = Chef::Resource.resource_for_node(:user, node).new(user, run_context) usr.password("ComplexPass11!") if windows? usr diff --git a/spec/functional/resource/mount_spec.rb b/spec/functional/resource/mount_spec.rb index abaf74a506..2b8a11a339 100644 --- a/spec/functional/resource/mount_spec.rb +++ b/spec/functional/resource/mount_spec.rb @@ -17,7 +17,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" require "tmpdir" @@ -102,6 +101,8 @@ describe Chef::Resource::Mount, :requires_root, external: include_flag do end let(:new_resource) do + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + new_resource = Chef::Resource::Mount.new(@mount_point, run_context) new_resource.device @device new_resource.name @mount_point diff --git a/spec/functional/resource/rpm_spec.rb b/spec/functional/resource/rpm_spec.rb index 6e0c5a18cb..8a6cf32882 100644 --- a/spec/functional/resource/rpm_spec.rb +++ b/spec/functional/resource/rpm_spec.rb @@ -17,7 +17,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" # run this test only for following platforms. @@ -26,6 +25,7 @@ describe Chef::Resource::RpmPackage, :requires_root, external: exclude_test do include Chef::Mixin::ShellOut let(:new_resource) do + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) new_resource = Chef::Resource::RpmPackage.new(@pkg_name, run_context) new_resource.source @pkg_path new_resource diff --git a/spec/functional/resource/timezone_spec.rb b/spec/functional/resource/timezone_spec.rb index d144bea284..d44d5b34a8 100644 --- a/spec/functional/resource/timezone_spec.rb +++ b/spec/functional/resource/timezone_spec.rb @@ -21,6 +21,8 @@ describe Chef::Resource::Timezone, :windows_only do let(:timezone) { "GMT Standard Time" } def timezone_resource + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + Chef::Resource::Timezone.new(timezone, run_context) end diff --git a/spec/functional/resource/windows_package_spec.rb b/spec/functional/resource/windows_package_spec.rb index 3d75913ed1..3294e1c509 100644 --- a/spec/functional/resource/windows_package_spec.rb +++ b/spec/functional/resource/windows_package_spec.rb @@ -17,7 +17,6 @@ # require "spec_helper" -require "functional/resource/base" describe Chef::Resource::WindowsPackage, :windows_only, :volatile do let(:pkg_name) { nil } diff --git a/spec/functional/resource/windows_path_spec.rb b/spec/functional/resource/windows_path_spec.rb index 14e4ad8869..b2a3e5f5a4 100644 --- a/spec/functional/resource/windows_path_spec.rb +++ b/spec/functional/resource/windows_path_spec.rb @@ -21,6 +21,10 @@ require "spec_helper" describe Chef::Resource::WindowsPath, :windows_only do let(:path) { "test_path" } + let(:run_context) do + Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + end + before(:all) do @old_path = ENV["PATH"].dup end diff --git a/spec/functional/resource/windows_security_policy_spec.rb b/spec/functional/resource/windows_security_policy_spec.rb index cc225eec74..1a6b697bfa 100644 --- a/spec/functional/resource/windows_security_policy_spec.rb +++ b/spec/functional/resource/windows_security_policy_spec.rb @@ -17,7 +17,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/powershell_out" describe Chef::Resource::WindowsSecurityPolicy, :windows_only do diff --git a/spec/functional/resource/windows_service_spec.rb b/spec/functional/resource/windows_service_spec.rb index 195a974aa1..4c0c3acb58 100644 --- a/spec/functional/resource/windows_service_spec.rb +++ b/spec/functional/resource/windows_service_spec.rb @@ -62,6 +62,10 @@ describe Chef::Resource::WindowsService, :windows_only, :system_windows_service_ r end + let(:run_context) do + Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + end + before do user_resource.run_action(:create) diff --git a/spec/functional/resource/windows_task_spec.rb b/spec/functional/resource/windows_task_spec.rb index 84993cac0e..196e627272 100644 --- a/spec/functional/resource/windows_task_spec.rb +++ b/spec/functional/resource/windows_task_spec.rb @@ -25,12 +25,13 @@ describe Chef::Resource::WindowsTask, :windows_only do let(:task_name) { "chef-client-functional-test" } let(:new_resource) { Chef::Resource::WindowsTask.new(task_name) } let(:windows_task_provider) do - node = Chef::Node.new - events = Chef::EventDispatch::Dispatcher.new - run_context = Chef::RunContext.new(node, {}, events) Chef::Provider::WindowsTask.new(new_resource, run_context) end + let(:run_context) do + Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + end + describe "action :create" do after { delete_task } context "when command is with arguments" do diff --git a/spec/functional/resource/windows_user_privilege_spec.rb b/spec/functional/resource/windows_user_privilege_spec.rb index 115887e3e5..e30971d2e6 100644 --- a/spec/functional/resource/windows_user_privilege_spec.rb +++ b/spec/functional/resource/windows_user_privilege_spec.rb @@ -16,7 +16,6 @@ # require_relative "../../spec_helper" -require_relative "../../functional/resource/base" describe Chef::Resource::WindowsUserPrivilege, :windows_only do let(:principal) { nil } diff --git a/spec/functional/resource/yum_package_spec.rb b/spec/functional/resource/yum_package_spec.rb index 72e0a295b8..5f902cff17 100644 --- a/spec/functional/resource/yum_package_spec.rb +++ b/spec/functional/resource/yum_package_spec.rb @@ -16,7 +16,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" # run this test only for following platforms. @@ -64,6 +63,10 @@ describe Chef::Resource::YumPackage, :requires_root, external: exclude_test do FileUtils.rm_f "/etc/yum.repos.d/chef-yum-localtesting.repo" end + let(:run_context) do + Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + end + let(:package_name) { "chef_rpm" } let(:yum_package) do r = Chef::Resource::YumPackage.new(package_name, run_context) diff --git a/spec/functional/resource/zypper_package_spec.rb b/spec/functional/resource/zypper_package_spec.rb index 31168d9fe8..e56684b6f8 100644 --- a/spec/functional/resource/zypper_package_spec.rb +++ b/spec/functional/resource/zypper_package_spec.rb @@ -17,7 +17,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/mixin/shell_out" describe Chef::Resource::ZypperPackage, :requires_root, :suse_only do @@ -52,6 +51,10 @@ describe Chef::Resource::ZypperPackage, :requires_root, :suse_only do FileUtils.rm_f "/etc/zypp/repos.d/chef-zypp-localtesting.repo" end + let(:run_context) do + Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + end + let(:package_name) { "chef_rpm" } let(:zypper_package) do r = Chef::Resource::ZypperPackage.new(package_name, run_context) diff --git a/spec/functional/shell_spec.rb b/spec/functional/shell_spec.rb index d6dc6d8a08..583440d2b6 100644 --- a/spec/functional/shell_spec.rb +++ b/spec/functional/shell_spec.rb @@ -17,7 +17,6 @@ # require "spec_helper" -require "functional/resource/base" require "chef/version" require "chef/shell" diff --git a/spec/integration/recipes/recipe_dsl_spec.rb b/spec/integration/recipes/recipe_dsl_spec.rb index b939317c62..7db5599db5 100644 --- a/spec/integration/recipes/recipe_dsl_spec.rb +++ b/spec/integration/recipes/recipe_dsl_spec.rb @@ -1233,6 +1233,10 @@ describe "Recipe DSL methods" do before { Namer.current_index += 1 } context "with an LWRP that declares actions" do + let(:run_context) do + Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + end + let(:resource_class) do Class.new(Chef::Resource::LWRPBase) do provides :"recipe_dsl_spec#{Namer.current_index}" diff --git a/spec/support/shared/functional/securable_resource.rb b/spec/support/shared/functional/securable_resource.rb index 7bbd7d1666..26f2b1cc5a 100644 --- a/spec/support/shared/functional/securable_resource.rb +++ b/spec/support/shared/functional/securable_resource.rb @@ -19,7 +19,6 @@ # require "etc" -require "functional/resource/base" shared_context "setup correct permissions" do if windows? diff --git a/spec/support/shared/functional/securable_resource_with_reporting.rb b/spec/support/shared/functional/securable_resource_with_reporting.rb index abeb1ba4bb..6f816265bf 100644 --- a/spec/support/shared/functional/securable_resource_with_reporting.rb +++ b/spec/support/shared/functional/securable_resource_with_reporting.rb @@ -1,5 +1,4 @@ -require "functional/resource/base" ALL_EXPANDED_PERMISSIONS = ["generic read", "generic write", diff --git a/spec/unit/lwrp_spec.rb b/spec/unit/lwrp_spec.rb index 29a9945d8f..b0ddf30b28 100644 --- a/spec/unit/lwrp_spec.rb +++ b/spec/unit/lwrp_spec.rb @@ -653,14 +653,17 @@ describe "LWRP" do end end - let(:recipe) do + let(:run_context) do cookbook_repo = File.expand_path(File.join(File.dirname(__FILE__), "..", "data", "cookbooks")) cookbook_loader = Chef::CookbookLoader.new(cookbook_repo) cookbook_loader.load_cookbooks cookbook_collection = Chef::CookbookCollection.new(cookbook_loader) node = Chef::Node.new events = Chef::EventDispatch::Dispatcher.new - run_context = Chef::RunContext.new(node, cookbook_collection, events) + Chef::RunContext.new(node, cookbook_collection, events) + end + + let(:recipe) do Chef::Recipe.new("hjk", "test", run_context) end diff --git a/spec/unit/provider/execute_spec.rb b/spec/unit/provider/execute_spec.rb index 000d8cebda..80bdb6a230 100644 --- a/spec/unit/provider/execute_spec.rb +++ b/spec/unit/provider/execute_spec.rb @@ -26,7 +26,7 @@ describe Chef::Provider::Execute do let(:provider) { Chef::Provider::Execute.new(new_resource, run_context) } let(:current_resource) { Chef::Resource::Ifconfig.new("foo_resource", run_context) } # You will be the same object, I promise. - @live_stream = Chef::EventDispatch::EventsOutputStream.new(run_context.events, name: :execute) + @live_stream = Chef::EventDispatch::EventsOutputStream.new(Chef::EventDispatch::Dispatcher.new, name: :execute) let(:opts) do { diff --git a/spec/unit/provider/mdadm_spec.rb b/spec/unit/provider/mdadm_spec.rb index 7e3546dcce..c0f6813afd 100644 --- a/spec/unit/provider/mdadm_spec.rb +++ b/spec/unit/provider/mdadm_spec.rb @@ -22,9 +22,7 @@ require "ostruct" describe Chef::Resource::Mdadm do before(:each) do - @node = Chef::Node.new - @events = Chef::EventDispatch::Dispatcher.new - @run_context = Chef::RunContext.new(@node, {}, @events) + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) @new_resource = Chef::Resource::Mdadm.new("/dev/md1", run_context) @new_resource.devices ["/dev/sdz1", "/dev/sdz2", "/dev/sdz3"] @provider = @new_resource.provider_for_action(:create) diff --git a/spec/unit/provider/windows_env_spec.rb b/spec/unit/provider/windows_env_spec.rb index 0e6cb02d48..cd4bc161a4 100644 --- a/spec/unit/provider/windows_env_spec.rb +++ b/spec/unit/provider/windows_env_spec.rb @@ -21,13 +21,12 @@ require "spec_helper" describe Chef::Provider::WindowsEnv, :windows_only do before do - @node = Chef::Node.new - @events = Chef::EventDispatch::Dispatcher.new - @run_context = Chef::RunContext.new(@node, {}, @events) + run_context = Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) + @new_resource = Chef::Resource::WindowsEnv.new("FOO") @new_resource.value("bar") @new_resource.user("<System>") - @provider = Chef::Provider::WindowsEnv.new(@new_resource, @run_context) + @provider = Chef::Provider::WindowsEnv.new(@new_resource, run_context) end it "assumes the key_name exists by default" do |