Use a real error class when metadata is not foundsethvargo/site_install_json

2 files changed, 6 insertions, 1 deletions

diff --git a/lib/chef/exceptions.rb b/lib/chef/exceptions.rb
index 25f08455fc..d981d4512d 100644
--- a/lib/chef/exceptions.rb
+++ b/lib/chef/exceptions.rb
@@ -142,6 +142,11 @@ class Chef
     class IllegalVersionConstraint < NotImplementedError; end
 
     class MetadataNotValid < StandardError; end
+    class MetadataNotFound < StandardError
+      def initialize
+        super "No metadata.rb or metadata.json!"
+      end
+    end
 
     # File operation attempted but no permissions to perform it
     class InsufficientPermissions < RuntimeError; end
diff --git a/lib/chef/knife/cookbook_site_install.rb b/lib/chef/knife/cookbook_site_install.rb
index 865f806593..3242dd4297 100644
--- a/lib/chef/knife/cookbook_site_install.rb
+++ b/lib/chef/knife/cookbook_site_install.rb
@@ -179,7 +179,7 @@ class Chef
           return md
         end
 
-        raise "No metadata.rb or metadata.json!"
+        raise Chef::Exceptions::MetadataNotFound
       end
     end
   end