change option name to dry-run and set false as default.

1 files changed, 8 insertions, 6 deletions

diff --git a/lib/chef/knife/cookbook_site_share.rb b/lib/chef/knife/cookbook_site_share.rb
index e5c56f654d..189c9c8db0 100644
--- a/lib/chef/knife/cookbook_site_share.rb
+++ b/lib/chef/knife/cookbook_site_share.rb
@@ -40,11 +40,12 @@ class Chef
         :description => "A colon-separated path to look for cookbooks in",
         :proc => lambda { |o| Chef::Config.cookbook_path = o.split(":") }
 
-      option :upload,
-        :long => "--[no-]upload",
-        :description => "Upload cookbook to SuperMacket, defaults is true. If given --no-upload, only show list of archived files",
+      option :dry_run,
+        :long => '--dry-run',
+        :short => '-n',
         :boolean => true,
-        :default => true
+        :default => false,
+        :description => "Don't take action, only print what files will be upload to SuperMarket."
 
       def run
         if @name_args.length < 2
@@ -72,10 +73,11 @@ class Chef
             exit(1)
           end
 
-          unless config[:upload]
-            ui.info("Not uploading #{cookbook_name}.tgz due to --no-upload flag.")
+          if config[:dry_run]
+            ui.info("Not uploading #{cookbook_name}.tgz due to --dry-run flag.")
             result = shell_out!("tar -tzf #{cookbook_name}.tgz", :cwd => tmp_cookbook_dir)
             ui.info(result.stdout)
+            puts `find #{tmp_cookbook_dir}`
             FileUtils.rm_rf tmp_cookbook_dir
             return
           end