Alternate user execute resource code review feedack

1 files changed, 7 insertions, 3 deletions

diff --git a/lib/chef/provider/script.rb b/lib/chef/provider/script.rb
index 3f89672f21..5df31786bd 100644
--- a/lib/chef/provider/script.rb
+++ b/lib/chef/provider/script.rb
@@ -67,17 +67,21 @@ class Chef
       end
 
       def set_owner_and_group
-        # FileUtils itself implements a no-op if +user+ or +group+ are nil
-        # You can prove this by running FileUtils.chown(nil,nil,'/tmp/file')
-        # as an unprivileged user.
         if ! Chef::Platform.windows?
+          # FileUtils itself implements a no-op if +user+ or +group+ are nil
+          # You can prove this by running FileUtils.chown(nil,nil,'/tmp/file')
+          # as an unprivileged user.
           FileUtils.chown(new_resource.user, new_resource.group, script_file.path)
         else
+          # And on Windows also this is a no-op if there is no user specified.
           grant_alternate_user_read_access
         end
       end
 
       def grant_alternate_user_read_access
+        # Do nothing if an alternate user isn't specified -- the file
+        # will already have the correct permissions for the user as part
+        # of the default ACL behavior on Windows.
         return if new_resource.user.nil?
 
         # Duplicate the script file's existing DACL